Skip to content
This repository was archived by the owner on Nov 4, 2026. It is now read-only.

Commit c6198c2

Browse files
os-justinclaude
andauthored
feat(types)!: retire ComponentInput.label / defaultValue / advanced as ADR-0049 tombstones (objectui#7493 item 1 / objectui#7781) (#7932)
* feat(types)!: retire ComponentInput.label / defaultValue / advanced as ADR-0049 tombstones (objectui#7493 item 1, objectui#7781) The three ComponentInput keys the manifest serializer does not forward, and that nothing reads on any publication or consumption path, are retired on both faces under the maintainer's ruling A of 2026-09-06. Route measured on the built face before editing: ComponentInputSchema is a non-strict z.object, so an undeclared key parses green and is silently stripped -- a deletion would have swallowed 1,162 authored values in silence. So each key stays declared and refuses BY NAME: `?: never` on the interface and retirementTombstone() on the Zod mirror (the objectui#5905 shape). - base.ts / base.zod.ts: three tombstones with the RETIRED docblocks (the census, the serializer's six forwarded keys, the authorship counts, what to write instead: nothing) - every in-repo authoring site deleted: 1,197 keys across 109 registration files (the 908 / 245 / 9 the inputs-literal census counted, plus the three standalone ComponentInput[] arrays), html-elements' PER_TAG_INPUTS record, ELEMENT_DATA_SOURCE_INPUT's label, and the WidgetRegistry seam copy (the one non-test write, which fed nothing) - the nine defaultValue-reading tests re-pinned against the renderer's ACTUAL default (its own fallback read or defaultProps); two shadow-default assertions dropped with the reason on the line; the icon coupling pin keeps its one remaining declared spelling - new pin component-input-retired-keys-7493: both faces refuse at path with the guidance, tsc legs at a real registration shape, forwarded-key controls (accepted and value-enforced), serializer forward set read off disk, an eight-tombstone census of the interface on both faces, and a tree-scoped absence census over every inputs array under packages/ and apps/ - widget.ts records the third divergence (WidgetInput keeps its three, measured reader-less now: objectui#7911); four docs guides stop authoring the keys; changeset (types minor, "Breaking for authored metadata", patch entries for the registration cleanups) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BAZFhALsQsGqxui8sNqM8s * fix(plugin-tree): the named `treeInputs` array stops authoring `label` too `tsc` found the one registration array the inputs-literal census could not see: `treeInputs` is a bare const referenced from two registrations. Its two `label` writes go the way of the other 1,197; the changeset totals and its patch list follow. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BAZFhALsQsGqxui8sNqM8s * test(plugin-detail): the record-details parity pin imports readFileSync once The re-pin added a second `readFileSync` import beside the one the file already carried; `tsc -p tsconfig.test.json` refused the duplicate. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BAZFhALsQsGqxui8sNqM8s * test(console): the record-reach probe restates the six renderer defaults it used to read off `defaultValue` `sampleFor` seeded `relationshipValueField`, `showHeader`, `location`, `align`, `variant` and `size` from the registrations' declared defaults, which happened to be the renderers' own fallbacks and the one configuration under which the probe is askable. With `ComponentInput.defaultValue` retired the generic type samples took over — `'x'` for a parent field, the header chrome on, a location with no actions — and three blocks stopped reaching. The six values now sit in SAMPLE_BY_INPUT beside the read each mirrors. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BAZFhALsQsGqxui8sNqM8s * test(plugin-kanban): drop the `onCardMove.advanced` assertion this PR retires `packages/plugin-kanban/src/index.test.ts` was not in this PR's diff, so its `expect(onCardMoveInput?.advanced).toBe(true)` survived while `plugin-kanban/src/index.tsx` stopped authoring `advanced` — a live CI red (`Test (shard 4/4)`: `AssertionError: expected undefined to be true` at `index.test.ts:62:41`). `tsc` cannot catch it: `expect(x).toBe(true)` accepts a `never | undefined` receiver, so only running the suite finds it. The three sibling assertions beside it stay — `toBeDefined()`, `type === 'code'` and `description` all read live keys. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BAZFhALsQsGqxui8sNqM8s * test(types): drop the retired `label:` from the three pinned registration lines (objectui#7779 pin) `packages/types/src/__tests__/object-view-unmirrored-keys-7779.test.ts` landed on `main` (PR #7922) one minute after this branch merged its base, so its `REGISTRATION_TEXT` hard-codes three `plugin-view/src/index.tsx` registration lines that still carry the `ComponentInput.label` key this PR retires. The pin asserted a fact this change is the reason is no longer true. Each expected string is copied off the registration source rather than composed by hand: only the `label: '…', ` fragment is dropped, every other character is the line as `packages/plugin-view/src/index.tsx` now reads. The assertion stays an exact `toContain` over three entries — the pin's intent (the three local literals are still registered as editable inputs) survives the retirement. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BAZFhALsQsGqxui8sNqM8s --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent b313700 commit c6198c2

132 files changed

Lines changed: 1649 additions & 1256 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 85 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
1+
---
2+
'@object-ui/types': minor
3+
'@object-ui/core': patch
4+
'@object-ui/components': patch
5+
'@object-ui/layout': patch
6+
'@object-ui/app-shell': patch
7+
'@object-ui/plugin-ai': patch
8+
'@object-ui/plugin-calendar': patch
9+
'@object-ui/plugin-charts': patch
10+
'@object-ui/plugin-chatbot': patch
11+
'@object-ui/plugin-dashboard': patch
12+
'@object-ui/plugin-designer': patch
13+
'@object-ui/plugin-detail': patch
14+
'@object-ui/plugin-editor': patch
15+
'@object-ui/plugin-form': patch
16+
'@object-ui/plugin-gantt': patch
17+
'@object-ui/plugin-grid': patch
18+
'@object-ui/plugin-kanban': patch
19+
'@object-ui/plugin-list': patch
20+
'@object-ui/plugin-map': patch
21+
'@object-ui/plugin-markdown': patch
22+
'@object-ui/plugin-report': patch
23+
'@object-ui/plugin-timeline': patch
24+
'@object-ui/plugin-tree': patch
25+
'@object-ui/plugin-view': patch
26+
---
27+
28+
**Breaking for authored metadata:** `ComponentInput.label`, `ComponentInput.defaultValue` and
29+
`ComponentInput.advanced` are RETIRED on both faces (objectui#7493 item ① and objectui#7781;
30+
maintainer ruling A of 2026-09-06, immediate, no deprecation window; ADR-0049 enforce-or-remove).
31+
They are the three keys the manifest serializer does not forward, and nothing read them on any
32+
publication or consumption path.
33+
34+
No manifest ever published them, so no consumer could ever have read them. `sdui-parser`'s
35+
serializer (`packages/sdui-parser/src/index.ts`) forwards exactly six keys per input — `name`,
36+
`type`, `required`, `enum`, `binding`, `description` — so a value authored under any of the three
37+
never reached `sdui.manifest.json`, the generated JSX `.d.ts`, or a diagnostic; its boundary type
38+
has no slot for them; the registry's data-source seam reads `name` only; and neither the designer
39+
nor the app-shell inspectors consult registry `inputs` at all. A structural census over every
40+
`inputs:` array in the repository (re-measured on this change's merge-base, `name` 951 and `type`
41+
951 as the controls) counted the writes: `label` 908, `defaultValue` 245, `advanced` 9 — written on
42+
nearly every registration, read by nothing.
43+
44+
FROM → TO, per key — all three **TOMBSTONED, not removed**, because the route was measured on
45+
the built face before it was chosen: `ComponentInputSchema` is a non-strict `z.object`, and an
46+
undeclared key parses GREEN and is silently STRIPPED, so a deletion would have swallowed 1,162
47+
authored values in silence. The tombstone is what makes the refusal loud and by name.
48+
49+
- `label?: string` → `label?: never` on the interface, `retirementTombstone()` on the Zod mirror.
50+
Migration: delete the key. An input is identified by its `name` on every path that reaches it;
51+
nothing ever rendered a label for it.
52+
- `defaultValue?: any` → `defaultValue?: never` / `retirementTombstone()`. Migration: delete the
53+
key. The renderer's own fallback read IS the default; tell the author about it in `description`,
54+
which IS published. (Tightening the type to `unknown` was ruled out: it closes no error class,
55+
since nothing reads the value.)
56+
- `advanced?: boolean` → `advanced?: never` / `retirementTombstone()`. Migration: delete the key.
57+
No designer surface ever hid an "advanced" input; there is nothing to write instead.
58+
59+
The retirement kit: `?: never` on `ComponentInput` (`packages/types/src/base.ts`), so authoring one
60+
is a `tsc` error at the registration site; `retirementTombstone()` on `ComponentInputSchema`
61+
(`packages/types/src/zod/base.zod.ts`), so an authored value is REFUSED at parse time with
62+
`code: 'invalid_type'`, the key named in the issue `path`, and the migration note as the message
63+
(one string, both channels). Pinned in
64+
`packages/types/src/__tests__/component-input-retired-keys-7493.test.ts`, which also holds a
65+
tree-scoped absence census over every `inputs:` array under `packages/**` and `apps/**`.
66+
67+
Accept-set change, stated plainly for reviewers: a document that sets any of the three keys on a
68+
`ComponentInput` used to parse GREEN (the value was then dropped by the serializer) and now parses
69+
RED. Every in-repo authoring site — 1,199 keys across 110 registration files, the three standalone
70+
`ComponentInput[]` arrays and the two named input arrays `tsc` found included — is deleted in the same change, as the ruling's split rule
71+
requires; the `WidgetRegistry` seam no longer copies the widget-manifest values onto the synthesized
72+
`ComponentInput` (they fed nothing), and the data-source declaration `ELEMENT_DATA_SOURCE_INPUT`
73+
drops its `label`. The patch entries on the other packages record exactly that: their registrations
74+
stop authoring inert keys, with no runtime or published-manifest change.
75+
76+
The nine test files that read `defaultValue` off a registration were re-pinned against the
77+
renderer's ACTUAL default (its own fallback read, or the `defaultProps` it ships) instead of the
78+
declaration that went away; two assertions that only restated the shadow default were dropped with
79+
the reason on the line.
80+
81+
The in-repo zero is what was measured. Whether anything OUTSIDE this repository writes these keys
82+
is not measurable from here (the objectui#5674 limit); converting such a write from a silent drop
83+
into a named refusal is exactly what the tombstones buy. `WidgetInput`'s own `label` /
84+
`defaultValue` / `advanced` (the widget-manifest face) stay declared and writable — nothing has
85+
ruled on that face; that it now has no reader either is recorded as objectui#7911.

‎apps/console/src/__tests__/public-block-binding-reach.test.tsx‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,9 @@ const sampleFor = (input: any): unknown => {
324324
if (input.name === 'details') {
325325
return [{ childObject: PROBE_OBJECT, title: 'Probe Detail' }];
326326
}
327-
if (input.defaultValue !== undefined) return input.defaultValue;
327+
// (`ComponentInput.defaultValue` is an ADR-0049 tombstone since objectui#7493 —
328+
// no registration declares a default any more, so the sample is decided by the
329+
// declared TYPE below, as it already was for every input without one.)
328330
switch (input.type) {
329331
case 'number':
330332
return 1;

‎apps/console/src/__tests__/record-block-record-reach.test.tsx‎

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,12 +245,38 @@ const SAMPLE_BY_INPUT: Readonly<Record<string, unknown>> = {
245245
// affordance is configured against something that exists rather than at a
246246
// dangling name.
247247
add: { picker: { object: PROBE_CHILD_OBJECT } },
248+
// The SIXTH instance arrived with objectui#7493, which retired
249+
// `ComponentInput.defaultValue`: until then `sampleFor` seeded these six from
250+
// the registration's declared default, which happened to be the renderer's
251+
// own fallback and the one value under which the probe is askable. The
252+
// declared default is gone (nothing but this sampler ever read it), so each
253+
// renderer default is restated HERE, next to the read it mirrors:
254+
// - `record:related_list` reads `relationshipValueField || 'id'`; the
255+
// generic `'x'` names a parent field the record does not carry, so the
256+
// list holds its fetch (by design) and the record cannot reach the output.
257+
// - `record:details` passes `showHeader ?? false`; with the header chrome ON
258+
// the same record renders differently twice and the stability control
259+
// (rightly) refuses to grade the probe. The header is not what this probe
260+
// asks about.
261+
// - `record:quick_actions` reads `location || 'record_header'`,
262+
// `align || 'end'`, `variant || 'default'`, `size || 'sm'`; the
263+
// probe action is declared at the header location, and the generic
264+
// samples (`'x'` for the two strings, the enum's first arm for the
265+
// other two) point the bar at a location with no actions.
266+
relationshipValueField: 'id',
267+
showHeader: false,
268+
location: 'record_header',
269+
align: 'end',
270+
variant: 'default',
271+
size: 'sm',
248272
};
249273

250274
/** Fill one declared input. */
251275
const sampleFor = (input: any): unknown => {
252276
if (input.name in SAMPLE_BY_INPUT) return SAMPLE_BY_INPUT[input.name];
253-
if (input.defaultValue !== undefined) return input.defaultValue;
277+
// (`ComponentInput.defaultValue` is an ADR-0049 tombstone since objectui#7493 —
278+
// no registration declares a default any more, so the sample is decided by the
279+
// declared TYPE below, as it already was for every input without one.)
254280
switch (input.type) {
255281
case 'number': return 1;
256282
case 'boolean': return true;

‎content/docs/guide/architecture.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ ComponentRegistry.register('my-widget', MyWidgetComponent, {
202202
category: 'Custom',
203203
icon: 'box',
204204
inputs: [
205-
{ name: 'title', type: 'string', label: 'Title' }
205+
{ name: 'title', type: 'string' }
206206
]
207207
})
208208
```

‎content/docs/guide/component-registry.md‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,8 @@ ComponentRegistry.register('my-component', MyComponent, {
127127
category: 'Custom',
128128
icon: 'component-icon',
129129
inputs: [
130-
{ name: 'title', type: 'string', label: 'Title' },
131-
{ name: 'content', type: 'string', label: 'Content' }
130+
{ name: 'title', type: 'string' },
131+
{ name: 'content', type: 'string' }
132132
]
133133
})
134134
```
@@ -434,11 +434,11 @@ ComponentRegistry.register('rating', RatingComponent, {
434434
category: 'Form',
435435
labelling: 'group',
436436
inputs: [
437-
{ name: 'name', type: 'string', label: 'Name', required: true },
438-
{ name: 'label', type: 'string', label: 'Label' },
439-
{ name: 'maxStars', type: 'number', label: 'Max stars', defaultValue: 5 },
440-
{ name: 'required', type: 'boolean', label: 'Required' },
441-
{ name: 'disabled', type: 'boolean', label: 'Disabled' }
437+
{ name: 'name', type: 'string', required: true },
438+
{ name: 'label', type: 'string' },
439+
{ name: 'maxStars', type: 'number', description: 'Defaults to 5 — the renderer\'s own fallback' },
440+
{ name: 'required', type: 'boolean' },
441+
{ name: 'disabled', type: 'boolean' }
442442
]
443443
})
444444

‎content/docs/guide/plugin-development.md‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,8 @@ ComponentRegistry.register('board', BoardRenderer, {
158158
label: 'Board View',
159159
category: 'plugin',
160160
inputs: [
161-
{ name: 'columns', type: 'array', label: 'Columns', required: true },
162-
{ name: 'items', type: 'array', label: 'Items', required: true },
161+
{ name: 'columns', type: 'array', required: true },
162+
{ name: 'items', type: 'array', required: true },
163163
],
164164
defaultProps: {
165165
columns: [
@@ -366,20 +366,19 @@ export interface BoardSchema extends BaseSchema {
366366
}
367367
```
368368

369-
Declare `ComponentInput` entries when registering so the visual designer can offer a property panel:
369+
Declare `ComponentInput` entries when registering: they are what the published manifest (`sdui.manifest.json`) and the JSX-page compiler's diagnostics read. Each entry carries the six keys the manifest forwards — `name`, `type`, `required`, `enum`, `binding`, `description`; a default belongs in the renderer's own fallback read and, for the author, in `description` (`label`, `defaultValue` and `advanced` are retired keys — nothing ever read them):
370370

371371
<!-- doc-snippet: fragment — continues the board example: ComponentRegistry and BoardRenderer both come from step 3's src/index.tsx; this block shows only the inputs metadata -->
372372
```tsx
373373
ComponentRegistry.register('board', BoardRenderer, {
374374
inputs: [
375-
{ name: 'columns', type: 'array', label: 'Columns', required: true },
376-
{ name: 'items', type: 'array', label: 'Items', required: true },
375+
{ name: 'columns', type: 'array', required: true },
376+
{ name: 'items', type: 'array', required: true },
377377
{
378378
name: 'layout',
379379
type: 'enum',
380-
label: 'Layout',
381380
enum: ['horizontal', 'vertical'],
382-
defaultValue: 'horizontal',
381+
description: 'Defaults to "horizontal" — the renderer\'s own fallback',
383382
},
384383
],
385384
});

‎packages/app-shell/src/views/record-approvals-renderer.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ ComponentRegistry.register('approvals', RecordApprovalsRenderer, {
8383
category: 'record',
8484
label: 'Approvals',
8585
icon: 'Stamp',
86-
inputs: [{ name: 'className', type: 'string', label: 'CSS Class' }],
86+
inputs: [{ name: 'className', type: 'string' }],
8787
});
8888

8989
export default RecordApprovalsRenderer;

‎packages/app-shell/src/views/record-attachments-renderer.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ ComponentRegistry.register('attachments', RecordAttachmentsRenderer, {
7272
category: 'record',
7373
label: 'Attachments',
7474
icon: 'Paperclip',
75-
inputs: [{ name: 'className', type: 'string', label: 'CSS Class' }],
75+
inputs: [{ name: 'className', type: 'string' }],
7676
});
7777

7878
export default RecordAttachmentsRenderer;

‎packages/components/src/__tests__/icon-renderer-declared-default.test.ts‎

Lines changed: 34 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -68,43 +68,51 @@ import '../renderers/basic/icon';
6868
// extend the gate to the whole population — ⛔ not to restore a pin over one
6969
// registration.
7070
//
71-
// ── What this file still asserts, and why that half survives the same argument
72-
// The coupling claim below is NOT a claim about lucide's vocabulary. It needs no
73-
// external record, no copied tokeniser and no consumer to be well-formed: it
74-
// says two declarations in ONE registration agree with each other. It therefore
75-
// cannot drift the way the membership half did, costs nothing to keep, and
76-
// becomes correct the instant any consumer appears.
71+
// ── The COUPLING half was retired at objectui#7493 ──────────────────────────
72+
// It asserted that the registration's `icon` meta and the glyph input's
73+
// `defaultValue` named the same glyph. `ComponentInput.defaultValue` is an
74+
// ADR-0049 retirement tombstone since objectui#7493 (with `label` and
75+
// `advanced`, objectui#7781): the manifest serializer never forwarded it and
76+
// no consumer of `ComponentMeta.inputs` — no designer, no palette, no renderer
77+
// — ever read it, so the "second spelling" was a shadow value only this pin
78+
// compared. There is no renderer default to re-pin it against either: an
79+
// `icon` node with no `icon` name renders the PLACEHOLDER branch and warns
80+
// (objectui#5631), by design — the renderer has no fallback glyph.
81+
//
82+
// ── What this file still asserts
83+
// The registration's `icon` meta — the ONE declared spelling left — is a real
84+
// icon name, and the `icon` input is still declared (it is what the manifest
85+
// publishes for the key). Both are preconditions the old coupling test carried;
86+
// they survive because the ledger in
87+
// `scripts/__tests__/check-lucide-icon-record-names.test.ts` keeps this file as
88+
// the record of the objectui#5936 retirement, and because a registration whose
89+
// palette glyph silently went blank is the objectui#5622 defect's other half.
7790
// ---------------------------------------------------------------------------
7891

7992
const meta = ComponentRegistry.getMeta('icon', 'ui');
8093
const glyphInput = meta?.inputs?.find(input => input.name === 'icon');
8194

82-
/** Both declared spellings, each labelled by the surface it drives. */
83-
const DECLARED_DEFAULTS: Array<[string, string | undefined]> = [
84-
['registration `icon` (the palette entry glyph)', meta?.icon],
85-
['`icon` input `defaultValue` (what a dropped `icon` renders)', glyphInput?.defaultValue as string | undefined],
86-
];
87-
88-
describe('the `ui:icon` renderer\'s declared spellings agree (objectui#5622)', () => {
89-
it('both declared spellings were actually found — the precondition', () => {
90-
// Load-bearing, not ceremony: the assertion below compares two values that
91-
// are BOTH `undefined` if the registry read comes back empty, and
92-
// `undefined === undefined` passes. Without this the coupling check goes
93-
// vacuously green on a registration that no longer exists.
95+
describe('the `ui:icon` registration\'s one declared glyph spelling (objectui#5622, objectui#7493)', () => {
96+
it('the registration and its `icon` input were actually found — the precondition', () => {
97+
// Load-bearing, not ceremony: `typeof undefined` is a string too, so the
98+
// glyph assertion below needs the registration to exist first.
9499
expect(meta, '`ui:icon` is not registered — the import above no longer registers it.').toBeDefined();
95100
expect(
96101
glyphInput,
97102
'the `icon` input is gone from the `ui:icon` registration — fix the reader or the registration.',
98103
).toBeDefined();
99-
for (const [surface, spelling] of DECLARED_DEFAULTS) {
100-
expect(typeof spelling, `${surface} declares no icon name at all`).toBe('string');
101-
}
102104
});
103105

104-
it('keeps the palette glyph and the dropped default the same name', () => {
105-
// The defect was one name in two places; the repair is only correct if they
106-
// stay one name. Split them and the palette advertises a glyph the dropped
107-
// component does not render.
108-
expect(meta?.icon).toBe(glyphInput?.defaultValue);
106+
it('declares the palette glyph as a non-empty icon name', () => {
107+
expect(typeof meta?.icon, 'registration `icon` (the palette entry glyph) declares no icon name at all').toBe('string');
108+
expect(meta?.icon).not.toBe('');
109+
});
110+
111+
it('the `icon` input carries no declared default — the tombstone, read off the registry', () => {
112+
// Not `toBeUndefined()` on the property: that would be vacuously green on a
113+
// missing input too (the precondition above guards it), and the point is
114+
// that the key is ABSENT from what the registration publishes, not that its
115+
// value happens to be undefined.
116+
expect(glyphInput).not.toHaveProperty('defaultValue');
109117
});
110118
});

‎packages/components/src/__tests__/record-picker-inputs-spec-parity.test.ts‎

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -209,17 +209,13 @@ describe('element:record_picker — registry inputs vs @objectstack/spec', () =>
209209
expect(description).toMatch(/\$filter/);
210210
});
211211

212-
it('carries no `defaultValue` on the filter entry', () => {
213-
// A default here would pre-fill every picker in the designer with a filter
214-
// the renderer has no opinion about — and a filter's default is not "empty
215-
// object", it is "no filter at all", which `undefined` already is. The spec
216-
// declares no default either.
217-
//
218-
// Existence asserted first: `input('filter')?.defaultValue` is also
219-
// `undefined` when the input is GONE, so without this line the check would
220-
// pass most loudly in the one case it is supposed to notice.
212+
it('declares no default for `filter` — the spec parses none in', () => {
213+
// A filter's default is not "empty object", it is "no filter at all", which
214+
// `undefined` already is, and the spec declares no default. (This used to
215+
// also assert the registration carried no `ComponentInput.defaultValue`;
216+
// that key is an ADR-0049 tombstone since objectui#7493, so the spec's
217+
// parse is the one channel a default could reach an author through.)
221218
expect(input('filter')).toBeDefined();
222-
expect(input('filter')?.defaultValue).toBeUndefined();
223219
expect(
224220
ElementRecordPickerPropsSchema.safeParse({ object: 'account' }).data,
225221
).not.toHaveProperty('filter');

0 commit comments

Comments
 (0)