This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Commit f5eec63
feat(app-shell): Studio home returns to the Studio landing; the two Setup exits say so (#12590)
Fixes #12513
Clause-②: no
## What changed
**Target 1: the header's first button returns to the Studio landing.**
In the shell header of `StudioDesignSurface.tsx`, the first button now
navigates to `/studio` (the `BuilderLanding` page) instead of the
deployment's home path. It keeps the `confirmLeavePillar()` gate. It is
titled "Studio home" (new key `engine.studio.landingHome`) and carries
the new testid `studio-home`. The console home is one click further,
through the landing's own top bar. `StudioRoute.tsx` needed no change:
`/studio` already renders the landing.
**Target 2: the package switcher's first row is "Studio home".**
`PackageSwitcher` gets a new first row (testid `studio-switcher-home`)
above the package list. It is gated by `beforeNavigate` like the other
rows. The deleted-package eviction is unchanged.
**Target 3: the two Setup exits say so.**
- On the landing, each installed card's link (testid
`studio-landing-overlay`, unchanged) reads "Open in Setup" with an
outward arrow (`ArrowUpRight`). I reworded the en and zh values of the
existing key `engine.studio.landing.overlay`. Its route and its overlay
tooltip (`engine.studio.landing.overlayTitle`) are unchanged.
- The empty Organization flows block (`StudioEmptyState`, `auto-empty`)
gets an "Open in Setup" link as its `action` (new key
`engine.studio.org.openSetup`, new testid `auto-empty-open-setup`). It
is a link, not a create button, since this scope creates nothing. A
package's own empty block is unchanged.
- The link's route is measured, not invented. The Setup app's nav entry
`nav_packaged_automation` (objectstack
`packages/platform-objects/src/apps/setup-nav.contributions.ts`) names
the component ref `automation:packaged`. app-shell registers that ref in
`builtinComponents`, and the console serves it at
`/apps/setup/component/automation/packaged`. The link builds that URL
from the ref with `componentRefToUrlSegments`, the same helper
`PackagedAutomationPage.navContribution.test.tsx` pins. In the live
console, following it opens the Setup page headed "Packaged automation".
**Retired key.** `engine.studio.home` ("Back to home" / "返回主页") is
removed from the en and zh designer tables. After the header change
nothing reads it, and `check:i18n-dead-keys` no longer lists it.
No change to Setup. No existing testid was removed, and every i18n key
that has a reader stays. New keys are in en and zh, the two halves of
the designer table.
## Deviations
- `StudioDesignSurface.pillarNavGuard.test.tsx`: its Home-button case
clicked "Back to home" and expected `/home`. Target 1 changes both, so
it now clicks "Studio home" and expects the `/studio` landing. The
cancel and confirm gate assertions are unchanged.
## Screenshots (evidence branch `claude/issue-12513-evidence`, never
merged)
Console at 1280 px against HotCRM `63db83e` under `objectstack dev
--fresh`.
- Landing, installed card, light:
https://github.com/objectstack-ai/objectui/blob/bb89675168aad3acdc5241c999965bb6fe72f269/docs/design/studio-redesign/findings/12513/12513-landing-installed-card-light.png?raw=true
- Landing, installed card, dark:
https://github.com/objectstack-ai/objectui/blob/bb89675168aad3acdc5241c999965bb6fe72f269/docs/design/studio-redesign/findings/12513/12513-landing-installed-card-dark.png?raw=true
- Organization flows empty state, light:
https://github.com/objectstack-ai/objectui/blob/bb89675168aad3acdc5241c999965bb6fe72f269/docs/design/studio-redesign/findings/12513/12513-org-flows-empty-light.png?raw=true
- Organization flows empty state, dark:
https://github.com/objectstack-ai/objectui/blob/bb89675168aad3acdc5241c999965bb6fe72f269/docs/design/studio-redesign/findings/12513/12513-org-flows-empty-dark.png?raw=true
- Package switcher open, "Studio home" first row:
https://github.com/objectstack-ai/objectui/blob/bb89675168aad3acdc5241c999965bb6fe72f269/docs/design/studio-redesign/findings/12513/12513-switcher-studio-home-row-dark.png?raw=true
- The org link's landing, Setup > Packaged automation:
https://github.com/objectstack-ai/objectui/blob/bb89675168aad3acdc5241c999965bb6fe72f269/docs/design/studio-redesign/findings/12513/12513-org-link-lands-on-packaged-automation-dark.png?raw=true
## Test evidence
On HEAD `c94f216` (origin/main `ae923ec` merged in, plus the key
retirement):
- Targeted vitest over `StudioDesignSurface.homeLoop-12513`,
`BuilderLanding.setupExit-12513`, `StudioDesignSurface.pillarNavGuard`
and `StudioItemHeader.statusPlace-12524`: 4 files, 17 tests passed, exit
0.
- `type-check`: exit 0. eslint on the touched files: exit 0, no errors.
- `check:i18n-keys`, `check:i18n-drift`, `check:i18n-designer-parity`,
`check:i18n-dead-keys` (no longer lists `engine.studio.home`) and
`check-changeset-presence`: exit 0.
On `385fa92`, before the merge:
- New pins: `StudioDesignSurface.homeLoop-12513.test.tsx` (header button
goes to `/studio`; the switcher's first row is Studio home and goes to
`/studio`; the org empty block links to Setup > Packaged automation and
offers no create button; control: a package's empty block has no Setup
link) and `BuilderLanding.setupExit-12513.test.tsx` (label, outward
arrow, unchanged route; the packaged-automation route built from its
ref).
- Every `StudioDesignSurface.*.test.tsx` and
`BuilderLanding.*.test.tsx`, including
`BuilderLanding.accessibleNames-12510`: 88 files, 587 tests passed, exit
0.
- `pnpm --filter @object-ui/app-shell test`: exit 0. Test Files 1427
passed, 1 skipped (1428); Tests 13550 passed, 9 skipped (13559).
- `build`: exit 0, dist completeness verified.
- Ablations, each landed, turned red and was restored, with `git diff
HEAD` empty afterwards: header destination changed to `/home`; switcher
row destination changed to `/home`; the package-less action arm
disabled; the en label reverted; the route spelled without `component/`.
## Acceptance notes
- A third Setup exit, the in-package read-only link ("Read-only ·
Customize with an overlay", `studio-readonly-link`), still goes to Setup
without saying so. It is outside this card's two exits and its file
surface, so it is noted here and not changed.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01Li9iYX6uAhVZJgyCfJ1Maz)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 92c2a69 commit f5eec63
7 files changed
Lines changed: 420 additions & 24 deletions
File tree
- .changeset
- packages/app-shell/src/views
- metadata-admin
- studio-design
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2890 | 2890 | | |
2891 | 2891 | | |
2892 | 2892 | | |
2893 | | - | |
| 2893 | + | |
| 2894 | + | |
| 2895 | + | |
2894 | 2896 | | |
2895 | 2897 | | |
2896 | 2898 | | |
| |||
3048 | 3050 | | |
3049 | 3051 | | |
3050 | 3052 | | |
3051 | | - | |
| 3053 | + | |
| 3054 | + | |
3052 | 3055 | | |
3053 | 3056 | | |
3054 | 3057 | | |
| |||
3057 | 3060 | | |
3058 | 3061 | | |
3059 | 3062 | | |
| 3063 | + | |
| 3064 | + | |
3060 | 3065 | | |
3061 | 3066 | | |
3062 | 3067 | | |
| |||
6187 | 6192 | | |
6188 | 6193 | | |
6189 | 6194 | | |
6190 | | - | |
| 6195 | + | |
6191 | 6196 | | |
6192 | 6197 | | |
6193 | 6198 | | |
| |||
6340 | 6345 | | |
6341 | 6346 | | |
6342 | 6347 | | |
6343 | | - | |
| 6348 | + | |
6344 | 6349 | | |
6345 | 6350 | | |
6346 | 6351 | | |
| |||
6349 | 6354 | | |
6350 | 6355 | | |
6351 | 6356 | | |
| 6357 | + | |
6352 | 6358 | | |
6353 | 6359 | | |
6354 | 6360 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| |||
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
51 | 63 | | |
52 | 64 | | |
53 | 65 | | |
| |||
360 | 372 | | |
361 | 373 | | |
362 | 374 | | |
363 | | - | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
364 | 379 | | |
365 | 380 | | |
366 | 381 | | |
| |||
0 commit comments