This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Commit f7fcc2c
fix(components): pin
Fixes #9569
`packages/components/src/index.css` opened with a bare `@import
'tailwindcss';` — the only one of this repo's four stylesheet entries
without a `source(none)` pin. It now reads `@import 'tailwindcss'
source(none);`, keeping the FULL Tailwind import because this is the
root sheet: preflight, the `@theme` block and the base layer still emit
exactly as before.
## The card's mechanism sentence is falsified, and the PM had already
measured it
The card asks for "the `source(none)` pin its three siblings carry
(`@import 'tailwindcss' source(none);` … mirroring `fields`)". The
siblings carry no such thing. `packages/fields/src/index.css` states
verbatim *"This file has no `@import 'tailwindcss'` on purpose"*; what
`fields`, `plugin-grid` and `plugin-kanban` carry is `@reference` on
components' entry plus a utilities-only `@import
'tailwindcss/utilities.css' layer(utilities) source(none);`. Mirroring
them literally would have dropped preflight and the shared theme from
the only sheet that ships them. The PM seat flagged this before dispatch
and the landed spelling is the one it proposed; I verified it is legal
Tailwind v4 and that preflight and the theme survive it.
## Three things measured rather than assumed
**1. The `@source` lines actually fire.** This was the highest-risk
failure mode: once detection is off, those lines are the only thing
keeping the sheet non-empty, and a near-empty sheet builds just as green
as a correct one. `packages/runner/src/index.css` records five `@source`
lines that were each wrong by one `src` segment and contributed nothing.
Two legs, both restoring from `HEAD` with the restore proven by blob
hash:
- *Ablation* — deleting `@source '../src/**/*.{ts,tsx}'` collapses the
compilation from 158,345 bytes / 1289 classes to 9,694 bytes / 4
classes. The line is load-bearing.
- *Absolute-path probe* — rewriting all three `@source` paths to
absolute and moving the compile base to the package root produces a
**byte-identical** sheet. So the relative spelling lands exactly on
`packages/components/src`, and `base` governs only the automatic root,
never the `@source` lines.
**2. Detection roots at the PROCESS CWD, not at
`packages/components/`.** The card says the latter; `fields` and
`runner` say the former, and they are right. Same commit, same command:
1312 classes / 161,225 bytes with the cwd at the package, 3303 classes /
439,726 bytes from the repo root. After the pin the compiled sheet is
byte-identical from either directory, which it was not before.
**3. Class census re-derived, not quoted.** 1312 → 1289, so exactly 23
leave, and each one traces to a prose file: 12 to `CHANGELOG.md`, 3 to
`README.md`, 2 to `README_SHADCN_SYNC.md`, 4 to the JSON examples in the
renderer docs, 1 to `shadcn-components.json`, and `invert` to an
ordinary English word inside a comment in `tsconfig.test.json`. **Zero
of the 23 is emitted by any shipped source under
`packages/components/src`**, checked with a matcher that respects
Tailwind candidate boundaries — a substring grep scores
`disabled:cursor-not-allowed` as a hit for `cursor-not-allowed`, which
is a different candidate producing a different rule — and run with three
lit positive controls (`bg-background`, `text-muted-foreground`,
`w-full` are found in 25, 59 and 59 shipped files).
## MUST_SURVIVE, both legs, on both kinds of injection
Reproducing what `changeset:version` does — appending the changeset body
line to `packages/components/CHANGELOG.md` — then running each plugin's
own builder with `write: false` against the components sheet compiled
from the entry as it stands on each leg:
| injection | leg | components sheet | plugin-kanban |
|---|---|---|---|
| `text-muted-foreground/60` (not in MUST_SURVIVE) | BEFORE | 1313
classes, has it | BUILD_OK — and the class is **stripped** from kanban's
sheet |
| `text-muted-foreground/60` | AFTER | 1289, absent | BUILD_OK, class
**survives** |
| `bg-card/60` (in MUST_SURVIVE) | BEFORE | 1313, has it |
**BUILD_THREW** — `The subtraction removed 1 utility(ies) that only this
build can produce: .bg-card/60` |
| `bg-card/60` | AFTER | 1289, absent | BUILD_OK, class survives |
All six MUST_SURVIVE entries pass for `plugin-kanban`, `plugin-grid` and
`fields` on the AFTER leg.
## Beyond the card: this is already breaking three published packages
today
Running the same harness with a **non-Tailwind** injection isolates the
fix from the injection, and the plugin sheets still change — the prose
contamination is stripping classes from sibling published artifacts on
`main` right now, with no `changeset:version` needed. Restored by this
PR:
- `@object-ui/plugin-kanban` — `h-[600px]`, `sm:px-6`, `sm:py-4`
- `@object-ui/plugin-grid` — `bg-blue-50`, `cursor-not-allowed`
- `@object-ui/fields` — `bg-blue-50`, `bg-blue-500`, `bg-gray-50`,
`text-white`
Each is emitted by that package's own shipped source (`KanbanImpl.tsx`
spells `px-4 sm:px-6`, `FormulaBar.tsx` spells `cursor-not-allowed`,
`ImageLightbox.tsx` spells `text-white`), and each was being subtracted
out because components' prose-polluted sheet happened to contain it.
That is why the changeset names four packages, not one.
## Deviations from the card, all measurement-driven
1. **`minor`, not `patch`.** Removing utilities from a published
stylesheet contracts a published artifact. This repo forbids `major`
outside the `@objectstack` major-sync release and ships its own breaking
changes as `minor` with the break spelled out, which is what the
changeset body does.
2. **Four packages named, not one.** The three siblings' published
sheets change too, measured above.
3. **The `@source` pin test needed repairing, and gained a leg.** Its
docblock asserted the entry "opens with a bare `@import 'tailwindcss'`,
so automatic source detection is ON" — a claim this branch falsifies,
and it also had `base` backwards. Corrected, and a second test now pins
the prose door shut: it asserts `.flex-shrink-0` is absent from the
compiled sheet behind a lit control asserting `CHANGELOG.md` still names
it. Reverting the entry to its bare import turns that test red (vitest
exit 1); it passes on the fix.
4. **One ledger entry.** The new test reads a markdown file, so
`scripts/markdown-test-inputs.mjs` needs a verdict for it. Adjudicated
with what it reads and what the scanner offered that it does not.
`flex-shrink-0` is worth a second look: it is a deprecated Tailwind v3
alias this repo deliberately migrated away from, and it was shipping in
the published bundle **solely because the changelog entry announcing
that migration names it**. Same for `w-[--sidebar-width]` and the
`origin-[--radix-` pair — the changelog entry recording the move to v4
syntax quotes the old spelling, and that quote recreated the v3 classes.
## `changeset-release.yml`
One sentence, next to the claim it qualifies. `THE VERSION STEP CANNOT
MOVE A SOURCE BYTE` is the design note that made this defect invisible
from the release lane: a generated `CHANGELOG.md` is a Tailwind source
input, which is exactly how a changeset body reached `dist/index.css`.
## Gates
Derived by hand from this repo's own `package.json` and
`.github/workflows/`, ⛔ not from the dispatch prompt.
`scripts/pm/dispatch-gates.mjs` lives only in `objectstack` and
**refuses** to answer for this repo — asserted with `--repo
objectstack-ai/objectui`, exit 2: *"Gate families are derived from the
workflows and check scripts of the tree this process runs in."*
| gate | exit |
|---|---|
| `check-changeset-presence` | 0 |
| `check-changeset-no-major` | 0 |
| `check-changeset-fixed` | 0 |
| `check-changeset-claims` (report-only) | 0 |
| `check-control-bytes` | 0 |
| `check-new-cross-file-line-citations` | 0 — 0 new citations |
| `check-lint-coverage` | 0 — 46/46 packages, 0 errors |
| `eslint --no-inline-config` on the changed files | 0 |
| `check-governed-queue-guard --self-test` | 0 |
| build of the dependency closure | 0 |
| `@object-ui/components` `type-check` | 0 |
| `vitest run packages/components/` | 0 — 276 files, 2699 tests |
| `vitest run scripts/__tests__` | 0 — 164 files, 4779 tests |
NOT MEASURED, with reasons, ⛔ not read as green:
`check-governed-queue-guard` (exit 1, needs `GITHUB_EVENT_PATH`; it
refuses to exit 0 when it cannot look), `check-required-check-set` (exit
2, HTTP 401 on the branch-rules API), `check-merge-queue-head` (exit 2,
`GITHUB_REPOSITORY` unset). All three are CI-credentialed patrols, and
none reads a path in this diff.
This diff touches **no governed surface** — classified against the
guard's own `GOVERNED_SURFACES` export with three lit controls
(`AGENTS.md`, `docs/adr/…`, `skills/…` all classify correctly).
## Acceptance notes
- `objectui#8455` covers `packages/runner/src/index.css`, which carries
the same bare import: its census names that row explicitly as
**published**, and its shape C is a repo-wide gate over exactly this. It
genuinely covers it, so this PR does not widen to runner and no
duplicate card was filed. Its shape A is this card, and it predicted the
removal at 23 rules including `.flex-shrink-0` — which is what was
measured here.
- Noted, not filed: `objectui#9569`'s own body cites
`plugin-published-stylesheet.test.ts:196/:252` and `KanbanImpl.tsx:492`,
cross-file line addresses of the form this repo's `#11` bans. An issue
body is not a carrier that rule names, and nothing re-reads it.
Successor: none.
- Noted, not filed: `packages/components/src/index.css` spells its scan
`@source '../src/**'` where the three siblings spell `'./**'`. Both
resolve to the same directory, proven byte-identically above, so this is
cosmetic drift, not a defect. Successor: whoever implements
`objectui#8455`'s repo-wide gate.
---
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01XeoGH6X7MtfbjcRDscyXi1
---
_Generated by [Claude
Code](https://claude.ai/code/session_01XeoGH6X7MtfbjcRDscyXi1)_
---------
Co-authored-by: Claude <noreply@anthropic.com>source(none) on the root stylesheet entry so prose stops compiling into the published sheet (#9579)1 parent 4a94c38 commit f7fcc2c
5 files changed
Lines changed: 190 additions & 10 deletions
File tree
- .changeset
- .github/workflows
- packages/components/src
- __tests__
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1078 | 1078 | | |
1079 | 1079 | | |
1080 | 1080 | | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
1081 | 1087 | | |
1082 | 1088 | | |
1083 | 1089 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
41 | | - | |
| 42 | + | |
42 | 43 | | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
50 | 65 | | |
51 | 66 | | |
52 | 67 | | |
| |||
73 | 88 | | |
74 | 89 | | |
75 | 90 | | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
76 | 97 | | |
77 | 98 | | |
78 | 99 | | |
| |||
100 | 121 | | |
101 | 122 | | |
102 | 123 | | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
103 | 142 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
2 | 38 | | |
3 | 39 | | |
4 | 40 | | |
| |||
10 | 46 | | |
11 | 47 | | |
12 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
13 | 62 | | |
14 | 63 | | |
15 | 64 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
238 | 238 | | |
239 | 239 | | |
240 | 240 | | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
241 | 252 | | |
242 | 253 | | |
243 | 254 | | |
| |||
0 commit comments