Skip to content
This repository was archived by the owner on Nov 4, 2026. It is now read-only.

Commit fb336df

Browse files
os-zhuangos-support-aiclaudehotlong
authored
chore(deps): lucide-react 1.31.0 -> 1.43.0, with the one retired spelling repaired (#8941)
> ⚠️ **GOVERNED — this PR stays a draft until an authorized approval is on it.** `node scripts/check-governed-queue-guard.mjs --test` over this PR's file list answers `GOVERNED — 1 of 42 path(s)`: `skills/objectui/guides/plugin-development.md`, the published skills catalog. One governed path governs the whole PR. ⛔ Not to be flipped ready, enqueued or armed with auto-merge until `os-zhuang` or `hotlong` leaves an APPROVED review; ⛔ no seat approves it. After that approval the claiming seat lands it. Moves `lucide-react` from `^1.31.0` to `^1.43.0` across the workspace, repairs what the jump breaks, and executes the maintainer's **ruling C** on this PR (comment `5750512894`, verbatim 「8941 C」): relax the two pins, land the bump. The re-measured census comes first, then ruling C, then the checks. The sections under **Historical** further down were measured on older trees and are ⛔ not re-derived. objectui#7058 (the Dependabot branch this PR superseded) is already closed, unmerged, since 2026-09-13. This PR never named it with a closing keyword; closing it was never this PR's. ## 1. This round's census — re-measured on 2026-09-25 against the INSTALLED 1.43.0 Tree: this branch after merging `main` at `21d34d5e2` (merge commit `423a1a59a`); the censuses read the committed tree through `git ls-tree` plus `git cat-file`, so enumeration and reading come from the same source. The installed `lucide-react` is 1.43.0, integrity-equal to the registry tarball (`sha512-ubtnda1f…`). ⚠️ **Correction to the baseline.** `main` does not install 1.31.0. Its manifests say `^1.31.0`, but since the `pnpm dedupe` of #9316 (2026-09-13) its lockfile resolves **1.35.0**, one copy. So this PR moves the declared range `^1.31.0` to `^1.43.0` and the installed version 1.35.0 to 1.43.0. Every comparison below is taken against both 1.31.0 and 1.35.0. ### 1a. What lucide itself changed (read off the three installed artifacts) | Surface | 1.31.0 | 1.35.0 (main today) | 1.43.0 | Removed, 1.35.0 to 1.43.0 | |---|---|---|---|---| | runtime exports of `lucide-react` | 6068 | 6110 | 6224 | **0** | | public names in `lucide-react.d.ts` | 6072 | 6114 | 6230 | **0** | | `dynamicIconImports` keys (= `iconNames`) | 2025 | 2039 | 2077 | **0** | | keys of the runtime `icons` record | 1767 | 1781 | 1818 | **1 — `Trash2`** | | icon modules exporting `__iconNode` | 1767 | 1781 | **0** | — | | icon modules exporting `__iconData` | 0 | 0 | 1818 | — | | icon modules declaring `aliases` | 0 | 0 | 248 | — | 1.31.0 to 1.43.0 also removes 0 exports, 0 type names, 0 dynamic names and the same single record key. ### 1b. Census 1 — every name this tree imports from `lucide-react` resolves TypeScript-AST scan of every tracked code file: import and export-from declarations (named, default, namespace, `type`), `import()` / `vi.mock()` / `require.resolve()` calls naming the package, `import type` nodes, and static member reads off a namespace import or off `icons`. | Tree | importing files | sites | distinct value names | type names | fail on 1.43.0 | fail on 1.35.0 | fail on 1.31.0 | |---|---|---|---|---|---|---|---| | this branch after the merge | 413 | 1980 | 329 | 2 (`LucideIcon`, `LucideProps`) | **0** | 0 | 0 | | `6f20cfb06` (the 2026-09-20 head) | 419 | 2018 | 331 | 2 | 0 | 0 | 0 | Controls, in the same run: an injected `Trash`, `type LucideIcon` and namespace read `L.Pencil` resolve; an injected `NotARealLucideIcon` and `L.AlsoNotReal` are both reported as failures. ### 1c. Census 2 — every authored icon STRING resolves as a key of the runtime `icons` record Every string in an icon-named position (`icon`, `iconName`, `...Icon` properties, JSX attributes, `resolveIcon(...)` arguments) across code, JSON, YAML and Markdown, tokenised with the seam's own rule copied verbatim (`split(/[-_\s]+/)`, capitalise, `Home` to `House`), judged against each version's record. | Reading | Result | |---|---| | sites / distinct names | 717 / 207 | | live on 1.43.0 | 641 | | live on 1.35.0 or 1.31.0 but **dead on 1.43.0** (what the bump breaks) | **0** outside this PR's own changeset prose, which names `trash-2` as the spelling it retired | | dead on all three versions | 75 sites, 40 distinct — pre-existing and untouched by the bump: the deliberate retired-spelling negatives (`edit`, `smile`, `filter`, `not-a-real-icon`, `definitely-not-a-lucide-icon`…) and strings that are not icon names at all (colour classes, labels) | | `pnpm check:icon-record-names` | `OK lucide icon names: 184 authored/declared names reaching 1 record-reading resolver are live icons keys (record 1818 keys ...)` | Controls: an injected `icon: 'trash'` reads live, injected `icon: 'trash-2'` in JSON and in TS both read as regressions. Independently, a case-insensitive `git grep` for every spelling that tokenises to `Trash2` finds only component imports of `Trash2` (still a runtime export in 1.43.0), comments, and one `vi.mock` stub key: no authored string. The same census over `main` finds exactly 6 string sites that tokenise to `Trash2` (5 `trash-2`, 1 `Trash2`, one per file); they are the ones the 2026-09-20 round repaired, and all 6 read `trash` here. **The glyph is unchanged by that repair**, measured on icon nodes: | Comparison | full node | node without `key` | |---|---|---| | 1.43.0 `trash` vs 1.31.0 `trash-2` | IDENTICAL | IDENTICAL | | 1.43.0 `trash` vs 1.35.0 `trash-2` | IDENTICAL | IDENTICAL | | control: 1.43.0 `pencil` vs 1.31.0 / 1.35.0 `pencil` | IDENTICAL | IDENTICAL | | control: 1.43.0 `trash` vs 1.35.0 `trash` | DIFFERENT | DIFFERENT | ⚠️ The last control row is also a user-visible fact: lucide moved the two-line bin artwork under the `trash` name, so anything that already authored `trash` (10 string sites on `main`) now draws what `trash-2` drew. Upstream also redrew other glyphs. Comparing the artwork each name draws on 1.35.0 against 1.43.0 (controls: `Trash2` reads unchanged, `Trash` reads changed), the ones this tree uses are the components `CheckCircle2` (29 importing files), `Table2` (8), `CircleDot` (5), `CircleCheck` (2), `Asterisk` (1) and `BadgeCheck` (1), and the strings `trash`, `shopping-cart`, `circle-check` / `CircleCheck` and `table-2`. Redraws, not breakage. ### 1d. Census 3 — every reader of `__iconNode` / `__iconData` works A `git grep` for `__iconNode|__iconData|createLucideIcon|LucideIconData` over the whole tree finds exactly **one reader**: the lazy draw in `packages/components/src/renderers/action/resolve-icon.ts`, which reads `module.__iconData?.node ?? module.__iconNode` (the 2026-09-20 repair). No other code reads an icon module's exports. Red, then green, on the lazy-draw row, predicted red before running, through `scripts/ablation-replace.mjs` from `../objectstack` (anchor must hit exactly once, write verified on disk, restore proven by blob hash and an empty `git diff HEAD`): ``` mutation const node = module.__iconData?.node ?? module.__iconNode; -> const node = module.__iconNode; ok mutation landed: anchor 1 -> 0, blob cc7d80e -> 271d15e3fa58 RED x fills the path data in once the icon module arrives AssertionError: expected 0 to be greater than 0 Tests 1 failed | 5 skipped (6) restore ok restored: blob == HEAD (cc7d80e) and `git diff HEAD` is empty GREEN Tests 1 passed | 5 skipped (6) (at 423a1a5) ``` **Real-build probe**, on the console built at `989330df0` (`apps/console/dist`), in Chromium: of 2345 built JS chunks, 1819 mention `__iconData` (the 1818 `vendor-icon-*` chunks plus the seam's `ui-components` chunk) and exactly 1 mentions `__iconNode`, the seam's fallback read; the built seam reads `__iconData?.node??n.__iconNode`. Four built icon chunks imported in the browser: | chunk | `__iconData.name` | aliases | path elements | first `d` | `__iconNode` | |---|---|---|---|---|---| | `vendor-icon-house-*` | `house` | `home` | 2 | `M15 21v-8a1 1 0 0 0-1-1h-4a1 1 0 0 0-1 1v8` | undefined | | `vendor-icon-trash-*` | `trash` | `trash-2` | 5 | `M10 11v6` | undefined | | `vendor-icon-arrow-down-0-1-*` | `arrow-down-0-1` | `arrow-down-01` | 5 | `m3 16 4 4 4-4` | undefined | | `vendor-icon-loader-circle-*` | `loader-circle` | `loader-2` | 1 | `M21 12a9 9 0 1 1-6.219-8.56` | undefined | So the shipped glyph data is non-empty and sits where the seam now reads it, and the pre-repair read would find nothing in the real build too. NOT MEASURED: a rendered page. With no backend the built console lands on `/login`, which draws no lucide svg at all (0 found), so there was no seam-drawn glyph on screen to count. ### 1e. Census 4 — every `lucide-NAME` class token in the tree, against the 1.43.0 alias index Every `lucide-` token in every tracked text file (lockfile and binaries excluded), classified against an alias index built from the 1818 installed icon modules (canonical `lucide-` plus the icon name; one alias class per declared alias), against what the seam emits (the key-derived class and the canonical class, rule copied verbatim from `lucideClassNames`), and against what 1.35.0 emitted. | Class of token | distinct | disposition | |---|---|---| | canonical class of a 1.43.0 icon | 29 | safe: lucide's component and the seam both emit it | | not an icon class (`lucide-icon`, script names such as `lucide-record-icon-names`) | 5 | out of scope | | **alias** class: `lucide-home` (of `house`) | 1 | the button pin — relaxed under ruling C, see section 2 | | **alias** class: `lucide-loader-2` (of `loader-circle`) | 1 | `svg-host-dom-leak-5632.test.tsx`, a spinner drawn by a component import, so lucide's own alias class IS on it; the exact assertion the 2026-09-20 round updated holds on 1.43.0 | | **alias** / retired: `lucide-trash-2`, `lucide-trash2` | 2 | prose only: the seam docblock and the pin comment (both rewritten in this round), and the pending objectui#9251 changeset (left alone; this PR's changeset dates its example) | | seam-key-only class (emitted by the seam, not by lucide 1.43.0) | **0** referenced | — | Controls: an injected `svg.lucide-trash-2` assertion is classified as an alias of `trash`; an injected `svg.lucide-check` reads canonical. Six dynamically built selectors (`svg.lucide-${name}` in the command and context-menu suites) iterate canonical names only. ### 1f. New since the 2026-09-20 round `main` moved 294 commits past the old merge base `078f2e4f7`. What the four censuses see that the `6f20cfb06` tree did not: | Census | new at this head | verdict on 1.43.0 | |---|---|---| | imports | 7 sites in 6 files; 4 files import lucide for the first time: `packages/app-shell/src/layout/ReadRateBanner.tsx` (`TriangleAlert`), `packages/app-shell/src/views/ActionParamDialog.tsx` (`ChevronDown`, `Lock`), `packages/plugin-detail/src/__tests__/detailSectionAuthoredIcon-9529.test.tsx` (`MapPin`), `packages/app-shell/src/hooks/__tests__/userLocale-10059.test.tsx` (a `vi.mock` of the package); plus `Code2` in `FlowKeyValueField.tsx` and `BookOpen` in `NavigationDesigner.tsx` | all resolve | | authored strings | 13 sites; new names `share`, `map-pin` | all live, except 2 `edit` sites in `menubar-item-icon.test.tsx`, which are deliberate retired-spelling negatives, dead on all three versions | | `__iconNode` / `__iconData` readers | none | — | | class tokens | 6 pairs, all in `packages/components/src/__tests__/menubar-item-icon.test.tsx`: `lucide-chevron-right`, `lucide-download`, `lucide-file`, `lucide-mail`, `lucide-save`, `lucide-share` | all canonical | None of them needed a repair. ### 1g. The merge and the lockfile `origin/main` **merged** at `21d34d5e2` (⛔ no rebase, no amend, no force-push): one conflict, `packages/plugin-kanban/package.json`, resolved as the union (main deleted `@tanstack/react-virtual` with the module that used it; this branch bumps `lucide-react`). `pnpm-lock.yaml` was regenerated by pnpm from main's own lockfile, ⛔ not hand-merged: main's file taken whole, then `pnpm install --lockfile-only` with the 22 manifests briefly at an exact `1.43.0` and again with `^1.43.0` restored, which pnpm keeps. A plain re-lock follows the caret to the newest 1.x (1.48.0 today). The delta against main is lucide alone: 22 importer specifiers, 22 resolutions and the fumadocs peer suffixes. All 22 manifests that declare `lucide-react` read `^1.43.0`. ## 2. Ruling C — the two pins, relaxed and no more ⚠️ **This weakens a gate that was telling the truth.** The two rows below were red because the seam genuinely stopped reproducing lucide's classes; they were not flakes. lucide-react 1.43.0 emits one class per DECLARED ALIAS (`house` renders `lucide-house lucide-home`) and no longer the class it derived from the PascalCase key. The alias list lives only inside each icon module, which objectui#9251 made lazy, while the seam must put its classes on the first frame. The maintainer chose C over A (put every alias into the eager, build-generated name list, spending bytes under objectui#9251's ruling) and over B (hold at 1.31.0), with the weakening stated when it was presented. ⇒ After this PR, a seam-drawn glyph missing lucide's alias classes, or carrying the key-derived class lucide no longer emits, passes these rows. ⛔ It is not free. **Re-measured size of what is given up** (1.43.0 facts, the seam's rule copied verbatim): of 1818 record keys, the seam's class set and lucide's **agree on 1494 and disagree on 324** (80 seam-only, 223 lucide-only, 21 both ways) — the same figures the 2026-09-20 round read. **Why the canonical form of C and not the subset form:** the seam's classes are a subset of lucide's for only 1717 of 1818 keys (the key-derived class is not one lucide 1.43.0 emits), so "the seam's classes need only be a subset" would still be red on 101 keys. The canonical class is on the seam for **1818 of 1818**. **Exactly two pins.** They are the two rows `Test (shard 3/4)` and `Test (shard 4/4)` reported red on `6f20cfb06`, read off those check runs' own annotations: - shard 3/4: `button-shared-icon-resolver.test.tsx` > `resolves home through the RENAME alias to House, not to a dead home` — `expected null to be SVGSVGElement`; - shard 4/4: `resolve-icon-lazy-9251.test.tsx` > `reproduces lucide's per-icon class names over the WHOLE record vocabulary` — `AArrowDown: expected "lucide lucide-a-arrow-down", got "lucide lucide-a-arrow-down lucide-aarrow-down"`, and nine more. Each now carries, at its site, what it used to refuse and why it no longer does. Verbatim below, with two deliberate substitutions: the generic in `Record OF string, React.ElementType` and the placeholder in `lucide-ICONNAME` are written in capitals instead of angle brackets, because GitHub deletes tag-shaped fragments from a body even inside a code fence. Byte-exact text: `git show 178da2e`. ### Pin 1 — `packages/components/src/renderers/action/__tests__/resolve-icon-lazy-9251.test.tsx` Before (`6f20cfb06`): ```ts it('reproduces lucide\'s per-icon class names over the WHOLE record vocabulary', () => { // ⚠️ The class names are the part a conversion rule gets wrong silently: 95 // of the record's keys pack digits that lucide splits in the module name and // not in the class derived from the key, so `Trash2` renders BOTH // `lucide-trash2` and `lucide-trash-2`. `createLucideIcon` is what builds // them and the seam no longer calls it, so every name is compared against // the record's own component here — not a sample, and not a copy of the // rule. const keys = Object.keys(icons); expect(keys.length).toBeGreaterThan(1000); const mismatches: string[] = []; let digitKeysChecked = 0; for (const key of keys) { if (/\d/.test(key)) digitKeysChecked += 1; const reference = renderIcon((icons as Record OF string, React.ElementType)[key], {}); const seam = renderIcon(resolveIcon(key)!, {}); const want = classesOf(reference).join(' '); const got = classesOf(seam).join(' '); if (want !== got) mismatches.push(`${key}: expected "${want}", got "${got}"`); } expect(mismatches.slice(0, 10)).toEqual([]); // Non-vacuity, both ways: the loop ran, and it ran over the class of name // this row exists for. expect(digitKeysChecked).toBeGreaterThan(50); }); ``` After: ```ts it('carries lucide\'s CANONICAL per-icon class over the WHOLE record vocabulary', () => { // ⚠️ RELAXED under the maintainer's ruling C on objectui#8941 (comment // 5750512894, verbatim 「8941 C」). This row USED TO REFUSE any seam glyph // whose complete class set differed from lucide's own component's. It NO // LONGER DOES, because lucide-react 1.43.0 emits one class per DECLARED // ALIAS (`house` renders `lucide-house lucide-home`) and no longer emits the // class it used to derive from the key, and the alias list exists only // inside each icon module — the modules objectui#9251 made lazy — while the // seam has to put its classes on the FIRST frame. The ruling chose the bump // over carrying every alias in the eager static name list (option A), and // it was taken knowing that it weakens this row. So a seam glyph missing // lucide's alias classes, or carrying the key-derived class lucide no longer // emits, now passes here. // // What it still refuses: a seam glyph without `lucide` or without lucide's // CANONICAL class, `lucide-ICONNAME`, which lucide emits first after the // bare `lucide`. That is the class a conversion rule gets wrong silently, // because many keys pack digits that lucide splits in the module name // (`ArrowDown01` is `lucide-arrow-down-0-1`, never `lucide-arrow-down01`). // Every name is still compared against the record's own component — not a // sample, and not a copy of the rule. const keys = Object.keys(icons); expect(keys.length).toBeGreaterThan(1000); const mismatches: string[] = []; let digitKeysChecked = 0; for (const key of keys) { if (/\d/.test(key)) digitKeysChecked += 1; const reference = renderIcon((icons as Record OF string, React.ElementType)[key], {}); const seam = renderIcon(resolveIcon(key)!, {}); // Read in lucide's own order: `lucide`, then the canonical class, then // one class per alias. Only the first two are required of the seam. const [base, canonical] = (reference?.getAttribute('class') ?? '').split(/\s+/).filter(Boolean); const got = classesOf(seam); if (base !== 'lucide' || !canonical?.startsWith('lucide-') || !got.includes(base) || !got.includes(canonical)) { mismatches.push(`${key}: expected "${base} ${canonical}" among "${got.join(' ')}"`); } } expect(mismatches.slice(0, 10)).toEqual([]); // Non-vacuity, both ways: the loop ran, and it ran over the class of name // this row exists for. expect(digitKeysChecked).toBeGreaterThan(50); }); ``` ### Pin 2 — `packages/components/src/renderers/form/__tests__/button-shared-icon-resolver.test.tsx` Before (`6f20cfb06`): ```ts it('resolves `home` through the RENAME alias to House, not to a dead `home`', () => { // The single entry both maps carried. It is the one input whose answer // would have changed had the dedupe dropped the alias on the floor. const button = renderButton({ icon: 'home' }); const house = button.querySelector('svg.lucide-house'); expect(house).not.toBeNull(); // The negative half used to read `querySelector('svg.lucide-home')` is // null. That form RETIRED on lucide-react 1.43.0, which reshaped // `createLucideIcon` to take an icon-data object carrying `aliases` and // to emit one class PER ALIAS: `house` now renders // `class="lucide lucide-house lucide-home ..."` itself, so the class no // longer says which glyph was drawn (measured: 248 of 1818 icon modules // carry aliases; 1.31.0 icon modules have no `aliases` field at all). // The discriminating form is below and still fires for the same defect: // `Home` is not a key of the runtime record, so had the rename been // dropped this button would render NO glyph at all, and any SECOND glyph // would be a different element from `house`. expect(button.querySelectorAll('svg')).toHaveLength(1); expect(button.querySelector('svg.lucide-home')).toBe(house); }); ``` After: ```ts it('resolves `home` through the RENAME alias to House, not to a dead `home`', () => { // The single entry both maps carried. It is the one input whose answer // would have changed had the dedupe dropped the alias on the floor. const button = renderButton({ icon: 'home' }); expect(button.querySelector('svg.lucide-house')).not.toBeNull(); // ⚠️ RELAXED under the maintainer's ruling C on objectui#8941 (comment // 5750512894, verbatim 「8941 C」). This row USED TO REFUSE a house glyph // that did not also carry lucide's `lucide-home` ALIAS class on the same // element: `querySelector('svg.lucide-home')` had to BE the house svg. It // NO LONGER DOES, because this button draws through the objectui#9251 // seam, which emits lucide's canonical class and not lucide-react // 1.43.0's per-alias classes, and the ruling accepted that rather than // put every icon's aliases into the eager static name list. // // ⛔ Nor does it go back to the older form, `svg.lucide-home` is null: // lucide 1.43.0 itself puts `lucide-home` on the house glyph, so that // class no longer says which glyph was drawn, and pinning its absence // would pin the seam's divergence from lucide. `lucide-home` is neither // required nor forbidden here. What still discriminates is the count: // `Home` is not a key of the runtime record, so had the rename been // dropped this button would render NO glyph at all. expect(button.querySelectorAll('svg')).toHaveLength(1); }); ``` (On `main` this row still reads `expect(button.querySelector('svg.lucide-home')).toBeNull();`, which is green under the seam on either version. ⛔ It is not restored: lucide 1.43.0 puts `lucide-home` on the house glyph itself, so pinning its absence would pin the seam's divergence from lucide, and the row's own comment now says so.) **Both relaxed rows can still fail, for what they still refuse.** Same tool and restore proof as 1d, each prediction written before its run: ``` PIN 1 mutation return [fromKey, `lucide-${kebab}`, className] -> return [fromKey, className] RED x carries lucide's CANONICAL per-icon class over the WHOLE record vocabulary "ArrowDown01: expected \"lucide lucide-arrow-down-0-1\" among \"lucide lucide-arrow-down01\"" (and 9 more) restore ok restored: blob == HEAD (99c47bc) and `git diff HEAD` is empty PIN 2 mutation delete the `Home: 'House',` rename entry RED x resolves `home` through the RENAME alias to House AssertionError: expected null not to be null restore ok restored: blob == HEAD (99c47bc) and `git diff HEAD` is empty ``` (The first attempt at the pin-2 mutation passed an empty replacement, which the tool refuses; no test ran on it. The run above used its delete mode.) **The seam's own docblock moved with the pins.** `lucideClassNames` claimed its classes were derived the way lucide derives them and that a pin caught either derivation drifting, under a test file name that does not exist. Neither survives this bump and this ruling, so it now says what the seam emits, what 1.43.0 emits instead, and which pin holds how much. Comment only; no code in `resolve-icon.ts` changed this round. **⛔ No third pin.** The full suite ran locally at `989330df0` in 16 shards (`pnpm exec vitest run --shard=K/16`, each under `../objectstack/scripts/pm/os-verify-lock.sh`): **3618 test files** (3612 passed, 6 skipped, **0 failed**), **48571 tests** (48527 passed, 44 skipped, **0 failed**). CI on the same head: all eight `Test (shard N/8)` and `Test (dist pins)` green. No other pin went red, for this reason or for any other, so there was nothing to stop and report. ## 3. Checks All at `989330df0`, the head of this branch; heavy runs serialized through `../objectstack/scripts/pm/os-verify-lock.sh`, every exit code captured before any pipe. | Check | Command | Reading | |---|---|---| | tests | 16 local shards, above | 3618 files, 48571 tests, 0 failed | | type-check | `pnpm turbo run type-check --concurrency=2` | `Tasks: 81 successful, 81 total`, 0 `error TS` | | type-check, root projects | `pnpm type-check:scripts`, `type-check:vitest-setup`, `type-check:vitest-config` | exit 0, 0 `error TS` each | | lint, whole repo | `pnpm turbo run lint --concurrency=2` | `Tasks: 47 successful, 47 total`, 0 errors in every task (warnings only). The three files changed this round, linted alone: 0 errors, 0 warnings | | build | `pnpm turbo run build --filter='./packages/*' --concurrency=2`, then `pnpm --filter @object-ui/console build` | 39 of 39; console exit 0 | | eager-closure budget | `node scripts/check-eager-closure-budget.mjs` | `Console eager closure is 3054.8 KB gzipped across 329 of 2345 chunks (budget: 3104.5 KB, headroom: 49.7 KB)`; `ui-components 266.5 KB / 282.2 KB`. ⛔ No ceiling or baseline moved: the script is byte-identical to main's | | locale catalogues, SDUI pins | `node scripts/check-eager-locale-catalogues.mjs`, `pnpm check:sdui-registration-pins` | exit 0 each | | dist | `pnpm test:dist`; `check-node-esm-load`, `check-published-dist-tooling`, `check-dist-completeness --all` | 9 of 9 tasks (components: 2 files, 8 tests); the three gates exit 0 | | icon names | `pnpm check:icon-record-names`; `node scripts/regenerate-lucide-record-icon-names.mjs --check` | OK (184 names, record 1818 keys); the generated table matches the installed manifest | | lockfile | `node scripts/check-lockfile-integrity.mjs --base` main's lockfile `--head pnpm-lock.yaml`, and the default invocation; `check-lockfile-dedupe` | `VERDICT clean — no @objectstack/* identity moved backward and no package gained a copy` (1773 resolutions on both sides); `VERDICT deduped` | | changesets | `check-changeset-presence`, `-no-major`, `-fixed`, `-overwrite`, `check-pending-changeset-literals` | exit 0 each; `check-changeset-claims` is report-only | | touched-path gates | `check-control-bytes`, `check-new-cross-file-line-citations` (0 new), `check-skills-paths`, `check-skill-examples` (after the build), `check-skill-eval-tokens`, `check-test-path-roots`, the three `check-vi-mock-*`, `check-doc-fence-languages`, `check-doc-example-ids`, `check-shell-escape-residue`, `check-action-ref-convention`, `check-phantom-dependencies`, `check-unused-dependencies` | exit 0 each | | governed | `node scripts/check-governed-queue-guard.mjs --test` over the 42 paths | `GOVERNED — 1 of 42` | | CI | the check runs on `989330df0`, read when this was written | 42 success, 3 skipped (`dependabot` and the two coverage lanes), 0 failed. The seat re-reads it | NOT MEASURED locally: `Build & E2E` and the live e2e lane (green on CI). ## 4. Changeset `.changeset/lucide-react-1-43-0-retired-trash2.md`, restated against today's tree. It declares, all `patch`, the 20 released packages whose `dependencies` range moves, `@object-ui/console` (its `devDependencies` range moves and its bundle ships the new icons), and `@object-ui/cli` and `@object-ui/types`, whose source changed. It names the invisible-glyph repair as a user-visible fix, says which classes component-imported and string-resolved icons carry now, and dates the `Trash2` class example in the pending objectui#9251 entry without editing that entry. Dropped from it: the claim that this bump collapses a double lucide install (main's #9316 dedupe already did). ## 5. Governed surface and skills readings The one governed path is the plugin skeleton's `lucide-react` range in `skills/objectui/guides/plugin-development.md`, anchored to the in-repo range by `doc-version-claims.test.ts`. Readings: that file 481 lines before and after; the published `skills/` tree 5365 lines before and after, its SKILL.md files 137 lines before and after. One line changed, zero added. ## 维护者速读(草稿) **改了什么** — 把全仓 22 个包声明的图标库 `lucide-react` 从 `^1.31.0` 升到 `^1.43.0`(实际安装版本从 1.35.0 升到 1.43.0),同时修掉升级带来的问题:懒加载图标的路径数据换了导出名(不修就是所有按名字解析的图标变成空框),以及一个被上游退役的图标名 `trash-2` 改成 `trash`(图形不变)。按您的裁决 C,放宽了两条测试钉子。 **为什么改** — 上游 1.43.0 改了图标数据结构,并且给每个图标加了「别名 class」。我们的懒加载图标拿不到别名(别名只在懒加载的图标模块里),两条如实报告这一差异的测试因此变红。您选了 C:接受这个差异,落地升级,而不是把别名塞进首屏必载的名单(A)或停在旧版本(B)。 **风险与代价(含回滚)** — 代价是明确的:两条原本「说真话」的钉子被削弱了,之后按名字解析的图标少了 lucide 的别名 class,钉子不再报警;按别名 class 写的样式只对直接 import 的图标组件生效。另有一些图标上游重画了(例如 `trash` 现在画的是原来 `trash-2` 的样子)。回滚:整体 revert 本 PR 即回到 `^1.31.0` 与旧钉子。 **席位意见** — 建议批准(席位复核于 2026-09-25T14:03Z,head `989330df0`)。放宽恰为两条钉子(`178da2eea`),各在原位写明原先拒什么、为何不再拒、仍拒什么,且各有一次预测后变红的证明;`resolve-icon.ts` 本轮只改注释;预算脚本与 main 字节一致,无上限或基线移动;22 个 manifest 均为 `^1.43.0`,lockfile 中 lucide 只有 1.43.0 一份;该 head 上 CI 42 成功、3 跳过、0 失败。本分支合并的 main 基点之后 main 又前进 27 个提交:与本分支 merge-tree 无冲突,其新增 11221 行中 lucide 提及与图标字符串均为 0(同一扫描在本 PR 的 diff 上分别命中 99 与 7);合并队列会在最新 main 上重跑全量。开发代理提出的 objectui#9251 变更集措辞问题,席位取 A:不改那条,本 PR 的变更集已写明其示例的日期。 **你要做的** — 本 PR 命中受管面(`skills/objectui/guides/plugin-development.md`),需要 `os-zhuang` 或 `hotlong` 留一条 APPROVED review;之后由认领席翻 ready 并入队。 ## Historical — measured on the 2026-09-10 and 2026-09-20 trees, ⛔ not re-derived here Kept as the record of how this PR got here. Superseded where this round measured differently: main's installed version was 1.35.0, not 1.31.0; "main installs two physical copies" stopped being true at #9316; the governed count now reads 1 of 42; the `Bundle Analysis` NOT MEASURED and the eslint narrowing below are replaced by section 3; two `path:line` citations below are re-spelled by content (AGENTS.md #11), with nothing else in them changed; and the class note in the old section 3 describes component-imported icons only (string-resolved icons go through the seam, section 2). Supersedes the stale Dependabot branch objectui#7058 (`dependabot/npm_and_yarn/lucide-react-1.35.0`). That branch is not pushed to here — Dependabot force-pushes over it on every rebase — so this is a fresh branch cut from current `main`. Once this lands, objectui#7058 can be closed as superseded. It is deliberately not named with a closing keyword above; closing it is a maintainer action, not this PR's. ### 1. Which of the seven red checks were staleness, and which were real objectui#7058's base is `4e3a4f07e` — weeks behind `main`. I brought its head up to date in a throwaway worktree, re-locked from current `main`, and re-measured. Four of the seven were artefacts of the stale base; three were real. | Check on objectui#7058 | Verdict | Evidence | |---|---|---| | `Type Check` | **REAL** | The job failed at `pnpm check:icon-record-names`, not at `tsc`. `tsc` never ran. | | `Test (shard 1/4)` | **REAL** | `packages/cli/src/__tests__/app-generator.test.ts` — the generator's literal `lucide-react` range stayed at `^1.31.0` while the 22 sibling manifests moved. | | `Test (shard 3/4)` | **MIXED** | `check-lucide-icon-record-names.test.ts` REAL (same four sites). `ci-cd-pipeline-doc.test.ts` STALE — the lockfile carried two `@objectstack/spec` versions. | | `Test (shard 4/4)` | **MIXED** | `doc-version-claims.test.ts` REAL (`skills/objectui/guides/plugin-development.md` still taught `^1.31.0`). `check-lockfile-integrity.test.ts` STALE — its fixture forks a `zod@4.4.3` key the stale lockfile had replaced with `4.5.4`. | | `Lockfile Integrity Check` | **STALE** | `VERDICT 12 finding(s): 7 backward move(s), 5 duplication(s)` — Dependabot re-locked on an old base and dragged `@objectstack/client`, `core`, `formula`, `lint`, `sdui-parser`, `types` from 17.4.0 back to 17.3.0, plus a `zod` 4.4.3/4.5.4 split. | | `Bundle Analysis` | **STALE** | `vendor-objectstack 2874.0 KB / 1224.6 KB ceiling (OVER by 1649.3 KB)` — that is the duplicated `@objectstack` tree above, which the lockfile gate itself names as the cause: *"a bundle-size red downstream of this is caused by THIS, not by the dependency being bumped."* | | `dependabot` | STALE | Dependabot's own branch check. | On this branch, re-locked from current `main`, `node scripts/check-lockfile-integrity.mjs` reports `VERDICT clean — no @objectstack/* identity moved backward and no package gained a copy`. ### 2. Root cause of what survives — measured against the installed artifact The hypothesis in the dispatch was a broad source-compatibility break. **The measurement narrows it to a single retired name, and falsifies the type-checking half entirely.** I installed 1.31.0, 1.41.0 and 1.43.0 side by side and diffed three surfaces: | Surface | 1.31.0 | 1.43.0 | Removed | |---|---|---|---| | runtime exports of `lucide-react` | 6068 | 6224 | **0** | | public names in `lucide-react.d.ts` | 6072 | 6230 | **0** | | `iconNames` from `lucide-react/dynamic.mjs` | 2025 | 2077 | **0** | | keys of the runtime `icons` record | 1767 | 1818 | **1 — `Trash2`** | Then I enumerated what this repository actually imports — 4700 source files, 333 distinct value names, one type name (`LucideIcon`), six namespace or default imports — and checked every one against both artefacts. **Zero fail to resolve, in either version.** Controls fired on the same run in both worlds: `Trash` resolves in both, a fabricated name resolves in neither. So nothing breaks at an import and nothing breaks in the compiler. `Trash2` is still exported by 1.43.0; it is simply no longer a *key of the runtime `icons` record*, and `Trash2 === Trash` there (in 1.31.0 they were distinct objects). That is exactly the class `scripts/check-lucide-icon-record-names.mjs` exists to catch: a retired spelling still imports, still type-checks, still renders as a COMPONENT, and resolves to nothing as a STRING. Four authored sites resolve `trash-2` through `renderers/action/resolve-icon.ts`, which reads record membership: - `examples/schema-catalog/src/schemas/actions/action-button-variants.json` - `examples/schema-catalog/src/schemas/actions/confirmation-dialog.json` - `examples/schema-catalog/src/schemas/components-layout-card/profile-detail-card.json` - `packages/plugin-detail/src/DetailView.tsx` — the record delete action All four now write `trash`. **The glyph does not change:** 1.43.0's `trash` icon node is byte-identical to 1.31.0's `trash-2` icon node (control: `pencil` is byte-identical across both versions, so the comparison is not returning equal for everything). Upstream replaced the old bin artwork under the `trash` name and kept `trash-2` as a deprecated alias. ### 3. Why 1.43.0 and not the 1.41.0 the Dependabot PR advertises The workspace declares a caret range, so a re-lock from current `main` resolves the newest 1.x — that is 1.43.0 today, under `^1.41.0` just as much as under `^1.43.0`. Holding exactly 1.41.0 would need an exact pin or an override, which is not this repo's convention and not mine to invent. Measured, the extra two minors cost nothing in removals: **1.41.0 to 1.43.0 removes zero exports, zero record keys and zero dynamic names.** It does bring one behavioural change that 1.41.0 does not have, and it is worth a maintainer's eye: **1.43.0 reshaped `createLucideIcon`** to take an icon-data object carrying `aliases`, and it now emits **one CSS class per retired alias**. A spinner renders `class="lucide lucide-loader-circle lucide-loader-2 ..."`. Measured: 248 of 1818 icon modules carry an alias; 1.31.0 icon modules have no `aliases` field at all. This is additive, so a `.lucide-loader-circle` selector still matches — but a selector asserting the exact, complete class string does not, and neither does an assertion that a given `lucide-` class is ABSENT. I censused the whole tree for both shapes, using the alias index built from the installed artefact as the oracle: **28 distinct `lucide-` class names are referenced anywhere in the repository** (all file types, snapshots included) and **exactly two are aliases in 1.43.0** — `lucide-home` (owned by `house`) and `lucide-loader-2` (owned by `loader-circle`). Controls: injecting the known alias `trash-2` into the census is found; `check` is correctly absent. Both affected pins are repaired here: - `examples/schema-catalog/test/svg-host-dom-leak-5632.test.tsx` asserts the exact attribute set. The added class is named. The assertion stays **exact** on purpose — that list is what catches an authored prop reaching the DOM, which is the whole point of objectui#5632. - `packages/components/src/renderers/form/__tests__/button-shared-icon-resolver.test.tsx` proved `home` resolved through the rename to `House` by asserting `svg.lucide-home` is null. `house` now emits `lucide-home` itself, so that class no longer says which glyph was drawn. Replaced with a form that still fires for the same defect: exactly one svg, and the alias class on that same element. Had the rename been dropped, `Home` is not a record key and the button would render no glyph at all. ### 4. Something the bump gives back `main` installs **two** physical copies of the icon library: 1.31.0 for this workspace and 1.35.0 pulled by `fumadocs-ui`. On this branch both collapse onto a single 1.43.0. Lockfile resolutions go 1822 to 1821. ### 5. What was measured here - `pnpm check:icon-record-names` — `OK ... 184 authored/declared names reaching 1 record-reading resolver are live icons keys (record 1818 keys)`. - Reverse verification, direction predicted before running: restoring `trash-2` in `DetailView.tsx`'s `sys_delete` action turns that gate red naming **exactly that one site** and nothing else; restoring the file returns it to green. Restoration proved by blob hash equality with HEAD and an empty `git diff HEAD`, not by an exit code. - `pnpm type-check` across the workspace — turbo `81 successful, 81 total` over 45 packages, zero `error TS`. - `pnpm exec vitest run packages/components/ examples/schema-catalog/ packages/plugin-view/ packages/plugin-list/` — `Test Files 395 passed (395)`, `Tests 5688 passed (5688)`. - `pnpm exec vitest run packages/plugin-detail/ packages/types/ examples/schema-catalog/` — 350 files, 6769 tests, green after the pin repair. - `pnpm exec vitest run packages/cli/src/__tests__/app-generator.test.ts` — 43 passed. - `pnpm exec vitest run scripts/__tests__/doc-version-claims.test.ts` — 29 passed. - `pnpm exec vitest run scripts/__tests__/check-lucide-icon-record-names.test.ts scripts/__tests__/ci-cd-pipeline-doc.test.ts scripts/__tests__/check-lockfile-integrity.test.ts` — green. - `node scripts/check-lockfile-integrity.mjs` — `VERDICT clean`. - `node scripts/check-changeset-presence.mjs` and `check-changeset-no-major.mjs` — both green. Declared narrowing: the full four-shard `pnpm test` and the repo-wide `pnpm lint` are left to CI. `eslint` over the changed source files reports one pre-existing error in `action-bar.tsx` (`react-hooks/static-components`) in code this PR does not touch (its only change to that file is a docblock comment); that attribution is stated, not yet controlled against `main`. The `Bundle Analysis` measurement was still building locally when this was opened and is reported as NOT MEASURED rather than assumed — the stale-base cause of its red is independently established above. ### 6. Governed surface — this PR stays a draft `node scripts/check-governed-queue-guard.mjs --test` reports `GOVERNED — 1 of 37 path(s)`: `skills/objectui/guides/plugin-development.md`, the published skills catalog. One governed path governs the whole PR. It is **not** to be flipped ready, enqueued, or armed with auto-merge; a human merge is the review record. The changed line there is the plugin skeleton's `lucide-react` range, which `doc-version-claims.test.ts` anchors to the in-repo range. Its `KNOWN_CLAIMS` entry is keyed by the literal text, so the inventory key moved with it. --- _Generated by [Claude Code](https://claude.ai/code)_ --------- Co-authored-by: Claude <support@objectstack.ai> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Jack Zhuang <50353452+hotlong@users.noreply.github.com>
1 parent dac022c commit fb336df

42 files changed

Lines changed: 286 additions & 138 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,61 @@
1+
---
2+
'@object-ui/app-shell': patch
3+
'@object-ui/cli': patch
4+
'@object-ui/components': patch
5+
'@object-ui/console': patch
6+
'@object-ui/fields': patch
7+
'@object-ui/layout': patch
8+
'@object-ui/plugin-ai': patch
9+
'@object-ui/plugin-calendar': patch
10+
'@object-ui/plugin-charts': patch
11+
'@object-ui/plugin-chatbot': patch
12+
'@object-ui/plugin-dashboard': patch
13+
'@object-ui/plugin-designer': patch
14+
'@object-ui/plugin-detail': patch
15+
'@object-ui/plugin-form': patch
16+
'@object-ui/plugin-gantt': patch
17+
'@object-ui/plugin-grid': patch
18+
'@object-ui/plugin-kanban': patch
19+
'@object-ui/plugin-list': patch
20+
'@object-ui/plugin-report': patch
21+
'@object-ui/plugin-tree': patch
22+
'@object-ui/plugin-view': patch
23+
'@object-ui/runner': patch
24+
'@object-ui/types': patch
25+
---
26+
27+
Move `lucide-react` from `^1.31.0` to `^1.43.0` in every package that declares it, and
28+
repair what the jump breaks, so icons resolved from a STRING keep drawing a glyph.
29+
30+
Measured once against the installed 1.43.0 artifact when this change was made; nothing in
31+
the repository re-derives these readings. Across the jump lucide removes no runtime export,
32+
no public type name and no `lucide-react/dynamic.mjs` name, and every name this repository
33+
imports from `lucide-react` resolves. Exactly one key leaves the runtime `icons` record:
34+
`Trash2`, retired in favour of `trash`.
35+
36+
What a user sees change:
37+
38+
- Icons the lazy icon seam draws (`resolveIcon`, objectui#9251) get their path data again.
39+
lucide 1.43.0 icon modules export their path data inside `__iconData` and no longer
40+
export `__iconNode`; the seam now reads both. Reading only `__iconNode` against 1.43.0
41+
leaves every such glyph an empty box, with nothing thrown or logged.
42+
- `DetailView`'s delete action and three schema-catalog examples spell their icon
43+
`trash`, not `trash-2`, so they keep resolving. The glyph is unchanged: 1.43.0's `trash`
44+
path data is byte-identical to the `trash-2` path data of 1.31.0 and 1.35.0. Anything
45+
that already authored `trash` now draws that same artwork, because lucide moved it under
46+
the `trash` name; a few other glyphs were also redrawn upstream.
47+
- Icons imported as COMPONENTS carry lucide 1.43.0's own classes: one class per declared
48+
alias (a spinner renders `class="lucide lucide-loader-circle lucide-loader-2 ..."`), and
49+
no longer the class lucide used to derive from the PascalCase key where that differs
50+
(`ArrowDown01` no longer carries `lucide-arrow-down01`). The canonical
51+
`lucide-<icon name>` class is still there, so a `.lucide-loader-circle` selector still
52+
matches.
53+
- Icons resolved from a STRING through the seam keep the classes they had: `lucide`, the
54+
canonical `lucide-<icon name>` class and the key-derived class. They do not carry
55+
lucide's per-alias classes. That is a maintainer ruling (objectui#8941, option C): the
56+
alias list lives only inside each lazily loaded icon module, and it was not moved into
57+
the eager name list. A selector that targets an alias class matches a component-imported
58+
icon and not a string-resolved one. This also dates the example in the objectui#9251
59+
entry: `trash-2` no longer resolves as a string, so no seam-drawn glyph carries
60+
`lucide-trash2 lucide-trash-2`; a digit-bearing name that still resolves, such as
61+
`arrow-down-0-1`, carries `lucide-arrow-down01 lucide-arrow-down-0-1`.

‎apps/console/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@
105105
"@vitest/ui": "^4.1.10",
106106
"autoprefixer": "^10.5.4",
107107
"happy-dom": "^20.11.2",
108-
"lucide-react": "^1.31.0",
108+
"lucide-react": "^1.43.0",
109109
"postcss": "^8.5.26",
110110
"react": "19.2.8",
111111
"react-dom": "19.2.8",

‎apps/site/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
"fumadocs-core": "16.15.4",
3737
"fumadocs-mdx": "15.2.3",
3838
"fumadocs-ui": "16.15.4",
39-
"lucide-react": "^1.31.0",
39+
"lucide-react": "^1.43.0",
4040
"next": "16.3.3",
4141
"react": "19.2.8",
4242
"react-dom": "19.2.8",

‎content/docs/api/schema-reference.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,7 @@ A single-record detail view with grouped fields, actions, and tabs.
687687
],
688688
"actions": [
689689
{ "type": "action", "label": "Edit", "icon": "Pencil", "level": "primary" },
690-
{ "type": "action", "label": "Delete", "icon": "Trash2", "level": "danger", "actionType": "confirm" }
690+
{ "type": "action", "label": "Delete", "icon": "trash", "level": "danger", "actionType": "confirm" }
691691
],
692692
"tabs": [
693693
{

‎content/docs/guide/schema-playground.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ A data grid with sortable columns and row actions:
190190
],
191191
"actions": [
192192
{ "label": "Edit", "icon": "pencil", "action": "edit" },
193-
{ "label": "Delete", "icon": "trash-2", "action": "delete", "variant": "destructive" }
193+
{ "label": "Delete", "icon": "trash", "action": "delete", "variant": "destructive" }
194194
],
195195
"pagination": {
196196
"pageSize": 10,

‎examples/schema-catalog/src/schemas/actions/action-button-variants.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"type": "button",
2424
"label": "Delete",
2525
"variant": "destructive",
26-
"icon": "trash-2"
26+
"icon": "trash"
2727
},
2828
{
2929
"type": "button",

‎examples/schema-catalog/src/schemas/actions/confirmation-dialog.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"type": "button",
3636
"label": "Yes, Delete",
3737
"variant": "destructive",
38-
"icon": "trash-2"
38+
"icon": "trash"
3939
}
4040
]
4141
}

‎examples/schema-catalog/src/schemas/components-layout-card/profile-detail-card.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@
124124
"label": "Delete",
125125
"variant": "destructive",
126126
"size": "sm",
127-
"icon": "trash-2"
127+
"icon": "trash"
128128
}
129129
]
130130
}

‎examples/schema-catalog/test/svg-host-dom-leak-5632.test.tsx‎

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -314,13 +314,23 @@ describe('schema-catalog — no SVG-hosted renderer leaks an authored prop to th
314314
// `SpinnerSchema.size` is an ENUM consumed through `sizeClasses`. Spreading
315315
// it handed the string to lucide's numeric `size` prop, which is how
316316
// `width="lg" height="lg"` reached every sized spinner in the catalog.
317-
// `class` carries lucide's own two classes AND both of this renderer's —
317+
// `class` carries lucide's own classes AND both of this renderer's —
318318
// `animate-spin` and the size class. Before this slice it carried ONLY
319319
// lucide's: the spread's `className` overrode the computed one, so a
320320
// `ui:spinner` rendered through `SchemaRenderer` did not spin.
321+
//
322+
// `lucide-loader-2` is lucide's own RETIRED-ALIAS class, not a leak. It
323+
// appeared when `createLucideIcon` was reshaped to take an icon-data object
324+
// carrying `aliases` (lucide-react 1.43.0; absent in 1.31.0, where icon
325+
// modules have no `aliases` field at all) and it now emits one class per
326+
// alias. Measured on the installed artifact: 248 of 1818 icon modules carry
327+
// aliases, so any icon with one gains a class here. The assertion stays
328+
// EXACT on purpose — this list is what catches an authored prop reaching
329+
// the DOM, which is the whole point of objectui#5632; loosening it to a
330+
// substring match would retire the check rather than update it.
321331
expect(attributesOf({ type: 'spinner', size: 'lg' })).toEqual([
322332
'aria-hidden="true"',
323-
'class="lucide lucide-loader-circle animate-spin h-8 w-8"',
333+
'class="lucide lucide-loader-circle lucide-loader-2 animate-spin h-8 w-8"',
324334
'data-obj-type="spinner"',
325335
'fill="none"',
326336
'height="24"',

‎packages/app-shell/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
"@objectstack/spec": "^17.3.0",
8787
"@sentry/react": "^10.70.0",
8888
"jsonc-parser": "^3.3.1",
89-
"lucide-react": "^1.31.0",
89+
"lucide-react": "^1.43.0",
9090
"qrcode": "^1.5.4",
9191
"sonner": "^2.0.8",
9292
"zod": "^4.4.3"

0 commit comments

Comments
 (0)