This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Commit fffa30d
fix(data-objectstack): a refused view read is not an object with no saved views (#8901)
* feat(data-objectstack): discriminate a refused view read from an object with no saved views
`ObjectStackAdapter.listViews` degraded every failure to an empty list, so a
refused (401/403) or broken (5xx, dropped connection) `view` read returned the
identical value as a list the server served empty — and every consumer reads
only the return. That is the swallow objectui#7741 removed from
`listImportMappings` one method over; here it renders as an object's view
switcher showing no saved views at all, including ones the user created.
The degrade stays. What is added is the discrimination, read from `err` itself
rather than from the emptiness of the result:
- `classifyViewsFailure(err)` — a separate reading, not a second caller of
`classifyImportMappingsFailure`. `view` is in the platform's static spelling
contract, so the metadata list door's 400 `INVALID_REQUEST` ("this deployment
carries no such kind") is unreachable for it; carrying that quiet arm over
would swallow a real refusal. Only a host with no `/meta` door stays quiet.
- `MetadataReadWarningEvent.operation` / `.kind` gain their second members —
the additive, reviewed widening the single-member unions were built for.
- `MetadataReadFailureKind`, with `ImportMappingsFailureKind` now its alias.
- `metadataReadWarningToast` picks title and remedy by `operation`, so a views
failure no longer renders the import-mapping sentence. Three new
`console.savedViews*` keys in all ten locale packs.
Refs objectui#8151.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01611D6ZaRaMmwTNQmSbk8MH
* fix(scripts): re-derive the UNGATED_EXAMPLES key this branch's line insert moved
`scripts/check-doc-example-types.mjs`'s ledger is keyed by `path:line symbol`.
This branch inserts +262/-23 lines into `packages/data-objectstack/src/index.ts`,
which pushed `createObjectStackAdapter`'s `@example` block down, so the stored
key stopped resolving and `scripts/__tests__/check-doc-example-types.test.ts`
went red on "every row names a block that is actually in the compiled tier".
The key was located by FILE + SYMBOL and its new value re-derived from the
checker's own extractor — `ledgerKey(block)` over `exampleCensus()` — never
from a line number read off a report. Ledger row count 90 -> 90, zero
executable change.
Re-measured on this branch: exactly one ledger row names a file this branch
touches; `metadataReadWarningToast.ts` and the ten locale packs have none.
The tree-wide census has no discriminating power over this class: it reads
prose citations, and this is a stored literal used as a key. The test that
separates them is stored-vs-computed — a `path:line` assembled at runtime to
print a diagnostic cannot go stale, one persisted and compared for equality can.
Refs objectui#8151.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01611D6ZaRaMmwTNQmSbk8MH
* fix(scripts): re-baseline the `i18n-locales` per-chunk ceiling onto both admitted claimants
`PER_CHUNK_GZIP_CEILINGS['i18n-locales']` 455,000 -> 465,000 and
`PER_CHUNK_BASELINE['i18n-locales']` 446,076 -> 456,196, moved together in one
commit as that file requires. The ten locale packs' citation of the retired
headroom is updated in the same change so it cannot go stale again: it now
names no figure at all, which is the form the file's own anti-drift rule allows.
Four console builds, one container, one instrument -- `i18n-locales` read out of
the `apps/console/dist/eager-closure.json` each build writes:
bbe285e main 454,602 (headroom 398)
3949cf3 main + objectui#8901 455,271 +669, over by 271
ea5eab7 main + objectui#8888 455,519 +917, over by 519
ba20b0bc0 main + BOTH 456,196 +1,594, over by 1,196
The two deltas sum to 1,586 against a measured 1,594: two independent claimants
on this chunk are additive to within 8 bytes, which is the fact a shared budget
needs and the one a per-pull-request reading cannot produce.
Sized at 8,804 bytes of headroom = 0.10x REGRESSION_THIS_GATE_MUST_CATCH_BYTES,
this key's own convention and marginally tighter than the 8,924 (0.10x) the
retired pair carried. NOT sized at the 804 bytes the overage needed: a line with
~0 headroom is what objectui#8816 was filed about -- it reddens whichever
in-flight pull request is weighed second and blames that diff for arithmetic
that is not its own.
Trimming was measured first and cannot reach 1,196 bytes inside these changes:
best key reuse is 128 bytes for objectui#8888 and there is no reuse candidate at
all for objectui#8901. The payload reduction that would make the next raise
unnecessary is real but is not this: `check:i18n-dead-keys` reports 127 confirmed
dead keys in ten packs, and `@object-ui/i18n` publishes them, so removing one is
a published-surface decision that needs its own card.
Nothing else moved: not REGRESSION_THIS_GATE_MUST_CATCH_BYTES, not the other
three per-chunk ceilings, not MAX_EAGER_CLOSURE_GZIP_BYTES (the aggregate holds
23,507 bytes of headroom, 0.26x, with both claimants on it).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01611D6ZaRaMmwTNQmSbk8MH
---------
Co-authored-by: os-zhuang <support@objectstack.ai>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>1 parent 0073423 commit fffa30d
17 files changed
Lines changed: 1102 additions & 94 deletions
File tree
- .changeset
- packages
- app-shell/src/providers
- data-objectstack/src
- i18n/src/locales
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
31 | 41 | | |
32 | 42 | | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
38 | 50 | | |
39 | 51 | | |
40 | 52 | | |
| |||
103 | 115 | | |
104 | 116 | | |
105 | 117 | | |
106 | | - | |
| 118 | + | |
| 119 | + | |
107 | 120 | | |
108 | 121 | | |
109 | 122 | | |
| |||
117 | 130 | | |
118 | 131 | | |
119 | 132 | | |
120 | | - | |
121 | | - | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
122 | 138 | | |
123 | 139 | | |
124 | 140 | | |
| |||
130 | 146 | | |
131 | 147 | | |
132 | 148 | | |
133 | | - | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
134 | 184 | | |
135 | 185 | | |
136 | 186 | | |
137 | 187 | | |
138 | 188 | | |
139 | 189 | | |
140 | 190 | | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
141 | 252 | | |
142 | 253 | | |
143 | 254 | | |
| |||
160 | 271 | | |
161 | 272 | | |
162 | 273 | | |
163 | | - | |
| 274 | + | |
| 275 | + | |
164 | 276 | | |
165 | 277 | | |
166 | 278 | | |
167 | 279 | | |
168 | 280 | | |
169 | 281 | | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | 282 | | |
175 | | - | |
| 283 | + | |
176 | 284 | | |
177 | 285 | | |
178 | 286 | | |
| |||
0 commit comments