Repository navigation
a11y: 25 icon-only buttons have no accessible name and 24 clickable div/span elements have no role or keyboard handler; axe runs in 6 of 4,004 DOM tests and 0 e2e specs #13461
Description
Filing gate ③: a maintainer-directed task. Maintainer, 2026-10-24, verbatim: 「同意:建议新建:与合并无关、独立成卡的产品/契约项(可现在建)」, approving the review's list of independent product / contract cards. Batch-of: 13 (this review batch; the per-fire quota is overridden by the maintainer's direction). Also filing gate ①: reach: the controls named below are rendered in the console shell (AppHeader, ChatDock, AiChatPage, InvitationsPage, ApprovalsInboxPage, MarketplaceRowActions) and are unreachable or unnamed for screen-reader and keyboard users.
维护者速读
82 个图标按钮里 25 个没有可访问名称(app-shell 11、components 9、fields 3、chatbot 2);24 个 div/span onClick 没有 role / tabIndex / 键盘处理(app-shell 17)。img 的 alt 23/23 健康。没有 jsx-a11y lint;vitest-axe 只在 6/4,004 个 DOM 测试里,34 个 e2e spec 里 0 次 axe。objectui#12143 关闭时明确把「图标按钮普查」留成一个独立家族,但没人立。建议用 ariaLabelLiteralCensus-12145 同形的只减不增 ratchet 处理,不上全仓 jsx-a11y。
Measured (2026-10-24, HEAD 7981384; script a11y.mjs in the review scratchpad)
- Icon-only
Buttonelements withsize="icon": 82; 57 carryaria-label,titleor sr-only text; 25 do not — e.g.packages/app-shell/src/console/ai/AiChatPage.tsx,packages/app-shell/src/console/organizations/manage/InvitationsPage.tsx(two),packages/app-shell/src/layout/AppHeader.tsx,packages/app-shell/src/layout/ChatDock.tsx(two). divorspanwithonClickand norole,tabIndexor key handler: 24 — e.g.apps/console/src/pages/system/ApprovalsInboxPage.tsx(two),packages/app-shell/src/console/marketplace/MarketplaceRowActions.tsx,packages/app-shell/src/console/organizations/OrganizationsPage.tsx,packages/app-shell/src/views/metadata-admin/previews/AppPreview.tsx.imgwithoutalt: 0 of 23 (positive control: 23imgfound).tabIndex={-1}12,autoFocus35.role="alert"68 andaria-live18 against 372text-destructiveerror-text sites (announcement gap, tracked with the error-state card).- Lint: no a11y plugin in
eslint.config.js(positive control: 11 customobject-ui/*rules registered). Tests:vitest-axe/axe-corein 6 test files of 4,004.test.tsx; e2e: 0 axe runs in 34 specs. - Focus management is healthy: the radix focus-scope patch is documented with a regression test.
- Business reason: a keyboard or screen-reader user in the console cannot name or reach these 49 controls; NORTH-STAR "看着不对与渲染不出同样是缺陷".
- Dedup (
icon-only|aria-label|clickable div|role="button"): 81 hits, 0 open; the nearest closed are objectui#12143 (left the icon-only census as a separate family), Studio: controls without an accessible name (records toolbar, flow nodes, sheets, landing cards) #12510, record page header ⋯ menu: the system entries (Edit, favorites, Share, Delete) carry no icons beside the app's iconed actions, and Edit has no header control when the row is full — icons on every entry, Delete last, an Edit icon button beside the ⋯ #12529, finding(i18n, a11y): 31 shipped aria-label attributes are literal English, so a non-English screen reader hears English names (the family's closing card) #12145, Record pages in Setup (Organization, the permission-set page) carry two nested <main> landmarks, so screen readers announce two main regions — keep one (hotcrm#2194 T2-U23) #13334, a11y (axe wcag2a/aa): unnamed buttons and broken tab roles in the view tab bar, unbound labels on the settings form, and unnamed percent progress bars #11690.
Task
- A ratchet census test for unnamed icon-only buttons in the ordinary suite, same shape as
ariaLabelLiteralCensus-12145(allowlist = today's 25, deletions only), then burn the list down. - Replace the 24 clickable div/span with
buttonelements (orrole="button"plusonKeyDown). - 未实测 and optional: one per-route axe pass in
e2e/console-rendering.spec.tswith@axe-core/playwrightto learn the real violation count; do not addeslint-plugin-jsx-a11yrepo-wide before the two items above land.
Who acts: objectui domain:ui seat. Effort S for the first two items.
Filed by the read-only whole-repo review session https://claude.ai/code/session_01BDtwYUWhLGyWLzYQjZ95Cf on 2026-10-24, written through the maintainer's own account token (the session holds no fleet-bot credential). Evidence files: that session's scratchpad (objectui-review-report.md, findings-*.md). ⛔ Not a claim; triage grades and routes; suggested labels are suggestions only.
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 24, 2026
Triage: first grade —
a11y·priority:p2·domain:ui·area:records·pm:queue· triage seat ·session_01AavokzJ5DndAwitDXvKy4U· 2026-10-24T17:04Z⛔ Not a claim, ⛔ not a dispatch.
findingcomes off.tabIndex/ key handlers for the 24 clickablediv/span, with tests on the named controls.Generated by Claude Code
objectstack-fleet commentedon Oct 25, 2026
Claim: PM loop round 1 · 2026-10-25T02:02Z
Session:
session_018qafSnDdNuQgZGfnFwDajn(the card session that works this card; claim written by thedomain:uiseat 4 sessionsession_01XWGTsmqrtrt1Zqh1ioWqsT)Account:
os-elon-muskBranch:
claude/project-thread-byazyd(platform-assigned at spawn; the card session can push only this branch)Worktree:
objectui-issue-13461Domain:
domain:uiSeat:
domain:ui#4File surface: the files carrying the card's unnamed icon-only
Button size="icon"and handler-only clickablediv/span(underpackages/app-shell/src/**,packages/components/src/**,packages/fields/src/**, the chatbot package,apps/console/src/pages/**), edited only at those controls; one ratchet census test besideariaLabelLiteralCensus-12145; the i18n keys the new names need (EN + ZH, where the file already translates); their tests;.changeset/13461-*.md(stop on breach; explain in the report)Container & model:
M,mode:thread,model: default tier (dispatch-gates --tier --repo objectstack-ai/objectui: no path-derived mandate),effort: highClause-②: no
Metadata-protocol: none
Responsibility:
objectui console controls with no accessible name or keyboard path | the existing aria-label census pattern (ariaLabelLiteralCensus-12145) | every keyboard and screen-reader user of the consoleThread-read: 6387068230
Premise: holds — on objectui
mainc85408fthe card's census (25 + 24) is a script count; the card session re-measures it at its start and works from its own listSerial constraints cleared: seat 4's PR #13487 edits
packages/app-shell/src/layout/AppHeader.tsx(report crumb) and is armed for merge — mergemainbefore opening and again before landing; seat 4's objectui#13460 card (console pages i18n) may touch the sameapps/consolepages — ordinary concurrency, a shared file is resolved by whichever lands second; seat 1's objectui#13442 / #13449 / #13450 (components/src/renderers/basic/**for #13449) — if a control sits in that folder, leave it and list it in the reportWrites: all PR, comment and label writes go only through objectstack's relay (
scripts/pm/fleet-write); never write with GitHub MCP.6387068230: names for the icon-only buttons, role /tabIndex/ key handlers (or a realbutton) for the clickablediv/span, tests on the named controls.eslint-plugin-jsx-a11yrepo-wide. The card's optional per-route axe pass is not in this PR.divwhoseonClickonly stops propagation (e.g.MarketplaceRowActions.tsx:129, a wrapper round real buttons) is not a control — do not give itrole="button"; list such sites in the census allowlist with the reason. Prefer a real<button type="button">overrole="button"+onKeyDown.ariaLabelLiteralCensus-12145; it runs in the ordinary suite, not as a new required context.objectstack-fleet commentedon Oct 25, 2026
os-dev-report
{ "issue": 13461, "status": "done", "branch": "claude/project-thread-byazyd", "pr": "https://github.com/objectstack-ai/objectui/pull/13494", "session": "session_018qafSnDdNuQgZGfnFwDajn", "premise_still_valid": true, "summary": "Re-measured on the AST at c85408f: the card's 25 / 24 were a line-window script reading (several cited buttons already carry aria-label a few lines below the tag), and the icon-only ratchet the card asks for already exists as iconOnlyButtonCensus-12143. Named every 12143 BACKLOG site inside the claim's surface (16 sites, 12 files) plus the top bar avatar button, with pack keys in all ten packs (designer-table keys in en + zh). Repaired the console's clickable div/span controls: organization card Manage is now a sibling button, flow-canvas branch label is a keyboard control, tree-view toggle is named and the node is a button only with onNodeClick, file-upload dropzone takes Enter / Space, and a never-firing onSelect on the app preview's read-only nav row is removed. Added clickableNonControlCensus-13461 (ordinary suite, deletions only): 33 non-control sites declared with one of four reasons, and 16 controls frozen in BACKLOG (15 in plugins outside the claim, 1 delegated field selection in the studio data-form preview).", "tests": "Head ecd30ca (after merging main). Before the merge: 221 test files importing changed modules (4 runs: 56/56, 54/54, 50/50, 61/61 files) and 40 tests that read changed files by path (40/40 after the tree-view fix; the first run had 4 red cases in tree-view-nodes-mirror-6939, a renderer-output freeze, fixed by not adding a wrapper span). packages/i18n/: 87/87 files. After the merge: both censuses, ariaLabelLiteralCensus-12145, the new tests, OrganizationsPage, AppHeader.myOrganizations and tree-view-nodes-mirror-6939 passed, 8/8 files, 54/54 tests. Ablation, done once and not kept: OrganizationsPage.tsx restored from origin/main turned the new census red ('OrganizationsPage.tsx · span · stopPropagation,navigate — declared 0, found 1'). It was restored with git checkout HEAD --, and git diff HEAD was empty.", "gates": "Local, exit codes captured before any pipe: check:i18n-keys :: exit 0; check:i18n-dead-keys :: exit 0; check:i18n-drift :: exit 0; check:i18n-designer-parity :: exit 0; check:new-line-citations :: exit 0 (0 new); check-changeset-presence :: exit 0; check-changeset-no-major :: exit 0; check-changeset-claims :: exit 0; check-pending-changeset-literals :: exit 0; check-changeset-fixed :: exit 0; turbo type-check (app-shell, components, fields, plugin-chatbot, i18n plus deps) :: exit 0 after a fields test-typing fix; eslint on touched files: 0 errors with inline config. The one --no-inline-config error, react-hooks/static-components in AppPreview.tsx, is also in origin/main's copy. NOT MEASURED: check:eager-locale-catalogues (PREREQUISITE NOT MET, needs a built console bundle). objectui has no dispatch-gates.mjs, so the gate families were derived by hand. CI check-runs: in_progress at report time.", "dogfood_battery": "n/a — no '!' in the PR title and Clause-②: no", "mcp_calls": "7 — GitHub MCP reads only: issue_read x3 (card get, comments x2); subscribe_pr_activity x1 (session tool); no MCP write", "api_writes": "2 — relay pr_create (objectui#13494) and this os-dev-report comment; the reviewer request is a third relay write (pr_request_reviewers)", "open_questions": [], "out_of_scope_findings": [ "carrier: the domain:ui seat · the remaining same-family backlog: 15 plugin clickable div/span controls frozen in clickableNonControlCensus-13461 BACKLOG (plugin-ai AIRecommendations, plugin-designer Dashboard/DataModel/Page/Process/Report designers, plugin-gantt task bars, plugin-grid mobile cards and VirtualGrid rows, plugin-view ManageViewsDialog rows) and the 14 plugin rows left in iconOnlyButtonCensus-12143 BACKLOG (plugin-ai, plugin-detail, plugin-list, plugin-view) · both lists are deletions-only, so the next card burns them down from the census · dedupe words: clickable div keyboard, icon-only button name, plugin a11y backlog", "carrier: none · noted, not filed: the studio data-form preview selects a field by a click delegated from its frame (StudioDesignSurface, handler 'closest,getAttribute,some,readFields,setFieldSel'), so it has no keyboard selection path; frozen in BACKLOG, the fix is a design question", "carrier: none · noted, not filed: literal English copy next to touched controls (legacy Chatbot empty state, MasterDetailField record count, file-upload launch copy, ResourceHistoryPage 'Back to item'); left as Acceptance notes" ] }Generated by Claude Code
objectstack-fleet commentedon Oct 25, 2026
Landed ·
domain:ui#4· 2026-10-25T03:48ZPR #13494 merged at 2026-10-25T03:46Z, merge commit
4aa90bae81631de0da71879eb242511afbfa26aa. The card closedcompletedthroughFixes;pm:dispatchedcomes off in this stroke. objectui merges publish nothing (the changesets release is a human act).Generated by Claude Code
fix(a11y): name icon-only buttons and give clickable div/span control…