Skip to content

Enterocyte refactor renaming - #2944

Open
JABelfiore wants to merge 52 commits into
masterfrom
2882-enterocyte-refactor-renaming
Open

JABelfiore wants to merge 52 commits into
masterfrom
2882-enterocyte-refactor-renaming

Conversation

@JABelfiore

Copy link
Copy Markdown
Contributor

No description provided.

enterocyte of epithelium of small intestine --> small intestine enterocyte
early enterocyte --> early small intestine enterocyte.
@JABelfiore
JABelfiore requested a review from dosumis February 10, 2025 16:47
@JABelfiore JABelfiore self-assigned this Feb 10, 2025
@JABelfiore JABelfiore linked an issue Feb 10, 2025 that may be closed by this pull request
@JABelfiore JABelfiore changed the title 2882 enterocyte refactor renaming Enterocyte refactor renaming Feb 10, 2025
@dosumis

dosumis commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

#gogoeditdiff

@github-actions

github-actions Bot commented Feb 14, 2025 •

Copy link
Copy Markdown
Contributor
Here's a diff of how these changes impact the classified ontology (on -base file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2025-03-12/cl-base.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-base-master.owl/cl-base.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2025-03-12/cl-base.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-base-pr.owl/cl-base.owl

Ontology imports

Ontology annotations

enterocyte http://purl.obolibrary.org/obo/CL_0000584

Removed

Added

  • enterocyte IAO_0000115 "An epithelial cell that has its apical plasma membrane folded into microvilli to provide ample surface for the absorption of nutrients from the intestinal lumen. This covers both the large and small intestine."

enterocyte of epithelium of intestinal villus http://purl.obolibrary.org/obo/CL_1000335

Added

immature colonocyte http://purl.obolibrary.org/obo/CL_4047018

Removed

Added

immature small intestine enterocyte http://purl.obolibrary.org/obo/CL_4047019

Removed

Added

immature small intestine entrocyte http://purl.obolibrary.org/obo/CL_0008050

Added

mature colonocyte http://purl.obolibrary.org/obo/CL_0008052

Added

mature small intestince enterocyte http://purl.obolibrary.org/obo/CL_0008051

Added

small intestine enterocyte http://purl.obolibrary.org/obo/CL_1000334

Removed

Added

@github-actions

github-actions Bot commented Feb 14, 2025 •

Copy link
Copy Markdown
Contributor
Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl-edit.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl-edit.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

early colonocyte http://purl.obolibrary.org/obo/CL_4047018

Removed

Added

early enterocyte http://purl.obolibrary.org/obo/CL_4047019

Removed

Added

enterocyte http://purl.obolibrary.org/obo/CL_0000584

Removed

Added

  • enterocyte definition "An epithelial cell that has its apical plasma membrane folded into microvilli to provide ample surface for the absorption of nutrients from the intestinal lumen. This covers both the large and small intestine."

enterocyte of epithelium of intestinal villus http://purl.obolibrary.org/obo/CL_1000335

Added

enterocyte of epithelium of small intestine http://purl.obolibrary.org/obo/CL_1000334

Removed

Added

immature small intestine entrocyte http://purl.obolibrary.org/obo/CL_0008050

Added

mature colonocyte http://purl.obolibrary.org/obo/CL_0008052

Added

mature small intestince enterocyte http://purl.obolibrary.org/obo/CL_0008051

Added

JABelfiore and others added 8 commits February 18, 2025 10:52
- [x] Make sure early is not part of standard/mature
- [x] Get rid of differentiated enterocyte from synonyms
- [x] Mature and immature to be used instead of early and late
QUick attempt at fix.  Needs review to see if any more earlier changes need reverting.
@dosumis

dosumis commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

#gogoeditdiff

@github-actions

Copy link
Copy Markdown
Contributor

Your branch is 3 commit/s behind, please update your branch.

@dosumis

dosumis commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

#gogoeditdiff

@dosumis
dosumis marked this pull request as draft March 12, 2025 12:21
@dosumis

dosumis commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

Remaining issues:

  1. General definition of enterocyte refers to mature state. Ditto colonocyte.
  2. Defs needed for mature colonocyte + immature and mature small intestine enterocyte
  3. EC def of immature small intestine enterocyte is dubious
  4. Species neutral terminology: Can we make enterocyte neutral, or should we aim to use 'gut absorptive cell'? A: making either species neutral requires deleting taxon restriction on mucosa to chordata (in Uberon). Suggest push to second ticket.

@mkeays

mkeays commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Proposed updates:

  • Rather than making a lot of mature-specific definitions of existing terms more general to encompass mature and immature states, rename "enterocyte" (CL:0000584) to "mature enterocyte", and add a sibling term "immature enterocyte" as a subclass of "gut absorptive cell" (CL:0000677). Definition of "gut absorptive cell" needs to be made more general as it specifies microvilli -- looks like it came from ZFA as the definition is the same. If we broaden it to be any absorptive cell in the gut it would be applicable to more taxa as well. Then "immature colonocyte" and "immature small intestine enterocyte" can be children of "immature enterocyte".
  • Rename CL:1000347 "colonocyte" to "mature colonocyte" and keep the relationships in the description of CL:0008052, but remove CL:0008052.
  • Rename CL:1000334 "small intestine enterocyte" to "mature small intestine enterocyte" and keep the relationships in the description of CL:0008051 but remove CL:0008051.
  • There are two terms here called "immature small intestine enterocyte" -- CL:4047019 and CL:0008050. We should replace CL:0008050 with CL:4047019.
  • On CL:4047019 we should remove the Equivalent To relationship and add a 'part of' some 'epithelium of crypt of Lieberkuhn of small intestine' (UBERON:0022280).

@mkeays

mkeays commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Proposed new definition for CL:0000677: "An epithelial cell of the gut epithelium that is committed to the absorptive lineage."
This is broad enough to cover gut in any taxon that has a gut and any stage of differentiation following transit amplifying stage.

@mkeays

mkeays commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Also add general "enterocyte" and "colonocyte" term to cover either immature or mature states, as these are often referred to together (e.g. the enterocyte cluster includes both mature and immature enterocytes).

@mkeays mkeays self-assigned this Oct 14, 2026
@mkeays

mkeays commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Fixed a couple of definitions to broaden them as they were too small-intestine-specific.

Used rdfs:comment to clarify usage of the words "early" and "immature" in lysosome-rich enterocyte and vacuolated fetal-type enterocyte. These terms both have "early enterocyte" and "immature enterocyte" as related synonyms, but they mean "early" and "immature" in an organism development context rather than a cell maturation context as we've used in above commits. I think it makes sense to keep them despite the conflict because they are words that are used in both contexts to refer to different things.

@mkeays

mkeays commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

replacing CL:1000339 (enterocyte of epithelium proper of small intestine) with CL:0019035 (small intestine enterocyte) -- the former was in cellxgene_subset so may need to update them?

@mkeays
mkeays marked this pull request as ready for review October 20, 2026 14:58

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enterocyte refactor & renaming

4 participants