Repository navigation
ci(clara): load MCP config from pinned clara_workflow ref - #3773
Merged
Merged
Conversation
Point --mcp-config at clara_workflow_ref/.mcp.json so the agent's tool wiring is versioned together with agent_instructions.md via CLARA_WORKFLOW_REF, rather than depending on the root .mcp.json. Bump the pin to 234ac67, which contains the fixed Asta config (Cellular-Semantics/clara_workflow#10). The root .mcp.json is kept for other uses; --mcp-config takes precedence for same-named servers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--mcp-confignow points atclara_workflow_ref/.mcp.jsoninstead of the repo-root.mcp.json.CLARA_WORKFLOW_REFis bumped from5c61100to234ac67, which includes the fixed Asta config (Fix Asta MCP config: drop invalid "tools" key Cellular-Semantics/clara_workflow#10). The only difference between the two refs is that.mcp.jsonfix.Why
The agent's instructions were already versioned through
CLARA_WORKFLOW_REF, but its MCP servers came from this repo's root.mcp.json. That's why the invalid Asta entry had to be fixed in two places (#3772). Reading the config from the pinned ref keeps instructions and tool wiring in step.This is safe for PR runs:
clara_workflow_ref/is checked out from Cellular-Semantics at a pinned SHA, so PR content can't change it.Root
.mcp.jsonis keptThe root file is used elsewhere, so it stays. The action enables all project MCP servers, so it still loads as a project config. When the same server name is defined in both,
--mcp-configtakes precedence. I checked this locally with Claude Code 2.1.286: with a broken Asta URL in the project.mcp.jsonand a valid one passed via--mcp-config, Asta connected withsource: dynamicandsnippet_searchreturned results.Testing
Not yet run in CI. Next
/clararun: check that the init log showsAsta_semanticscholarconnected (source: dynamic) and thatruns/CL_…/tool_calls.jsonlcontainssnippet_searchcalls.🤖 Generated with Claude Code