Skip to content

[IMP] topbar: improve clear formatting action - #9438

Open
hokolomopo wants to merge 1 commit into
masterfrom
master-better-clear-formatting-adrm
Open

[IMP] topbar: improve clear formatting action#9438
hokolomopo wants to merge 1 commit into
masterfrom
master-better-clear-formatting-adrm

Conversation

@hokolomopo

Copy link
Copy Markdown
Contributor

Description

With this commit, the clear formatting action does a bit more than clearing the format/style: it also clears merges, conditional formats and table styles.

We kept the old CLEAR_FORMATTING as it was so is doesn't break existing spreadsheet (and the command is still used once), and created a new CLEAR_ALL_STYLING command that clears everything else and dispatches a CLEAR_FORMATTING.

Task: 5391157

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo

robodoo commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Pull request status dashboard

@hokolomopo
hokolomopo force-pushed the master-better-clear-formatting-adrm branch from 3fc3102 to 34d53fe Compare August 25, 2026 11:24
With this commit, the clear formatting action does a bit more than
clearing the format/style: it also clears merges, conditional formats
and table styles.

We kept the old `CLEAR_FORMATTING` as it was so is doesn't break
existing spreadsheet (and the command is still used once), and
created a new `CLEAR_ALL_STYLING` command that clears everything else
and dispatches a `CLEAR_FORMATTING`.

Task: 5391157
@hokolomopo
hokolomopo force-pushed the master-better-clear-formatting-adrm branch from 34d53fe to f81dc6f Compare September 1, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants