[FIX] util/orm: don't mark inherited field manual for custom

During the upgrade process, inherited fields were incorrectly
marked as `manual`, while they should retain their original
state (`base`).

Fields created via Studio are expected to have `state = manual`,
whereas inherited fields must remain `base` according to ORM
behavior [1]. Overriding this state leads to unintended side
effects.

In particular, marking inherited fields as `manual` triggers
unnecessary computations, especially for non-stored fields and
Many2many fields linked to `ir.attachment`. This can lead to
tracebacks and block upgrade requests

This change ensures that:
- inherited fields are not marked as `manual`
- only fields explicitly created via Studio or `ir.model.fields`
  are considered `manual`

This aligns the upgrade behavior with the ORM logic and prevents
unwanted computations on inherited fields.

[1]: https://github.com/odoo/odoo/blob/d58f4ed332af35f6de26a93f07adf05368731e20/odoo/orm/model_classes.py#L493-L508
```
('account.product_product_menu_sellable', 122, 'Accounting > Customers > Products', 254):
 Traceback (most recent call last):
   File "/tmp/tmpqgivh7_j/migrations/base/tests/test_mock_crawl.py", line 335, in crawl_menu
    self.mock_action(action_vals)
   File "/tmp/tmpqgivh7_j/migrations/base/tests/test_mock_crawl.py", line 348, in mock_action
    return self.mock_act_window(action)
   File "/tmp/tmpqgivh7_j/migrations/base/tests/test_mock_crawl.py", line 432, in mock_act_window
    views = get_views(
   File "/home/odoo/src/odoo/19.0/addons/mail/models/mail_thread.py", line 471, in get_views
    res = super().get_views(views, options)
   File "/home/odoo/src/enterprise/19.0/web_studio/models/models.py", line 10, in get_views
    result = super().get_views(views, options=options)
   File "/home/odoo/src/enterprise/19.0/web_studio/models/ir_ui_view.py", line 52, in get_views
    return super().get_views(views, options)
   File "/home/odoo/src/odoo/19.0/odoo/addons/base/models/ir_ui_view.py", line 2946, in get_views
    result['models'][model] = {"fields": self.env[model].fields_get(
   File "/home/odoo/src/enterprise/19.0/web_studio/models/ir_model.py", line 76, in fields_get
    return super().fields_get(allfields, attributes=attributes)
   File "/home/odoo/src/enterprise/19.0/ai_fields/models/models.py", line 47, in fields_get
    res = super().fields_get(allfields, attributes)
   File "/home/odoo/src/odoo/19.0/odoo/orm/models.py", line 3361, in fields_get
    description = field.get_description(self.env, attributes=attributes)
   File "/home/odoo/src/odoo/19.0/odoo/orm/fields.py", line 884, in get_description
    value = value(env)
   File "/home/odoo/src/odoo/19.0/odoo/orm/fields.py", line 937, in _description_groupable
    model._read_group_groupby(model._table, groupby, query)
   File "/home/odoo/src/odoo/19.0/addons/mail/models/mail_activity_mixin.py", line 257, in _read_group_groupby
    return super()._read_group_groupby(alias, groupby_spec, query)
   File "/home/odoo/src/odoo/19.0/odoo/orm/models.py", line 2064, in _read_group_groupby
    coquery = comodel._search(codomain, bypass_access=field.bypass_search_access)
   File "/home/odoo/src/odoo/19.0/odoo/addons/base/models/ir_attachment.py", line 677, in _search
    records = self.sudo().with_context(active_test=False).search_fetch(
   File "/home/odoo/src/odoo/19.0/odoo/orm/models.py", line 1418, in search_fetch
    return self._fetch_query(query, fields_to_fetch)
   File "/home/odoo/src/odoo/19.0/odoo/orm/models.py", line 3917, in _fetch_query
    rows = self.env.execute_query(query.select(*sql_terms))
   File "/home/odoo/src/odoo/19.0/odoo/orm/environments.py", line 534, in execute_query
    self.cr.execute(query)
   File "/home/odoo/src/odoo/19.0/odoo/tests/test_cursor.py", line 79, in execute
    return self._cursor.execute(*args, **kwargs)
   File "/home/odoo/src/odoo/19.0/odoo/sql_db.py", line 433, in execute
    self._obj.execute(query, params)
 psycopg2.DatabaseError: out of memory for query result
```

upg-4179716
opw-6101425

Author: sagu-odoo

src/util/orm.py

@@ -16,6 +16,8 @@
 from itertools import chain
 from textwrap import dedent
 
+from psycopg2 import sql
+
 try:
     from unittest.mock import patch
 except ImportError:
@@ -663,34 +665,68 @@ def custom_module_field_as_manual(env, rollback=True, do_flush=False):
     # if the field was not correctly removed from the database during past upgrades, the field remains in the database.
     reserved_words = ["env"]
     ignores = {"ir.actions.server": ["condition"], "ir.ui.view": ["page"]}
+
+    cte = ""
+    include = ""
+    if version_gte("17.0"):
+        cte = """
+                WITH delegated_fields AS (
+                    SELECT array_agg(f.id) AS ids
+                      FROM ir_model_fields f
+                      JOIN ir_model m
+                        ON m.id = f.model_id
+                       AND m.model = %s
+                      JOIN ir_model_inherit i
+                        ON i.model_id = m.id
+                       AND i.parent_field_id IS NOT NULL
+                      JOIN ir_model_fields lf
+                        ON lf.id = i.parent_field_id
+                     WHERE f.related = lf.name || '.' || f.name
+                )
+              """
+        include = "AND id NOT IN (SELECT unnest(ids) FROM delegated_fields)"
+
+    query = format_query(
+        env.cr,
+        """
+                {cte}
+                UPDATE ir_model_fields
+                   SET state = 'manual'
+                 WHERE state = 'base'
+                   AND model = %s
+                   AND name NOT IN %s
+                {include}
+            RETURNING id
+            """,
+        cte=sql.SQL(cte),
+        include=sql.SQL(include),
+    )
     for model in models:
         model_fields = tuple(list(env.registry[model]._fields) + reserved_words + ignores.get(model, []))
-        env.cr.execute(
-            """
-            UPDATE ir_model_fields
-               SET state = 'manual'
-             WHERE state = 'base'
-               AND model = %s
-               AND name not in %s
-         RETURNING id
-        """,
-            [model, model_fields],
-        )
+        if not cte:
+            env.cr.execute(
+                query,
+                [model, model_fields],
+            )
+        else:
+            env.cr.execute(
+                query,
+                [model, model, model_fields],
+            )
         updated_field_ids += [r[0] for r in env.cr.fetchall()]
 
     # 2.2 Convert fields of custom models, models that were just converted to `manual` models in the previous step.
     for model in custom_models:
-        env.cr.execute(
-            """
-            UPDATE ir_model_fields
-               SET state = 'manual'
-             WHERE state = 'base'
-               AND model = %s
-               AND name not in %s
-         RETURNING id
-        """,
-            (model, tuple(reserved_words)),
-        )
+        if not cte:
+            env.cr.execute(
+                query,
+                [model, tuple(reserved_words)],
+            )
+        else:
+            env.cr.execute(
+                query,
+                [model, model, tuple(reserved_words)],
+            )
         updated_field_ids += [r[0] for r in env.cr.fetchall()]
 
     # 2.3 Temporarily disable rules that come from custom modules