[FIX] pyproject: allow editable installs - #479
Open
yajo wants to merge 1 commit into
Open
Conversation
Editable installs failed because hatchling's dev-mode path rewrite
("src" -> "odoo/upgrade") is unsupported by the editables library,
raising a ValueError (pfmoore/editables#20).
Expose the upgrade scripts at their real location by adding a symlink
`odoo/upgrade` pointing to `src`, and set `dev-mode-dirs = ["."]` so the
repo root is added to the path in dev mode. `sources` is left untouched,
so regular wheels keep building unchanged.
Fixes odoo#190
Assisted-by: OpenCode + DeepSeek v4 Flash
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editable installs failed because hatchling's dev-mode path rewrite ("src" -> "odoo/upgrade") is unsupported by the editables library, raising a ValueError (pfmoore/editables#20).
Expose the upgrade scripts at their real location by adding a symlink
odoo/upgradepointing tosrc, and setdev-mode-dirs = ["."]so the repo root is added to the path in dev mode.sourcesis left untouched, so regular wheels keep building unchanged.Fixes #190
Assisted-by: OpenCode + DeepSeek v4 Flash
Notice that a nicer fix would be to rename
srcintoodoo/upgrade, because I don't know how Windows will handle symlinks; but this is the MVP.