Skip to content

[IMP] util.ensure_xmlid_match_record: allow setting the noupdate flag #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luisg123v wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] util.ensure_xmlid_match_record: allow setting the noupdate flag #499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/util/records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,7 +1002,7 @@ def force_noupdate(cr, xmlid, noupdate=True, warn=False):
return cr.rowcount


def ensure_xmlid_match_record(cr, xmlid, model, values):
def ensure_xmlid_match_record(cr, xmlid, model, values, noupdate=AUTOMATIC):
"""
Ensure an xml_id references a record with specific values.

Expand All @@ -1024,6 +1024,9 @@ def ensure_xmlid_match_record(cr, xmlid, model, values):
values = {"id": 123}
values = {"name": "INV/2024/0001", "company_id": 1}

:param bool noupdate: value to set on the `noupdate` flag of the xml_id. By default, the
flag is set to `True` when the xml_id is created and left untouched
when it already exists.
:return: the ID of the matched record, `None` if no record found
:rtype: int or None

Expand All @@ -1049,6 +1052,9 @@ def ensure_xmlid_match_record(cr, xmlid, model, values):
)
data_id, res_id = cr.fetchone() or (None, None)

if data_id and noupdate is not AUTOMATIC:
force_noupdate(cr, xmlid, noupdate)

table = table_of_model(cr, model)

# search for existing records matching values
Expand Down Expand Up @@ -1093,7 +1099,7 @@ def ensure_xmlid_match_record(cr, xmlid, model, values):
INSERT INTO ir_model_data(module, name, model, res_id, noupdate)
VALUES (%s, %s, %s, %s, %s)
""",
[module, name, model, new_res_id, True],
[module, name, model, new_res_id, True if noupdate is AUTOMATIC else noupdate],
)

return new_res_id
Expand Down