Phase 1: progressive-disclosure refactor — reviewer (829 → 424 lines) - #18
Merged
Conversation
Split into a lean SKILL.md (gate check, trigger, context, doc lookup, role, jira integration, review navigation, architecture verification, AC validation, review principles, comment quality, security checks, anti-patterns, universal principles + references index) and 3 references/ files: review-checklist, feedback-and-reports, process-and-style. Real section boundaries; fences verified balanced/non-nested - the feedback-format examples' outer markdown fences bumped to 4 backticks so their inner code blocks render correctly. No content lost.
There was a problem hiding this comment.
Pull request overview
Refactors the /rev reviewer skill documentation into a progressive-disclosure layout by slimming SKILL.md and moving detailed guidance into dedicated references/ markdown files, aiming to keep the core skill fast to load while preserving deep-dive material on demand.
Changes:
- Removed the inlined full review checklist, feedback/report templates, and three-pass process content from
SKILL.md. - Added a “Deep-dive references” router section in
SKILL.mdpointing to the extracted reference docs. - Introduced three new reference documents under
references/for checklist, feedback/report templates, and process/style guidance.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| claude/skills/quality/review/reviewer/SKILL.md | Removes large inlined guidance sections and adds pointers to deep-dive reference docs. |
| claude/skills/quality/review/reviewer/references/review-checklist.md | New file containing the full code review checklist content. |
| claude/skills/quality/review/reviewer/references/feedback-and-reports.md | New file containing review feedback formats and the review report template (with adjusted fences for nesting). |
| claude/skills/quality/review/reviewer/references/process-and-style.md | New file containing the three-pass process, pre-approval checklist, and self-documenting-code review guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The review report template moved to references/feedback-and-reports.md; update the Jira-comment body placeholder to point there instead of 'below'.
- review-checklist.md: repoint 'see detection table' and 'AC Validation above' to the corresponding sections in the main reviewer SKILL. - feedback-and-reports.md: add a 'Static Analysis Results' section to the report template so it matches the process-and-style.md reporting instruction.
…LL.md sections Use relative markdown links (../SKILL.md#anchor) for the Code Smells detection table and AC Validation references instead of plain text.
This was referenced Jun 5, 2026
olehsvyrydov
added a commit
that referenced
this pull request
Jun 6, 2026
e2e-tester: Add waitFor vs isVisible pattern, domcontentloaded over networkidle, test ordering for rate-limited endpoints, shared helpers pattern, console error filter specificity, locale-varying UI selectors. Add anti-patterns #18-21. tester: Add cross-reference verification section — verify field names and identifiers against actual system before finalizing test cases. Add anti-pattern #12. reviewer: Expand Copilot review patterns, add memoization and caching scope review checklist.
olehsvyrydov
added a commit
that referenced
this pull request
Jun 6, 2026
…#18) * Phase 1: progressive-disclosure refactor of reviewer (829 -> 424 lines) Split into a lean SKILL.md (gate check, trigger, context, doc lookup, role, jira integration, review navigation, architecture verification, AC validation, review principles, comment quality, security checks, anti-patterns, universal principles + references index) and 3 references/ files: review-checklist, feedback-and-reports, process-and-style. Real section boundaries; fences verified balanced/non-nested - the feedback-format examples' outer markdown fences bumped to 4 backticks so their inner code blocks render correctly. No content lost. * Address Copilot review on PR #18: fix stale 'see template below' pointer The review report template moved to references/feedback-and-reports.md; update the Jira-comment body placeholder to point there instead of 'below'. * Address Copilot re-review on PR #18: fix split cross-references - review-checklist.md: repoint 'see detection table' and 'AC Validation above' to the corresponding sections in the main reviewer SKILL. - feedback-and-reports.md: add a 'Static Analysis Results' section to the report template so it matches the process-and-style.md reporting instruction. * Address Copilot re-review on PR #18: link checklist cross-refs to SKILL.md sections Use relative markdown links (../SKILL.md#anchor) for the Code Smells detection table and AC Validation references instead of plain text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Slice-4 refactor #13. Splits
reviewer(829 lines) into a leanSKILL.md(424 lines) + 3references/files:review-checklist.md— the full code-review checklist.feedback-and-reports.md— review feedback format + report template.process-and-style.md— three-pass review process, pre-approval checklist, self-documenting-code review.Lean
SKILL.mdkeeps gate check, review navigation, architecture verification, AC validation, review principles, comment quality, security checks, workflow triggers, anti-patterns.Why
Same pattern as #5–#17. No content lost (829 → 424 + 3 refs). Fences verified balanced and non-nested — the feedback-format example templates wrap inner code blocks, so their outer
markdownfences were bumped to 4 backticks to render correctly.Review focus
Content preservation; coherent lean router; fenced-template rendering.