Phase 1: progressive-disclosure refactor — javafx-developer (799 → 200 lines) - #20
Merged
Merged
Conversation
…200 lines) Move the ~605-line Expertise block into references/javafx-expertise.md (versions, core concepts: setup/MVVM/FXML/CSS/threading/packaging, GraalVM, project structure). Lean SKILL.md keeps trigger, context, doc lookup, standards, checklist, MVVM gold standard, sizing gotchas, TestFX, anti-patterns. Fences verified. No content lost.
There was a problem hiding this comment.
Pull request overview
Refactors the javafx-developer skill into a progressive-disclosure layout by extracting the large “Expertise” block into a dedicated references/ document, keeping SKILL.md as a lean router.
Changes:
- Replaces the inline “Expertise” section in
SKILL.mdwith a “Deep-dive references” pointer. - Adds
references/javafx-expertise.mdcontaining the extracted JavaFX expertise material (versions, MVVM, FXML, CSS, threading, packaging, GraalVM, structure).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| claude/skills/development/desktop/javafx/javafx-developer/SKILL.md | Removes the large embedded expertise section and links to the deep-dive reference. |
| claude/skills/development/desktop/javafx/javafx-developer/references/javafx-expertise.md | Adds the extracted expertise content as an on-demand reference document. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- FXML: Insets uses top/right/bottom/left, not the invalid topRightBottomLeft. - GraalVM reflection config: tag the block as json (it's JSON, not java).
olehsvyrydov
added a commit
that referenced
this pull request
Jun 6, 2026
…0 lines) (#20) * Phase 1: progressive-disclosure refactor of javafx-developer (799 -> 200 lines) Move the ~605-line Expertise block into references/javafx-expertise.md (versions, core concepts: setup/MVVM/FXML/CSS/threading/packaging, GraalVM, project structure). Lean SKILL.md keeps trigger, context, doc lookup, standards, checklist, MVVM gold standard, sizing gotchas, TestFX, anti-patterns. Fences verified. No content lost. * Address Copilot review on PR #20: fix two imported javafx snippet bugs - FXML: Insets uses top/right/bottom/left, not the invalid topRightBottomLeft. - GraalVM reflection config: tag the block as json (it's JSON, not java).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Slice-4 refactor #15. Splits
javafx-developer(799 lines) into a leanSKILL.md(200 lines) + 1references/file (the ~605-line Expertise block):javafx-expertise.md— versions, core concepts (project setup, app entry point, MVVM, FXML, CSS styling, threading model, native packaging via jpackage), GraalVM native image, project structure.Lean
SKILL.mdkeeps trigger, context, doc lookup, standards, checklist, MVVM gold standard, sizing gotchas, TestFX, anti-patterns.Why
Same pattern as #5–#19. No content lost (799 → 200 + 1 ref); fences verified balanced/non-nested.
Review focus
Content preservation; coherent lean router.