Phase 1: progressive-disclosure refactor — javafx-designer (640 → 97 lines) - #22
Merged
Conversation
…7 lines) Move the ~549-line Expertise block into references/javafx-design-expertise.md (CSS, design system, component library, layout patterns, Scene Builder, accessibility). Lean SKILL.md keeps trigger, context, doc lookup, standards, checklist, anti-patterns. Fences verified. No content lost.
There was a problem hiding this comment.
Pull request overview
Refactors the javafx-designer skill into a progressive-disclosure layout by moving the large “Expertise” section into a dedicated deep-dive reference file, keeping SKILL.md lean and focused as a router.
Changes:
- Replaced the inlined “Expertise” block in
SKILL.mdwith a short “Deep-dive references” pointer. - Added
references/javafx-design-expertise.mdcontaining the moved JavaFX design expertise material (CSS, components, layout patterns, Scene Builder, accessibility).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| claude/skills/design/javafx-designer/SKILL.md | Slimmed to a router that points to deep-dive reference material. |
| claude/skills/design/javafx-designer/references/javafx-design-expertise.md | New reference doc holding the detailed JavaFX design expertise content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- CSS selector comparison: JavaFX uses .class/#id (same as web); #id targets the Node id, not fx:id. - Remove unsupported -fx-text-transform (note to uppercase in code/FXML instead). - FXML styleClass is space-separated, not comma (nav-item active; button primary). - Scene Builder tip: style classes set via the styleClass list, not -fx-style-class. - Typo: Self-Employ -> Self-Employed.
olehsvyrydov
added a commit
that referenced
this pull request
Jun 6, 2026
…lines) (#22) * Phase 1: progressive-disclosure refactor of javafx-designer (640 -> 97 lines) Move the ~549-line Expertise block into references/javafx-design-expertise.md (CSS, design system, component library, layout patterns, Scene Builder, accessibility). Lean SKILL.md keeps trigger, context, doc lookup, standards, checklist, anti-patterns. Fences verified. No content lost. * Address Copilot review on PR #22: fix imported JavaFX CSS/FXML errors - CSS selector comparison: JavaFX uses .class/#id (same as web); #id targets the Node id, not fx:id. - Remove unsupported -fx-text-transform (note to uppercase in code/FXML instead). - FXML styleClass is space-separated, not comma (nav-item active; button primary). - Scene Builder tip: style classes set via the styleClass list, not -fx-style-class. - Typo: Self-Employ -> Self-Employed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Slice-4 refactor #17. Splits
javafx-designer(640 lines) into a leanSKILL.md(97 lines) + 1references/file (the ~549-line Expertise block):javafx-design-expertise.md— versions, JavaFX CSS vs web CSS, design-system foundation, component library, layout patterns, Scene Builder tips, accessibility checklist.Lean
SKILL.mdkeeps trigger, context, doc lookup, standards, checklist, anti-patterns.Why
Same pattern as #5–#21 —
SKILL.md< ~500 lines; deep content loaded on demand.Note — correctness fixes applied during review
The split itself is content-preserving, but during Copilot review 6 small correctness fixes were made to the (pre-existing) JavaFX content in the reference — these are deliberate corrections, not a pure relocation:
.class/#id(same as web);#idtargets the Node id, notfx:id.-fx-text-transform(note to uppercase in code/FXML instead).styleClassis space-separated, not comma (×2).styleClasslist, not-fx-style-class.Review focus
Content preservation; coherent lean router.