Restore direct VA-API DMA-BUF import

Author: minpeter

internal/airplay/capture.go

@@ -734,26 +734,15 @@ func pipeWireVideoSourceStage(fd int, nodeID uint32, fps int, copyPortalBuffers
 		fmt.Sprintf("keepalive-time=%d", frameIntervalMillis(fps)),
 	}
 	if copyPortalBuffers {
-		// The compositor and pipewiresrc's keepalive path both retain the latest
-		// GstBuffer. With a small portal pool that can keep every PipeWire buffer
-		// checked out and freeze screencopy. Copying here returns the portal buffer
-		// as soon as pipewiresrc pulls it while downstream retains only the copy.
+		// The software path cannot import a portal DMA-BUF through VA-API. Copy
+		// immediately so downstream never retains a PipeWire-owned buffer.
 		stage = append(stage, "always-copy=true")
 	}
 	return stage
 }
 
 func vaapiVideoImportStages() []gstStage {
-	// Force a fresh VA surface even when the portal's DMA-BUF already satisfies
-	// downstream caps, then download it into system memory. The forced-live
-	// compositor may retain its latest input; retaining the portal DMA-BUF would
-	// eventually exhaust PipeWire's pool and repeat one stale capture timestamp.
-	return []gstStage{
-		{"vapostproc", "disable-passthrough=true"},
-		// An unfeatured raw caps filter means system memory while leaving the
-		// pixel format negotiable, preserving 10-bit portal input for HEVC.
-		{"video/x-raw"},
-	}
+	return []gstStage{{"vapostproc"}}
 }
 
 func waylandVideoInputStages(fd int, nodeID uint32, fps int, useVAAPI bool) (gstStage, []gstStage) {

internal/airplay/capture_test.go

@@ -390,12 +390,9 @@ func TestPipeWireVideoSourceCopiesPortalBuffersForSoftwareConversion(t *testing.
 	}
 }
 
-func TestVAAPIPostprocCopiesPortalDMABufferToSystemMemory(t *testing.T) {
+func TestVAAPIPostprocReceivesOriginalPortalDMABuffer(t *testing.T) {
 	got := vaapiVideoImportStages()
-	want := []gstStage{
-		{"vapostproc", "disable-passthrough=true"},
-		{"video/x-raw"},
-	}
+	want := []gstStage{{"vapostproc"}}
 	if !reflect.DeepEqual(got, want) {
 		t.Fatalf("VA-API import stages = %v, want %v", got, want)
 	}
@@ -409,13 +406,10 @@ func TestWaylandVideoInputStagesPreservePortalBufferOwnership(t *testing.T) {
 		wantImports []gstStage
 	}{
 		{
-			name:       "VA-API imports before system-memory copy",
-			useVAAPI:   true,
-			wantSource: gstStage{"pipewiresrc", "fd=3", "path=42", "do-timestamp=true", "keepalive-time=33"},
-			wantImports: []gstStage{
-				{"vapostproc", "disable-passthrough=true"},
-				{"video/x-raw"},
-			},
+			name:        "VA-API imports original portal buffer",
+			useVAAPI:    true,
+			wantSource:  gstStage{"pipewiresrc", "fd=3", "path=42", "do-timestamp=true", "keepalive-time=33"},
+			wantImports: []gstStage{{"vapostproc"}},
 		},
 		{
 			name:       "software conversion copies portal buffer",