Report what the appliance is doing, not only what it was asked to do

Each function says separately whether it is running. Without that, a
compressor that has reached its target looks exactly like one still working
towards it -- both report mode Cool.

Also trims the inventory log to the device that reported it, rather than
repeating everything seen so far on every burst.

Author: cgehring-blip

README.md

@@ -23,6 +23,7 @@ tested.
 | Target temperature | 16–30 °C |
 | Current temperature | as the appliance measures it |
 | Fan | Auto, Low, Mid, High, Night |
+| Action | what the appliance is *doing*: cooling, heating, drying, fan, idle |
 
 The modes are the ones the appliance reports about itself. Plain heating is
 absent on purpose: an Aventa heats through the heat pump, which is the

custom_components/truma_aventa/climate.py

@@ -7,6 +7,7 @@
 from homeassistant.components.climate import (
     ClimateEntity,
     ClimateEntityFeature,
+    HVACAction,
     HVACMode,
 )
 from homeassistant.const import ATTR_TEMPERATURE, UnitOfTemperature
@@ -87,6 +88,29 @@ def hvac_mode(self) -> HVACMode | None:
         mode = self.coordinator.data.mode
         return _MODE_TO_HVAC.get(mode) if mode is not None else None
 
+    @property
+    def hvac_action(self) -> HVACAction | None:
+        """What the appliance is doing, as opposed to what it was asked to do.
+
+        Each function reports separately whether it is running, which is the
+        only way to tell a compressor that has reached the target from one
+        that is still working towards it.
+        """
+        data = self.coordinator.data
+        if data.mode == MODE_OFF:
+            return HVACAction.OFF
+        if data.cooling_active:
+            return HVACAction.COOLING
+        if data.heating_active:
+            return HVACAction.HEATING
+        if data.dehumid_active:
+            return HVACAction.DRYING
+        if data.circulation_active:
+            return HVACAction.FAN
+        if data.mode is None:
+            return None
+        return HVACAction.IDLE
+
     @property
     def current_temperature(self) -> float | None:
         """Room temperature as the appliance measures it."""

custom_components/truma_aventa/manifest.json

@@ -30,5 +30,5 @@
     "bleak-retry-connector>=3.5.0",
     "cbor2>=5.6.0"
   ],
-  "version": "0.9.2"
+  "version": "0.9.3"
 }

custom_components/truma_aventa/truma_ble/device.py

@@ -84,6 +84,10 @@
     (TOPIC_AIR_COOLING, "Temp"): "current_temperature",
     (TOPIC_AIR_HEATING, "Mode"): "heating_fan_mode",
     (TOPIC_AIR_CIRCULATION, "FanLevel"): "fan_level",
+    (TOPIC_AIR_COOLING, "Active"): "cooling_active",
+    (TOPIC_AIR_HEATING, "Active"): "heating_active",
+    (TOPIC_AIR_CIRCULATION, "Active"): "circulation_active",
+    (TOPIC_AIR_DEHUMID, "Active"): "dehumid_active",
     (TOPIC_AMBIENT_LIGHT, "Active"): "light_on",
     (TOPIC_AMBIENT_LIGHT, "LightStep"): "light_step",
     (TOPIC_IDENTIFY, "Name"): "name",
@@ -591,12 +595,14 @@ def _handle_frame(self, frame: Frame) -> dict[str, Any]:
         if "LastMessage" in body and _LOGGER.isEnabledFor(logging.DEBUG):
             # The sentinel ends a discovery burst, which is the one moment the
             # full inventory of what this appliance reports is known.
+            prefix = f"{frame.src:04X}/"
+            own = sorted(key for key in raw if key.startswith(prefix))
             _LOGGER.debug(
                 "%s: 0x%04X reported %d parameter(s): %s",
                 self._name,
                 frame.src,
-                len(raw),
-                ", ".join(f"{key}={raw[key]!r}" for key in sorted(raw)),
+                len(own),
+                ", ".join(f"{key[len(prefix) :]}={raw[key]!r}" for key in own),
             )
         if _LOGGER.isEnabledFor(logging.DEBUG):
             _LOGGER.debug(

custom_components/truma_aventa/truma_ble/models.py

@@ -45,6 +45,13 @@ class TrumaState:
     #: AirCirculation, used while ventilating.
     fan_level: int | None = None
 
+    #: Whether each function is actually running. The mode says what the
+    #: appliance was asked to do; these say what it is doing.
+    cooling_active: int | None = None
+    heating_active: int | None = None
+    circulation_active: int | None = None
+    dehumid_active: int | None = None
+
     #: AmbientLight.
     light_on: int | None = None
     light_step: int | None = None

tests/test_climate.py

@@ -0,0 +1,88 @@
+"""Tests for the climate entity."""
+
+from __future__ import annotations
+
+import sys
+from pathlib import Path
+from typing import Any
+
+import pytest
+from homeassistant.components.climate import HVACAction, HVACMode
+
+sys.path.insert(0, str(Path(__file__).resolve().parents[1]))
+
+from custom_components.truma_aventa.climate import TrumaClimate
+from custom_components.truma_aventa.truma_ble.const import (
+    MODE_COOLING,
+    MODE_OFF,
+    MODE_VENTILATING,
+)
+from custom_components.truma_aventa.truma_ble.models import TrumaState
+
+
+class _Device:
+    address = "FC:DE:C5:F0:A6:35"
+    name = "Truma iNetX-F0A635"
+
+
+class _Coordinator:
+    """The little of a coordinator an entity touches before it is added."""
+
+    def __init__(self, state: TrumaState) -> None:
+        self.data = state
+        self.device = _Device()
+        self.key = "Truma iNetX-F0A635"
+        self.available = True
+        self.last_update_success = True
+
+    def async_add_listener(self, *_: Any) -> Any:
+        return lambda: None
+
+
+def _climate(**state: Any) -> TrumaClimate:
+    """A climate entity over the given state."""
+    return TrumaClimate(_Coordinator(TrumaState(**state)))
+
+
+def test_nothing_known_yet_reports_nothing() -> None:
+    """Before the appliance has answered there is no action to report."""
+    assert _climate().hvac_action is None
+
+
+def test_switched_off_is_off() -> None:
+    """Off is a state of its own, not idleness."""
+    assert _climate(mode=MODE_OFF).hvac_action is HVACAction.OFF
+
+
+def test_cooling_while_the_compressor_runs() -> None:
+    """The mode says what was asked for; Active says what is happening."""
+    entity = _climate(mode=MODE_COOLING, cooling_active=1)
+    assert entity.hvac_mode is HVACMode.COOL
+    assert entity.hvac_action is HVACAction.COOLING
+
+
+def test_at_temperature_the_appliance_is_idle() -> None:
+    """Cooling requested, compressor off: the target has been reached."""
+    entity = _climate(mode=MODE_COOLING, cooling_active=0)
+    assert entity.hvac_mode is HVACMode.COOL
+    assert entity.hvac_action is HVACAction.IDLE
+
+
+@pytest.mark.parametrize(
+    ("running", "expected"),
+    [
+        ("heating_active", HVACAction.HEATING),
+        ("dehumid_active", HVACAction.DRYING),
+        ("circulation_active", HVACAction.FAN),
+    ],
+)
+def test_each_function_reports_its_own_action(running: str, expected: Any) -> None:
+    """Every function says separately whether it is running."""
+    assert _climate(mode=MODE_VENTILATING, **{running: 1}).hvac_action is expected
+
+
+def test_temperatures_come_from_tenths() -> None:
+    """The appliance counts in tenths of a degree."""
+    entity = _climate(current_temperature=251, target_temperature=220)
+    assert entity.current_temperature == 25.1
+    assert entity.target_temperature == 22.0