Repository navigation
fix: Implement fix for machine env overlay on machine bindings - #310
Merged
Merged
Conversation
cmsparks
changed the title
asherdale
reviewed
Aug 6, 2026
asherdale
left a comment
asherdale
left a comment
Contributor
There was a problem hiding this comment.
lgtm - one note though is that make verify fails for this right now, might want to check that out
| type: string | ||
| env_overlay: | ||
| description: Env overlay applied to processes launched through this binding; it does not change the machine environment applied to the provider machine at provisioning. A null entry removes the key. | ||
| description: Env overlay applied to processes launched through this binding. For pool bindings it is also applied to the machine environment when the pool machine is provisioned, so the provider_options startup_script and the daemon run with it; connected machines keep their own environment. A null entry removes the key. |
Contributor
There was a problem hiding this comment.
should we update the description for secret_env_overlay too?
Contributor
Author
There was a problem hiding this comment.
Yeah, i'll update this and fix make verify
Contributor
Author
There was a problem hiding this comment.
Done — secret_env_overlay now carries the same pool-binding provisioning note.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
cmsparks
force-pushed
the
fix-env-binding-overlay
branch
from
August 7, 2026 16:44
e5e993f to
d01a70d
Compare
asherdale
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting env on a machine binding (i.e. machine in an agent config) does not get propagated to the startup script or daemon on machine start. This fixes that bug.