fix(build/docker): Bump node from 10.x to 12.x - #3808
Open
carlosdagos wants to merge 1 commit into
Open
Conversation
Following the documented way to build from source using docker fails because the version of Node used is deprecated. Bumping to the currently supported version 12.x solves the problem and allows building from source
Author
|
This might require some additional update to docs maybe? |
Contributor
|
I build from master today, and I had no issues with the node.js version. @carlosdagos What's the error you're getting? |
Contributor
|
@chana1024 you're error looks like it's complaining about having not internet access. |
Author
|
Hey @chana1024, no that definitely was not the error I got 😄 @despairblue, I don't quite recall now which error exactly I got, but the current Node 10.x script contains the following deprecation warning Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Following the documented way to build from source using
docker fails because the version of Node used is deprecated.
Bumping to the currently supported version 12.x solves
the problem and allows building from source.
P.S.: Thank you for this project! :)