Repository navigation
Commit 7b0f4c8
committed
fix(tck): the mismatch matrix is eight rows, not eleven
The base branch's pin moves three of the matrix's Examples rows behind
`@string-typing`, so the outline it is read off is eight rows wide.
Only the row-identity test hardcoded the count, and it is the one place
that has to: `rows` comes from the message stream and `expected` from the
feature file, so without a literal the assertion would pass on two empty
lists. The literal is now 8, with a comment saying where the number comes
from so the next asset change has somewhere to look. The three
descriptions that said "eleven" follow it, including the README's, where
the sibling count moved too.
Nothing else in the report machinery counts rows -- the canonical total is
read from the assets and every other assertion derives its expectation
from the feature file, which is why one literal and three sentences is the
whole of it. `poe test` is 289 passed, 42 skipped, 2 xfailed, unchanged.
Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>1 parent bcc1fdc commit 7b0f4c8
2 files changed
Lines changed: 9 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
363 | 363 | | |
364 | 364 | | |
365 | 365 | | |
366 | | - | |
| 366 | + | |
367 | 367 | | |
368 | 368 | | |
369 | 369 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
| 86 | + | |
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| |||
669 | 669 | | |
670 | 670 | | |
671 | 671 | | |
672 | | - | |
| 672 | + | |
673 | 673 | | |
674 | 674 | | |
675 | 675 | | |
| |||
731 | 731 | | |
732 | 732 | | |
733 | 733 | | |
734 | | - | |
| 734 | + | |
735 | 735 | | |
736 | | - | |
| 736 | + | |
737 | 737 | | |
738 | 738 | | |
739 | 739 | | |
| |||
743 | 743 | | |
744 | 744 | | |
745 | 745 | | |
746 | | - | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
747 | 750 | | |
748 | 751 | | |
749 | 752 | | |
| |||
0 commit comments