Skip to content

Commit 95221ec

Browse files
committed
docs(ofrep): correct two tallies that reason.feature left behind
Running the suite to confirm this pass moved nothing found a count that had already moved and not been written down. `poe test-tck` is 2 failed, 45 passed, 17 skipped, 1 xfailed; `pyproject.toml` still said 2 / 37 / 16 / 1, which was true when this suite collected 56 scenarios and stopped being true when reason.feature took it to 65. The README already carried the right figure, so the two disagreed with each other as well as with the run. The @disabled-flags note quoted the same superseded run as its measurement of what declaring the tag would cost. The measurement stands -- all four rows fail, on the error code rather than the value -- so it is kept and dated rather than rewritten, with today's baseline beside it and the arithmetic said plainly: the same four rows move from skipped to failed. Same lesson as the three stale tallies the flagd suite carried a pass ago. A count in prose is a claim, it ages the moment the assets move, and the only thing that finds it is running the suite and comparing. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
1 parent 82d6642 commit 95221ec

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

‎providers/openfeature-provider-ofrep/pyproject.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ strict = true
8585
# linked from tools/openfeature-tck/README.md -- and is deliberately not
8686
# restated here.
8787
#
88-
# What is local to this package: a full run is 2 failed, 37 passed, 16 skipped,
88+
# What is local to this package: a full run is 2 failed, 45 passed, 17 skipped,
8989
# 1 xfailed. Both failures are canonical flags flagd-testbed does not seed yet,
9090
# and the xfail is the one genuine provider gap; tests/tck/conftest.py accounts
9191
# for them. Docker is not what decides the exclusion -- the flagd package's

‎providers/openfeature-provider-ofrep/tests/tck/test_ofrep_conformance.py‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,9 +163,12 @@
163163
# obstacle here.
164164
#
165165
# Measured first. Declaring the tag fails all four rows -- 6 failed, 37 passed,
166-
# 12 skipped, 1 xfailed, against the 2 failed of the run without it -- and each
167-
# fails on the error code rather than on the value: "error-code was 'GENERAL',
168-
# expected none". Then read back, and probed at the wire to be sure of the
166+
# 12 skipped, 1 xfailed at the time, against the 2 failed of the run without it
167+
# -- and each fails on the error code rather than on the value: "error-code was
168+
# 'GENERAL', expected none". That probe predates reason.feature, which took this
169+
# suite from 56 collected to 65; today's run without the tag is 2 failed, 45
170+
# passed, 17 skipped, 1 xfailed, and declaring it would move the same four rows
171+
# from skipped to failed. Then read back, and probed at the wire to be sure of the
169172
# reading. flagd's OFREP endpoint answers a disabled flag
170173
# `200 {"key": ..., "reason": "DISABLED", "metadata": {}}`: no `value`, and no
171174
# `variant`. The server does indeed never return a value, exactly as the

0 commit comments

Comments
 (0)