Skip to content

Commit a921b7a

Browse files
committed
test(flagd): the falsy flags were a naming gap, not a backend gap
The suite's note on what flagd-testbed does not serve was written against spec@15fe8611 and listed six missing flags. Three of them were never missing. spec@ba002ce8 renames them to boolean-zero-flag, integer-zero-flag and string-zero-flag, which is what flagd-testbed's own flags/zero-flags.json has called them all along, with the same zero/non-zero variants the scenarios assert. Verified against flagd-testbed v3.8.0: all three resolve with variant zero and reason STATIC on both resolvers. What remains genuinely unseeded is large-integer-flag, huge-integer-flag and integral-float-flag, so the note now names those three and lists only the two scenarios that still fail. The reasoning underneath is unchanged: the failures stay failures rather than xfails, because they say something true about the backend rather than about the provider. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
1 parent 8622d89 commit a921b7a

1 file changed

Lines changed: 12 additions & 8 deletions

File tree

  • providers/openfeature-provider-flagd/tests/tck

‎providers/openfeature-provider-flagd/tests/tck/conftest.py‎

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,12 @@
1414
``tests/e2e``.
1515
1616
**The testbed does not yet serve the whole canonical flag set.** The
17-
conformance assets at spec@15fe8611 added six flags -- ``false-flag``,
18-
``zero-flag``, ``empty-string-flag``, ``large-integer-flag``,
19-
``huge-integer-flag`` and ``integral-float-flag`` -- and flagd-testbed v3.8.0
20-
(``openfeature/test-harness/version.txt``) seeds none of them. Until
21-
open-feature/flagd-testbed catches up, both suites fail these scenarios with
22-
``FLAG_NOT_FOUND``, for every resolver alike:
23-
24-
* ``A falsy value is a value, not an absence`` -- three rows, untagged;
17+
conformance assets at spec@ba002ce8 ask for three flags that flagd-testbed
18+
v3.8.0 (``openfeature/test-harness/version.txt``) does not seed:
19+
``large-integer-flag``, ``huge-integer-flag`` and ``integral-float-flag``.
20+
Until open-feature/flagd-testbed catches up, both suites fail these scenarios
21+
with ``FLAG_NOT_FOUND``, for every resolver alike:
22+
2523
* ``A large integer resolves without loss of precision`` -- untagged;
2624
* ``An integer beyond 32 bits resolves without loss of precision`` -- under
2725
``@large-integers``, which both suites declare.
@@ -31,6 +29,12 @@
3129
failures are deliberately left as failures: they say something true about the
3230
stack under test, and an ``xfail`` would say the provider is at fault when it is
3331
the backend that is behind.
32+
33+
The falsy flags used to fail the same way and no longer do. ``ba002ce8`` renamed
34+
them to ``boolean-zero-flag``, ``integer-zero-flag`` and ``string-zero-flag``,
35+
which is what ``flags/zero-flags.json`` in the testbed has always called them,
36+
with the same ``zero``/``non-zero`` variants the scenarios assert. Those three
37+
rows were never a gap in the backend, only a disagreement about names.
3438
"""
3539

3640
from __future__ import annotations

0 commit comments

Comments
 (0)