Skip to content

Commit dd0d4b0

Browse files
committed
test(flagd): drop the PROVIDER_ERROR handler race in the deadline test
openfeature-sdk 0.10 dispatches event handlers on a thread pool, so the flag the handler set was not yet set when the test read it: CI failed test_grpc_sync_fail_deadline[500] on all five Python versions. pytest.raises(ProviderNotReadyError) carries the failed-init claim instead. The two files now match #434, which makes the same change. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
1 parent 32866a5 commit dd0d4b0

2 files changed

Lines changed: 10 additions & 14 deletions

File tree

‎providers/openfeature-provider-flagd/tests/test_errors.py‎

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,17 @@
88
from openfeature.contrib.provider.flagd import FlagdProvider
99
from openfeature.contrib.provider.flagd.config import ResolverType
1010
from openfeature.evaluation_context import EvaluationContext
11-
from openfeature.event import ProviderEvent
12-
from openfeature.exception import ErrorCode, OpenFeatureError
11+
from openfeature.exception import (
12+
ErrorCode,
13+
OpenFeatureError,
14+
ProviderNotReadyError,
15+
)
1316
from openfeature.flag_evaluation import Reason
1417

1518

1619
def create_client(provider: FlagdProvider):
17-
# Several of these files fail initialisation on purpose, which raises here.
20+
# These flag files are deliberately broken, so init may fail; what the
21+
# evaluation returns afterwards is the assertion.
1822
with contextlib.suppress(OpenFeatureError):
1923
api.set_provider_and_wait(provider)
2024
return api.get_client()
@@ -122,16 +126,8 @@ def test_flag_disabled():
122126

123127
@pytest.mark.parametrize("wait", (500, 250))
124128
def test_grpc_sync_fail_deadline(wait: int):
125-
init_failed = False
126-
127-
def fail(*args, **kwargs):
128-
nonlocal init_failed
129-
init_failed = True
130-
131-
api.get_client().add_handler(ProviderEvent.PROVIDER_ERROR, fail)
132-
133129
t = time.time()
134-
with pytest.raises(OpenFeatureError):
130+
with pytest.raises(ProviderNotReadyError):
135131
api.set_provider_and_wait(
136132
FlagdProvider(
137133
resolver_type=ResolverType.IN_PROCESS,
@@ -142,4 +138,3 @@ def fail(*args, **kwargs):
142138

143139
elapsed = time.time() - t
144140
assert abs(elapsed - wait * 0.001) < 0.17
145-
assert init_failed

‎providers/openfeature-provider-flagd/tests/test_metadata.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ def create_client(file_name):
2222
offline_flag_source_path=f"{path}/{file_name}",
2323
)
2424

25-
# The invalid-metadata files fail initialisation on purpose, which raises here.
25+
# Some of these flag files are deliberately broken, so init may fail; what
26+
# the evaluation returns afterwards is the assertion.
2627
with contextlib.suppress(OpenFeatureError):
2728
api.set_provider_and_wait(provider)
2829
return api.get_client()

0 commit comments

Comments
 (0)