Skip to content

fix(unleash): accept the arguments the client passes to track #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aepfli merged 1 commit into from
Nov 3, 2026
Merged

fix(unleash): accept the arguments the client passes to track #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions providers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,9 @@ def _unleash_event_callback(self, event: BaseEvent) -> None:

def track(
self,
event_name: str,
event_details: dict | None = None,
tracking_event_name: str,
evaluation_context: EvaluationContext | None = None,
tracking_event_details: Any = None,
) -> None:
"""No-op tracking method.

Expand Down
9 changes: 9 additions & 0 deletions providers/openfeature-provider-unleash/tests/test_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,15 @@ def test_unleash_provider_all_methods_implemented():
provider.shutdown()


def test_unleash_provider_track_takes_the_sdk_arguments():
"""The client calls track with three positional arguments; it must no-op."""
provider = UnleashProvider(
url="http://localhost:4242", app_name="test-app", api_token="test-token"
)

assert provider.track("event", EvaluationContext("user"), None) is None


def test_unleash_provider_hooks():
"""Test that UnleashProvider returns empty hooks list."""
provider = UnleashProvider(
Expand Down
Loading