Skip to content

chore: change lint PR title job to pull_request target - #678

Open
gruebel wants to merge 1 commit into
mainfrom
change-ci-target
Open

gruebel wants to merge 1 commit into
mainfrom
change-ci-target

Conversation

@gruebel

@gruebel gruebel commented Nov 10, 2026

Copy link
Copy Markdown
Member

Related Issues

Fixes #677

Signed-off-by: gruebel <anton.gruebel@gmail.com>
@gruebel
gruebel requested review from a team as code owners November 10, 2026 21:15
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The lint PR workflow now uses the pull_request event. Its configured opened, edited, and synchronize event types remain unchanged.

Changes: Lint PR workflow

Layer / File(s) Summary
Update workflow trigger
.github/workflows/lint-pr.yml
The workflow trigger changes from pull_request_target to pull_request. The configured event types remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: ajhelsby

Merge Risk: Minimal · up to 53aa1

The trigger change has no established blocking issue, though title validation on forked PRs remains unverified.

Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive Issue #677 requests replacing pull_request_target in workflows. The PR changes .github/workflows/lint-pr.yml to pull_request and keeps its event types. .github/workflows/build.yml already uses… Evidence of the trigger configured in .github/workflows/release.yml is needed to decide whether #677 is fully met.
Passed Passed checks: 4 passed

Check name Status Explanation
Title check Passed The title identifies the lint PR workflow and references the pull_request event, which is the main change. The wording “pull_request target” is ambiguous but still relates to the change.
Description check Passed The description says the pull request fixes issue #677, which requests switching workflows from pull_request_target to pull_request.
Out of Scope Changes check Passed The only change replaces the pull request event in .github/workflows/lint-pr.yml. This change directly implements issue #677. No unrelated changes appear in the whole-PR diff.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Linked Issues check

Explanation

Issue #677 requests replacing pull_request_target in workflows. The PR changes .github/workflows/lint-pr.yml to pull_request and keeps its event types. .github/workflows/build.yml already uses pull_request. I could not establish the trigger in .github/workflows/release.yml, so the available evidence does not show whether every relevant workflow meets the issue requirement.

Resolution

Evidence of the trigger configured in .github/workflows/release.yml is needed to decide whether #677 is fully met.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c492a765-da85-4fd4-ae86-7146332bdfec
Commits

Reviewing files that changed from the base of the PR and between f5b7df9 and 53aa1d5.

Files selected for processing: 1

  • .github/workflows/lint-pr.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.43%. Comparing base (f5b7df9) to head (53aa1d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files          45       45           
  Lines        2621     2621           
=======================================
  Hits         2580     2580           
  Misses         41       41           
Flag Coverage Δ
unittests 98.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: replace pull_request_target in workflows

1 participant