Skip to content

Commit 2a4b7d3

Browse files
committed
[CHORE] Name the path the test timeout is there for, and say what success means now
The bound guards the synchronous wiring cases, which wait on a completion. The asynchronous fake calls back from inside SendRequest() and Export() returns without waiting, so it is not what a stranded completion would hang. The changelog said an acknowledgement carries a 2xx status. It carries one that says the operation applied, which is a narrower thing, and the batch status it sits under is narrower still. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
1 parent 6d9f73c commit 2a4b7d3

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,10 @@ Increment the:
152152

153153
* [BUG] Decide Elasticsearch bulk export success from the HTTP status, the
154154
errors flag, and one acknowledgement per record that names its target index
155-
and carries a 2xx status
155+
and says the operation applied
156+
[#4297](https://github.com/open-telemetry/opentelemetry-cpp/pull/4297)
157+
* [BUG] Stop reading an Elasticsearch bulk response that only says the request
158+
was accepted as a batch that was written
156159
[#4297](https://github.com/open-telemetry/opentelemetry-cpp/pull/4297)
157160

158161
* [BUG] Make SocketAddr string parsing safe and reject malformed addresses

‎exporters/elasticsearch/CMakeLists.txt‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,9 @@ if(BUILD_TESTING)
6262
TEST_PREFIX exporter.
6363
TEST_LIST es_log_record_exporter_test)
6464

65-
# The asynchronous cases wait on a response that a regression can stop
66-
# delivering, and a case that hangs stops the job rather than reporting. A
67-
# bound turns that back into a red test.
65+
# The synchronous wiring cases wait on a completion, and a regression that
66+
# stops delivering one hangs the job rather than reporting. A bound turns that
67+
# back into a red test. Not the asynchronous ones: their fake calls back from
68+
# inside SendRequest() and Export() returns without waiting.
6869
set_tests_properties(${es_log_record_exporter_test} PROPERTIES TIMEOUT 120)
6970
endif() # BUILD_TESTING

0 commit comments

Comments
 (0)