Skip to content

Commit 5947bf6

Browse files
Merge branch 'main' into fix/4625-narrow-ext-headers
2 parents e064cf6 + 9a17af5 commit 5947bf6

22 files changed

Lines changed: 42 additions & 145 deletions

File tree

‎.devcontainer/Dockerfile.conan‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Copyright The OpenTelemetry Authors
22
# SPDX-License-Identifier: Apache-2.0
3-
FROM ubuntu:24.04@sha256:a853f94d226358a79c740cfc7bce0c289748f3fe3488d921d038ccd752c61b60
3+
FROM ubuntu:24.04@sha256:534baea6a22c03a63003dbc8dbe78fe34bc0d7e595d9a9dc9834884ff530eb55
44

55
RUN apt update && apt install -y \
66
build-essential \

‎.devcontainer/Dockerfile.dev‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Copyright The OpenTelemetry Authors
22
# SPDX-License-Identifier: Apache-2.0
33

4-
FROM ubuntu:24.04@sha256:a853f94d226358a79c740cfc7bce0c289748f3fe3488d921d038ccd752c61b60
4+
FROM ubuntu:24.04@sha256:534baea6a22c03a63003dbc8dbe78fe34bc0d7e595d9a9dc9834884ff530eb55
55

66
ARG USER_UID=1000
77
ARG USER_GID=1000

‎.github/workflows/publish-to-bcr.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
contents: write
2626
id-token: write
2727
attestations: write
28-
uses: bazel-contrib/publish-to-bcr/.github/workflows/publish.yaml@ca23149e55cd4db07a6bcce69c02dea314c5a357 # v1.5.0
28+
uses: bazel-contrib/publish-to-bcr/.github/workflows/publish.yaml@fa5bb3803983c621c90721669ee7857afe139836 # v1.5.1
2929
with:
3030
tag_name: ${{ inputs.tag_name || github.event.release.tag_name }}
3131
registry_fork: ${{ inputs.registry_fork || 'open-telemetry/bazel-central-registry' }}

‎CHANGELOG.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,9 @@ Breaking changes:
114114
* [BUG] Keep the curl retry deadline stable within each attempt
115115
[#4452](https://github.com/open-telemetry/opentelemetry-cpp/pull/4452)
116116

117+
* [REMOVAL] Remove WITH_OTLP_RETRY_PREVIEW - #4668
118+
[#4668](https://github.com/open-telemetry/opentelemetry-cpp/pull/4668)
119+
117120
## [1.29.0] 2026-09-13
118121

119122
* [RELEASE] Bump main branch to 1.29.0-dev (#4259)

‎CMakeLists.txt‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,6 @@ if(NOT OTELCPP_WITH_STL STREQUAL "OFF")
170170
endif()
171171
endif()
172172

173-
otelcpp_option_flag(OTELCPP_WITH_OTLP_RETRY_PREVIEW
174-
"Whether to enable retry functionality" ON)
175-
176173
otelcpp_option_flag(OTELCPP_WITH_OTLP_GRPC_SSL_MTLS_PREVIEW
177174
"Whether to enable mTLS support for gRPC" ON)
178175

@@ -639,8 +636,6 @@ message(
639636
STATUS
640637
"OTELCPP_WITH_OTLP_GRPC_CREDENTIAL_PREVIEW: ${OTELCPP_WITH_OTLP_GRPC_CREDENTIAL_PREVIEW}"
641638
)
642-
message(
643-
STATUS "OTELCPP_WITH_OTLP_RETRY_PREVIEW: ${OTELCPP_WITH_OTLP_RETRY_PREVIEW}")
644639
message(
645640
STATUS
646641
"OTELCPP_WITH_METRICS_BOUND_INSTRUMENTS_PREVIEW: ${OTELCPP_WITH_METRICS_BOUND_INSTRUMENTS_PREVIEW}"

‎DEPRECATED.md‎

Lines changed: 0 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ The following legacy CMake option names are deprecated:
9494
| `WITH_OTLP_GRPC_SSL_MTLS_PREVIEW` | `OTELCPP_WITH_OTLP_GRPC_SSL_MTLS_PREVIEW` |
9595
| `WITH_OTLP_HTTP` | `OTELCPP_WITH_OTLP_HTTP` |
9696
| `WITH_OTLP_HTTP_COMPRESSION` | `OTELCPP_WITH_OTLP_HTTP_COMPRESSION` |
97-
| `WITH_OTLP_RETRY_PREVIEW` | `OTELCPP_WITH_OTLP_RETRY_PREVIEW` |
9897
| `WITH_OTLP_UTF8_VALIDITY` | `OTELCPP_WITH_OTLP_UTF8_VALIDITY` |
9998
| `WITH_PROMETHEUS` | `OTELCPP_WITH_PROMETHEUS` |
10099
| `WITH_RESOURCE_DETECTORS_PREVIEW` | `OTELCPP_WITH_RESOURCE_DETECTORS_PREVIEW` |
@@ -119,54 +118,6 @@ both names are set, the `OTELCPP_` name takes precedence.
119118
The legacy CMake option names will be removed in a future release. The
120119
replacement names are not affected by this removal.
121120

122-
### CMake OTELCPP_WITH_OTLP_RETRY_PREVIEW
123-
124-
#### Announcement (OTELCPP_WITH_OTLP_RETRY_PREVIEW)
125-
126-
The CMake compile flag `OTELCPP_WITH_OTLP_RETRY_PREVIEW`, formerly named
127-
`WITH_OTLP_RETRY_PREVIEW`, is deprecated by:
128-
129-
* Enable WITH_OTLP_RETRY_PREVIEW by default
130-
[#3953](https://github.com/open-telemetry/opentelemetry-cpp/pull/3953)
131-
132-
#### Motivation (OTELCPP_WITH_OTLP_RETRY_PREVIEW)
133-
134-
Flags like `OTELCPP_WITH_OTLP_RETRY_PREVIEW` are used to conditionally compile
135-
new features when they are introduced in the code base.
136-
137-
Now that this feature is stable, conditional compilation is no longer
138-
necessary.
139-
140-
#### Scope (OTELCPP_WITH_OTLP_RETRY_PREVIEW)
141-
142-
Remove the `OTELCPP_WITH_OTLP_RETRY_PREVIEW` compilation flag and its legacy
143-
name `WITH_OTLP_RETRY_PREVIEW` from CMake.
144-
145-
Remove the `ENABLE_OTLP_RETRY_PREVIEW` preprocessor condition from C++.
146-
147-
#### Mitigation (OTELCPP_WITH_OTLP_RETRY_PREVIEW)
148-
149-
Applications built with `OTELCPP_WITH_OTLP_RETRY_PREVIEW=ON` or
150-
`WITH_OTLP_RETRY_PREVIEW=ON` need to:
151-
152-
* remove the preview flag from CMake scripts
153-
154-
Applications built with `OTELCPP_WITH_OTLP_RETRY_PREVIEW=OFF` or
155-
`WITH_OTLP_RETRY_PREVIEW=OFF` need to:
156-
157-
* remove the preview flag from CMake scripts
158-
* use `retry_policy_max_attempts` = 0 in the OTLP exporter options.
159-
160-
For Bazel, no compilation option exists,
161-
the bazel build enables unconditionally ENABLE_OTLP_RETRY_PREVIEW.
162-
163-
Make sure to properly initialize `retry_policy_max_attempts`
164-
to enable or disable the retry feature.
165-
166-
#### Planned removal (OTELCPP_WITH_OTLP_RETRY_PREVIEW)
167-
168-
This compilation flag will be removed after October 1st, 2026.
169-
170121
### CMake OTELCPP_WITH_OTLP_GRPC_SSL_MTLS_PREVIEW
171122

172123
#### Announcement (OTELCPP_WITH_OTLP_GRPC_SSL_MTLS_PREVIEW)

‎api/CMakeLists.txt‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,6 @@ if(OTELCPP_WITH_METRICS_BOUND_INSTRUMENTS_PREVIEW)
8787
INTERFACE ENABLE_METRICS_BOUND_INSTRUMENTS_PREVIEW)
8888
endif()
8989

90-
if(OTELCPP_WITH_OTLP_RETRY_PREVIEW)
91-
target_compile_definitions(opentelemetry_api
92-
INTERFACE ENABLE_OTLP_RETRY_PREVIEW)
93-
else()
94-
message(WARNING "OTELCPP_WITH_OTLP_RETRY_PREVIEW=OFF is deprecated")
95-
endif()
96-
9790
if(OTELCPP_WITH_OTLP_GRPC_SSL_MTLS_PREVIEW)
9891
target_compile_definitions(opentelemetry_api
9992
INTERFACE ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW)

‎ci/do_ci.ps1‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,6 @@ switch ($action) {
554554
-DOTELCPP_WITH_OPENTRACING=OFF `
555555
-DOTELCPP_WITH_OTLP_GRPC_SSL_MTLS_PREVIEW=OFF `
556556
-DOTELCPP_WITH_OTLP_GRPC_CREDENTIAL_PREVIEW=OFF `
557-
-DOTELCPP_WITH_OTLP_RETRY_PREVIEW=OFF `
558557
-DOTELCPP_WITH_OTLP_GRPC=OFF `
559558
-DOTELCPP_WITH_OTLP_HTTP=OFF `
560559
-DOTELCPP_WITH_OTLP_FILE=OFF `

‎ci/do_ci.sh‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,6 @@ elif [[ "$1" == "cmake.maintainer.yaml.test" ]]; then
176176
-DOTELCPP_MAINTAINER_MODE=ON \
177177
-DOTELCPP_WITH_NO_DEPRECATED_CODE=ON \
178178
-DOTELCPP_WITH_OTLP_HTTP_COMPRESSION=ON \
179-
-DOTELCPP_WITH_OTLP_RETRY_PREVIEW=ON \
180179
-DOTELCPP_WITH_THREAD_INSTRUMENTATION_PREVIEW=ON \
181180
-DOTELCPP_WITH_CONFIGURATION=ON \
182181
-DOTELCPP_WITH_RESOURCE_DETECTORS_PREVIEW=ON \
@@ -402,7 +401,6 @@ elif [[ "$1" == "cmake.exporter.otprotocol.test" ]]; then
402401
-DOTELCPP_WITH_OTLP_FILE=ON \
403402
-DOTELCPP_WITH_OTLP_GRPC_SSL_MTLS_PREVIEW=ON \
404403
-DOTELCPP_WITH_OTLP_GRPC_CREDENTIAL_PREVIEW=ON \
405-
-DOTELCPP_WITH_OTLP_RETRY_PREVIEW=ON \
406404
"${SRC_DIR}"
407405
cmake --build . "${CMAKE_BUILD_ARGS[@]}"
408406
ctest --output-on-failure
@@ -587,7 +585,6 @@ elif [[ "$1" == "cmake.legacy_options.test" ]]; then
587585
-DWITH_NO_DEPRECATED_CODE=ON \
588586
-DWITH_STL=ON \
589587
-DWITH_GSL=ON \
590-
-DWITH_OTLP_RETRY_PREVIEW=OFF \
591588
-DWITH_OTLP_GRPC_SSL_MTLS_PREVIEW=OFF \
592589
-DWITH_OTLP_GRPC_CREDENTIAL_PREVIEW=ON \
593590
-DWITH_OTLP_GRPC=ON \
@@ -625,7 +622,6 @@ elif [[ "$1" == "cmake.legacy_options.test" ]]; then
625622
WITH_NO_DEPRECATED_CODE \
626623
WITH_STL \
627624
WITH_GSL \
628-
WITH_OTLP_RETRY_PREVIEW \
629625
WITH_OTLP_GRPC_SSL_MTLS_PREVIEW \
630626
WITH_OTLP_GRPC_CREDENTIAL_PREVIEW \
631627
WITH_OTLP_GRPC \
@@ -667,7 +663,6 @@ elif [[ "$1" == "cmake.legacy_options.test" ]]; then
667663
"OTELCPP_WITH_NO_DEPRECATED_CODE:BOOL=ON" \
668664
"OTELCPP_WITH_STL:STRING=ON" \
669665
"OTELCPP_WITH_GSL:BOOL=ON" \
670-
"OTELCPP_WITH_OTLP_RETRY_PREVIEW:BOOL=OFF" \
671666
"OTELCPP_WITH_OTLP_GRPC_SSL_MTLS_PREVIEW:BOOL=OFF" \
672667
"OTELCPP_WITH_OTLP_GRPC_CREDENTIAL_PREVIEW:BOOL=ON" \
673668
"OTELCPP_WITH_OTLP_GRPC:BOOL=ON" \

‎cmake/tools.cmake‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,8 +353,6 @@ set(_otelcpp_legacy_option_name_OTELCPP_WITH_OTLP_GRPC_SSL_MTLS_PREVIEW
353353
set(_otelcpp_legacy_option_name_OTELCPP_WITH_OTLP_HTTP "WITH_OTLP_HTTP")
354354
set(_otelcpp_legacy_option_name_OTELCPP_WITH_OTLP_HTTP_COMPRESSION
355355
"WITH_OTLP_HTTP_COMPRESSION")
356-
set(_otelcpp_legacy_option_name_OTELCPP_WITH_OTLP_RETRY_PREVIEW
357-
"WITH_OTLP_RETRY_PREVIEW")
358356
set(_otelcpp_legacy_option_name_OTELCPP_WITH_OTLP_UTF8_VALIDITY
359357
"WITH_OTLP_UTF8_VALIDITY")
360358
set(_otelcpp_legacy_option_name_OTELCPP_WITH_PROMETHEUS "WITH_PROMETHEUS")

0 commit comments

Comments
 (0)