Repository navigation
Commit 7974443
committed
[TEST] Name every constructor argument in the new cases
HttpOperation keeps references to its ssl options, headers, body, compression and
retry policy. The short constructor form materialises the defaulted ones as
temporaries that die at the end of the full expression, and Setup() reads them
from inside Send(): the Bazel asan job reported stack-use-after-scope in
HttpOperation::Setup() with the frame belonging to the case.
RetryPolicyEnabled in this file passes all twelve by name for that reason. The
case I patterned on, RetryJitterIsNotSharedAcrossThreads, uses the short form and
never calls Send(), so it never sees it.
Verified with bazel test --config=asan on the same target: no sanitizer report,
and the new cases run.
Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>1 parent 4a89489 commit 7974443
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
514 | 514 | | |
515 | 515 | | |
516 | 516 | | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
517 | 522 | | |
518 | | - | |
| 523 | + | |
| 524 | + | |
519 | 525 | | |
520 | 526 | | |
521 | 527 | | |
| |||
0 commit comments