Skip to content

Commit 828b322

Browse files
committed
[CHORE] Say in the changelog that the unsynchronized callback marker is gone
AsyncData::callback_thread is on main today, read and written from two threads with nothing ordering them and with both accessors marked no-thread-sanitizer, so removing it is a fix a user of the released client gets rather than something internal to this branch. The use after free this branch also fixes is not listed, because the code it lives in does not exist outside this branch and a changelog entry would claim a repair to something that never shipped. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
1 parent f317b90 commit 828b322

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,10 @@ Increment the:
123123
including the ones the IO thread delivers, instead of waiting on a completion
124124
only that thread goes on to publish
125125
([#4395](https://github.com/open-telemetry/opentelemetry-cpp/pull/4395))
126+
* [BUG] Decide whether a curl thread is inside a callback without an
127+
unsynchronized member, which was read and written from two threads behind a
128+
sanitizer suppression
129+
([#4395](https://github.com/open-telemetry/opentelemetry-cpp/pull/4395))
126130
* [CODE HEALTH] Enable clang-tidy `modernize-deprecated-headers` and replace
127131
deprecated C headers (`stdint.h`, `stddef.h`, `stdlib.h`, `string.h`,
128132
`stdio.h`, `ctype.h`, `limits.h`, `assert.h`) with their C++ equivalents

0 commit comments

Comments
 (0)