Skip to content

Commit 93aa377

Browse files
authored
[CONFIGURATION/TEST] SdkBuilder test separation and expansion by provider type (#4441)
1 parent 84fe660 commit 93aa377

15 files changed

Lines changed: 4183 additions & 1840 deletions

‎sdk/test/configuration/BUILD‎

Lines changed: 27 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ cc_test(
2626
cc_test(
2727
name = "sdk_builder_test",
2828
srcs = [
29-
"config_test_common.h",
3029
"sdk_builder_test.cc",
3130
],
3231
tags = [
@@ -48,7 +47,9 @@ cc_test(
4847
cc_test(
4948
name = "configured_sdk_test",
5049
srcs = [
51-
"config_test_common.h",
50+
"config_test_logs.h",
51+
"config_test_metrics.h",
52+
"config_test_trace.h",
5253
"configured_sdk_test.cc",
5354
],
5455
tags = [
@@ -69,7 +70,10 @@ cc_test(
6970
cc_test(
7071
name = "programmatic_configuration_test",
7172
srcs = [
72-
"config_test_common.h",
73+
"config_test_logs.h",
74+
"config_test_metrics.h",
75+
"config_test_propagators.h",
76+
"config_test_trace.h",
7377
"programmatic_configuration_test.cc",
7478
],
7579
tags = [
@@ -90,6 +94,7 @@ cc_test(
9094
cc_test(
9195
name = "trace_builders_test",
9296
srcs = [
97+
"config_test_trace.h",
9398
"trace_builders_test.cc",
9499
],
95100
tags = [
@@ -107,6 +112,7 @@ cc_test(
107112
cc_test(
108113
name = "logs_builders_test",
109114
srcs = [
115+
"config_test_logs.h",
110116
"logs_builders_test.cc",
111117
],
112118
tags = [
@@ -124,6 +130,7 @@ cc_test(
124130
cc_test(
125131
name = "metrics_builders_test",
126132
srcs = [
133+
"config_test_metrics.h",
127134
"metrics_builders_test.cc",
128135
],
129136
tags = [
@@ -134,6 +141,23 @@ cc_test(
134141
"//sdk:headers",
135142
"//sdk/src/configuration:configuration_metrics_builders",
136143
"//sdk/src/metrics",
144+
"//test_common:headers",
145+
"@com_google_googletest//:gtest_main",
146+
],
147+
)
148+
149+
cc_test(
150+
name = "propagator_builders_test",
151+
srcs = [
152+
"propagator_builders_test.cc",
153+
],
154+
tags = [
155+
"config",
156+
"test",
157+
],
158+
deps = [
159+
"//sdk:headers",
160+
"//sdk/src/configuration:configuration_core",
137161
"@com_google_googletest//:gtest_main",
138162
],
139163
)

‎sdk/test/configuration/CMakeLists.txt‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,22 @@ target_link_libraries(
3737
metrics_builders_test
3838
PRIVATE ${GTEST_BOTH_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT}
3939
opentelemetry_configuration_metrics_builders
40-
opentelemetry_configuration_core)
40+
opentelemetry_configuration_core opentelemetry_test_common)
4141
gtest_add_tests(
4242
TARGET metrics_builders_test
4343
TEST_PREFIX config.
4444
TEST_LIST metrics_builders_test)
4545

46+
add_executable(propagator_builders_test propagator_builders_test.cc)
47+
target_link_libraries(
48+
propagator_builders_test
49+
PRIVATE ${GTEST_BOTH_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT}
50+
opentelemetry_configuration_core)
51+
gtest_add_tests(
52+
TARGET propagator_builders_test
53+
TEST_PREFIX config.
54+
TEST_LIST propagator_builders_test)
55+
4656
foreach(testname sdk_builder_test configured_sdk_test
4757
programmatic_configuration_test)
4858
add_executable(${testname} "${testname}.cc")

0 commit comments

Comments
 (0)