Skip to content

Commit 9d38caf

Browse files
authored
[CODE HEALTH] Fix remaining misc-override-with-different-visibility warnings (#4280)
1 parent de8fa51 commit 9d38caf

4 files changed

Lines changed: 8 additions & 4 deletions

File tree

‎.github/workflows/clang-tidy.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ jobs:
1717
matrix:
1818
include:
1919
- cmake_options: all-options-abiv1-preview
20-
warning_limit: 156
20+
warning_limit: 151
2121
- cmake_options: all-options-abiv2-preview
22-
warning_limit: 166
22+
warning_limit: 161
2323
env:
2424
CC: /usr/bin/clang-22
2525
CXX: /usr/bin/clang++-22

‎CHANGELOG.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ Increment the:
4444
that do not receive explicit SpanLimits
4545
[#4258](https://github.com/open-telemetry/opentelemetry-cpp/pull/4258)
4646

47+
* [CODE HEALTH] Fix remaining misc-override-with-different-visibility warnings
48+
[#4280](https://github.com/open-telemetry/opentelemetry-cpp/pull/4280)
49+
4750
Breaking changes:
4851

4952
* [METRICS SDK] Rename Base2 Exponential Histogram Aggregation config field

‎ext/include/opentelemetry/ext/http/server/http_server.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ class HttpServer : private SocketTools::Reactor::SocketCallback
244244

245245
void stop() { m_reactor.stop(); }
246246

247-
protected:
247+
private:
248248
void onSocketAcceptable(SocketTools::Socket socket) override
249249
{
250250
LOG_TRACE("HttpServer: accepting socket fd=0x%llx", socket.m_sock);
@@ -331,6 +331,7 @@ class HttpServer : private SocketTools::Reactor::SocketCallback
331331
handleConnectionClosed(conn);
332332
}
333333

334+
protected:
334335
bool sendMore(Connection &conn)
335336
{
336337
if (conn.sendBuffer.empty())
@@ -356,7 +357,6 @@ class HttpServer : private SocketTools::Reactor::SocketCallback
356357
return false;
357358
}
358359

359-
protected:
360360
void handleConnectionClosed(Connection &conn)
361361
{
362362
LOG_TRACE("HttpServer: [%s] closed", conn.request.client.c_str());

‎ext/include/opentelemetry/ext/http/server/socket_tools.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -717,6 +717,7 @@ struct Reactor : protected common::Thread
717717
m_sockets.clear();
718718
}
719719

720+
protected:
720721
/// <summary>
721722
/// Thread Loop for async events processing
722723
/// </summary>

0 commit comments

Comments
 (0)