Skip to content

Commit af87c0a

Browse files
[BUILD] Fix duplicate implementation_deps in curl BUILD
Remove the first duplicate implementation_deps block and the misplaced reference to curl_implementation_headers in regular deps. Keep only the correctly-placed implementation_deps at the end with the target exposed to the internal curl implementation only, preventing transitive exposure to dependents.
1 parent 3f95ef1 commit af87c0a

1 file changed

Lines changed: 1 addition & 11 deletions

File tree

  • ext/src/http/client/curl

‎ext/src/http/client/curl/BUILD‎

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,6 @@ cc_library(
1717
"ENABLE_HTTP_CLIENT_CURL",
1818
"ENABLE_OTLP_RETRY_PREVIEW",
1919
],
20-
# Implementation headers are not exposed in the public API, so they are
21-
# declared as implementation_deps to prevent transitive dependents from
22-
# accessing curl internals. Only the .cc files (via srcs) see these headers.
23-
implementation_deps = [
24-
"//ext:curl_implementation_headers",
25-
],
2620
include_prefix = "src/http/client/curl",
2721
linkopts = select({
2822
"//bazel:windows": [
@@ -36,17 +30,13 @@ cc_library(
3630
linkstatic = True,
3731
deps = [
3832
"//api",
39-
"//ext:curl_implementation_headers",
4033
"//ext:headers",
4134
"//sdk:headers",
4235
"//sdk/src/common:random",
4336
"@curl",
4437
"@zlib",
4538
],
46-
# Implementation headers are not exposed in the public API, so they are
47-
# declared as implementation_deps to prevent transitive dependents from
48-
# accessing curl internals. Only the .cc files (via srcs) see these headers.
4939
implementation_deps = [
50-
":implementation_headers",
40+
"//ext:curl_implementation_headers",
5141
],
5242
)

0 commit comments

Comments
 (0)