Skip to content

Commit c8a6715

Browse files
committed
[CHORE] Say in the contract what the statuses now have to be
The @return still described the 2xx band on both the request and the operation, which is what the code stopped accepting. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
1 parent 2a4b7d3 commit c8a6715

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

  • exporters/elasticsearch/include/opentelemetry/exporters/elasticsearch/detail

‎exporters/elasticsearch/include/opentelemetry/exporters/elasticsearch/detail/es_bulk_response.h‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@ inline bool IsAcknowledgedStatus(const nlohmann::json &status) noexcept
6969
* @param body the raw response body
7070
* @param expected_items the number of index operations the request submitted
7171
* @param failure_reason a best-effort explanation when this returns false
72-
* @return true only when the status is 2xx, "errors" is false, and "items" holds exactly
73-
* expected_items index results that each name a target index, acknowledge a 2xx status
74-
* and carry no error
72+
* @return true only when the status is 200, "errors" is false, and "items" holds exactly
73+
* expected_items index results that each name a target index, acknowledge a status the
74+
* operation applied under, and carry no error
7575
*/
7676
inline bool IsBulkResponseSuccessful(int status_code,
7777
const std::string &body,

0 commit comments

Comments
 (0)