Repository navigation
Commit f930429
committed
[TEST] Say that the overlapping callbacks are a record, not a contract
The case asserts that two callbacks are inside the handler at once, which
is what this client does today. EventHandler does not say whether one
request's callbacks can overlap, so a handler written against the
interface is not obliged to be re-entrant, and an assertion that reads
like a promise is the wrong thing to leave behind.
The number stays, because reaching that overlap is the point of the case
and a client that began serialising callbacks per operation should be
noticed rather than absorbed. The comment now says which of the two it
is.
32 tests pass.
Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>1 parent 964eed9 commit f930429
1 file changed
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
942 | 942 | | |
943 | 943 | | |
944 | 944 | | |
| 945 | + | |
| 946 | + | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
945 | 951 | | |
946 | 952 | | |
947 | 953 | | |
| |||
0 commit comments