Repository navigation
[SDK] Remove TracerConfig copy from Tracer - #4712
Merged
marcalff merged 4 commits intoOct 18, 2026
Merged
Conversation
dbarker
marked this pull request as ready for review
October 17, 2026 19:29
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4712 +/- ##
==========================================
- Coverage 86.81% 86.81% -0.00%
==========================================
Files 525 525
Lines 20741 20736 -5
==========================================
- Hits 18005 18000 -5
Misses 2736 2736
🚀 New features to boost your workflow:
|
dbarker
changed the title
mateenali66
reviewed
Oct 17, 2026
mateenali66
left a comment
mateenali66
left a comment
Member
There was a problem hiding this comment.
the copy was write-only, and every write to it already happens under the provider's lock_. tsan is clean on UpdateTracerConfiguratorConcurrentStartSpan over 50 runs, and it merges cleanly with #4710.
small thing, sdk/include/opentelemetry/sdk/trace/tracer.h:9 still includes <mutex>, which nothing in the header uses now. everything builds with it removed.
mateenali66
approved these changes
Oct 18, 2026
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Oct 18, 2026
[SDK] Remove TracerConfig copy from Tracer (open-telemetry#4712)
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
The SDK Tracer maintains an unnecessary TracerConfig copy and related mutex. These can be removed to save resource usage.
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes