Skip to content

[CODE HEALTH] Fix misc-use-internal-linkage warning - #4724

Merged
marcalff merged 1 commit into
open-telemetry:mainfrom
marcalff:tidy_warning
Oct 22, 2026
Merged

marcalff merged 1 commit into
open-telemetry:mainfrom
marcalff:tidy_warning

Conversation

@marcalff

@marcalff marcalff commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

  • Fix the last misc-use-internal-linkage warning
  • Adjust warning count in CI to current count

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff
marcalff requested a review from a team as a code owner October 22, 2026 11:07
@marcalff marcalff added the pr:please-review This PR is ready for review label Oct 22, 2026
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.63%. Comparing base (1c310d4) to head (7f5b4d1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4724      +/-   ##
==========================================
- Coverage   86.64%   86.63%   -0.00%     
==========================================
  Files         527      527              
  Lines       20830    20830              
==========================================
- Hits        18047    18045       -2     
- Misses       2783     2785       +2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@marcalff
marcalff merged commit d3785b4 into open-telemetry:main Oct 22, 2026
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants