Repository navigation
[CI] Upgrade to macos-15 - #4756
Conversation
mateenali66
left a comment
There was a problem hiding this comment.
Thanks for the fix.
The zlib bump works, the macOS conan job now gets past zlib and fails in grpc/1.54.3 instead:
src/core/lib/promise/detail/basic_seq.h:474:38: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
ERROR: grpc/1.54.3: Error in build() method, line 269
This is Xcode 16.4 (Apple clang 17) rejecting Traits::template CallSeqFactory(...).
grpc fixed it in 1.65.0 (grpc/grpc#36805), and conan center has 1.69.0 and 1.84.0.
Bumping grpc in conanfile_stable.txt also moves the Ubuntu 24.04 stable job, which passes on main with 1.54.3.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4756 +/- ##
==========================================
- Coverage 86.62% 86.61% -0.00%
==========================================
Files 530 530
Lines 21169 21169
==========================================
- Hits 18335 18333 -2
- Misses 2834 2836 +2 🚀 New features to boost your workflow:
|
mateenali66
left a comment
There was a problem hiding this comment.
LGTM, thanks for the upgrade.
The macOS conan stable job now builds grpc 1.84.0 with AppleClang 17 and passes all tests.
mateenali66
left a comment
There was a problem hiding this comment.
LGTM, thanks for the upgrade.
The macOS conan stable job now builds grpc 1.84.0 with AppleClang 17 and passes all tests.
Fixes # (issue)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes