Skip to content

[CI] Upgrade to macos-15 - #4756

Merged
marcalff merged 7 commits into
open-telemetry:mainfrom
marcalff:fix_ci_macos
Nov 1, 2026
Merged

marcalff merged 7 commits into
open-telemetry:mainfrom
marcalff:fix_ci_macos

Conversation

@marcalff

@marcalff marcalff commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff
marcalff requested a review from a team as a code owner October 31, 2026 21:36

@mateenali66 mateenali66 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

The zlib bump works, the macOS conan job now gets past zlib and fails in grpc/1.54.3 instead:

src/core/lib/promise/detail/basic_seq.h:474:38: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
ERROR: grpc/1.54.3: Error in build() method, line 269

This is Xcode 16.4 (Apple clang 17) rejecting Traits::template CallSeqFactory(...).

grpc fixed it in 1.65.0 (grpc/grpc#36805), and conan center has 1.69.0 and 1.84.0.

Bumping grpc in conanfile_stable.txt also moves the Ubuntu 24.04 stable job, which passes on main with 1.54.3.

@codecov

codecov Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.61%. Comparing base (88dea80) to head (341aa2f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4756      +/-   ##
==========================================
- Coverage   86.62%   86.61%   -0.00%     
==========================================
  Files         530      530              
  Lines       21169    21169              
==========================================
- Hits        18335    18333       -2     
- Misses       2834     2836       +2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff added issue:blocking This issue is preventing other fixes pr:please-review This PR is ready for review labels Nov 1, 2026

@mateenali66 mateenali66 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the upgrade.

The macOS conan stable job now builds grpc 1.84.0 with AppleClang 17 and passes all tests.

@mateenali66 mateenali66 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the upgrade.

The macOS conan stable job now builds grpc 1.84.0 with AppleClang 17 and passes all tests.

@marcalff
marcalff merged commit 8d540d1 into open-telemetry:main Nov 1, 2026
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue:blocking This issue is preventing other fixes pr:please-review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants