[Resources.AWS] Add host.image.id for EC2 - #5110
Open
martincostello wants to merge 1 commit into
Open
Conversation
Add `host.image.id` to the AWS EC2 resource detector. Contributes to open-telemetry#1516.
github-actions
Bot
added
the
comp:resources.aws
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5110 +/- ##
==========================================
- Coverage 77.97% 77.90% -0.08%
==========================================
Files 477 477
Lines 20395 20396 +1
==========================================
- Hits 15904 15890 -14
- Misses 4491 4506 +15 Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the recommended host.image.id resource attribute to the AWS EC2 detector using the AMI ID from the instance identity document.
Changes:
- Deserializes and emits the EC2
imageId. - Updates semantic conventions, tests, documentation, and changelog.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
test/OpenTelemetry.Resources.AWS.Tests/SampleAWSEC2IdentityDocumentModel.cs |
Adds sample image ID data. |
test/OpenTelemetry.Resources.AWS.Tests/AWSEC2DetectorTests.cs |
Verifies deserialization and emitted attribute. |
src/Shared/AWS/AWSSemanticConventions.Legacy.cs |
Defines the legacy attribute key. |
src/Shared/AWS/AWSSemanticConventions.cs |
Adds the attribute builder method. |
src/Shared/AWS/AWSSemanticConventions.Base.cs |
Adds the base semantic-convention property. |
src/OpenTelemetry.Resources.AWS/README.md |
Documents the new EC2 metadata. |
src/OpenTelemetry.Resources.AWS/Models/AWSEC2IdentityDocumentModel.cs |
Maps the EC2 imageId field. |
src/OpenTelemetry.Resources.AWS/CHANGELOG.md |
Records the behavioral change. |
src/OpenTelemetry.Resources.AWS/AWSEC2Detector.cs |
Emits host.image.id. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
martincostello
marked this pull request as ready for review
August 22, 2026 16:10
martincostello
enabled auto-merge
August 22, 2026 16:10
Pull request dashboard statusWaiting on maintainers · refreshed 2026-09-01 07:14 UTC Merge when ready. Status above doesn't look right?
|
matt-hensley
approved these changes
Aug 24, 2026
martincostello
added
the
keep-open
Kielek
approved these changes
Sep 1, 2026
Kielek
disabled auto-merge
September 1, 2026 06:40
Member
|
LGTM, but I would wait for some review from AWS component owners. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #1516
Changes
Add the recommended
host.image.idattribute to the AWS EC2 resource detector.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)