stdoutmetric: Preserve input when removing timestamps - #8843
Open
Sakshamm-Goyal wants to merge 2 commits into
Open
stdoutmetric: Preserve input when removing timestamps#8843Sakshamm-Goyal wants to merge 2 commits into
Sakshamm-Goyal wants to merge 2 commits into
Conversation
Sakshamm-Goyal
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
August 23, 2026 11:20
|
Contributor
|
@Sakshamm-Goyal please sign the CLA so these changes can be considered. |
MrAlias
added
the
blocked:CLA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8785.
WithoutTimestampsnow redacts a structural copy for encoding instead of replacing aggregation data in the caller-providedResourceMetrics. The copy preserves nil slice semantics while reusing the existing timestamp-redaction logic.Adds a regression test that exports a gauge and verifies its original start and end timestamps remain unchanged.
Validation:
go test . -run '^TestWithoutTimestampsDoesNotMutateInput$' -count=1\n-go test ./...inexporters/stdout/stdoutmetric\n-make precommit