otlptracegrpc: fix env endpoint URL parsing - #8852
Open
RedZapdos123 wants to merge 10 commits into
Open
Conversation
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
RedZapdos123
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
August 24, 2026 15:57
…-endpoint-path Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
…h' into fix-otlptracegrpc-env-endpoint-path Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8852 +/- ##
=====================================
Coverage 88.4% 88.4%
=====================================
Files 331 331
Lines 21001 21011 +10
=====================================
+ Hits 18572 18584 +12
+ Misses 2429 2427 -2
🚀 New features to boost your workflow:
|
MrAlias
reviewed
Aug 24, 2026
MrAlias
left a comment
MrAlias
left a comment
Contributor
There was a problem hiding this comment.
The core conversion is sound: HTTP(S) URLs are reduced to their authority while gRPC-native targets such as unix:///... are preserved, and the generated copies match the shared templates.
…8852 Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
MrAlias
approved these changes
Aug 25, 2026
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
…nv-endpoint-path Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com> # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Issue #7831 reported that
OTEL_EXPORTER_OTLP_ENDPOINTandOTEL_EXPORTER_OTLP_TRACES_ENDPOINTcould build an invalid gRPC target when configured with an HTTP(S) URL that included a path.Current
mainjoined the URL host and path for gRPC env configuration, so values such ashttp://127.0.0.1:1/v1/tracesbecame127.0.0.1:1/v1/tracesand failed withlookup tcp/...: unknown port.This PR updates OTLP trace gRPC env parsing to ignore HTTP(S) paths when deriving the gRPC endpoint target, while preserving non-HTTP targets such as
unix:///tmp/otel.sock.It also adds regression tests that cover base and signal-specific env endpoints with paths, and a unix target case.
Closes #7831.
Verifications:
cd exporters/otlp/otlptrace/otlptracegrpc && go test ./... -count=1cd exporters/otlp/otlptrace/otlptracehttp && go test ./... -count=1cd exporters/otlp/otlptrace/otlptracegrpc && golangci-lint run ./...cd exporters/otlp/otlptrace/otlptracehttp && golangci-lint run ./...