sdk/trace: treat empty sampler env values as unset - #8873
Open
RedZapdos123 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
RedZapdos123
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
August 26, 2026 05:23
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8873 +/- ##
=====================================
Coverage 88.4% 88.4%
=====================================
Files 331 331
Lines 21001 21000 -1
=====================================
+ Hits 18572 18577 +5
+ Misses 2429 2423 -6
🚀 New features to boost your workflow:
|
MrAlias
approved these changes
Aug 26, 2026
pellared
approved these changes
Aug 26, 2026
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
…pler-env Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com> # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Issue #8870 reported that empty
OTEL_TRACES_SAMPLERandOTEL_TRACES_SAMPLER_ARGvalues were not treated the same as unset values insdk/trace.Current
mainstill fell back to the effective default sampler behavior but it also emitted configuration errors for empty values because sampler env parsing treated empty strings as present values.This PR treats trimmed empty sampler env values as unset and adds regression tests covering empty
OTEL_TRACES_SAMPLERand emptyOTEL_TRACES_SAMPLER_ARGvalues.Closes #8870.
Verifications:
cd sdk/trace && go test . -run "TestTracerProviderSamplerConfigFromEnv(EmptyValues)?$" -count=1 -v.cd sdk/trace && go test . -count=1.cd sdk/trace && go test ./... -count=1.