Skip to content

fix(sdk/trace): guard Shutdown against nil exporter #8901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AruneshDwivedi wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −1
Open

fix(sdk/trace): guard Shutdown against nil exporter #8901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bc5251
fix(sdk/trace): guard Shutdown against nil exporter
AruneshDwivedi Aug 30, 2026
a760176
fix: scope ssp variable for nil-exporter shutdown test
AruneshDwivedi Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdk/trace/simple_span_processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ func (ssp *simpleSpanProcessor) OnEnd(s ReadOnlySpan) {

// Shutdown shuts down the exporter this SimpleSpanProcessor exports to.
func (ssp *simpleSpanProcessor) Shutdown(ctx context.Context) error {
if ssp.exporter == nil {

@dashpole dashpole Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading ssp.exporter here without acquiring ssp.exporterMu can lead to a data race with concurrent calls. Consider moving the nil check inside stopOnce.Do after acquiring ssp.exporterMu (e.g. returning early if exp == nil).

return nil
}
var err error
ssp.stopOnce.Do(func() {
stopFunc := func(exp SpanExporter) (<-chan error, func()) {
Expand Down
6 changes: 5 additions & 1 deletion sdk/trace/simple_span_processor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,13 @@ func TestNewSimpleSpanProcessor(t *testing.T) {
}

func TestNewSimpleSpanProcessorWithNilExporter(t *testing.T) {
if ssp := NewSimpleSpanProcessor(nil); ssp == nil {
ssp := NewSimpleSpanProcessor(nil)
if ssp == nil {
t.Error("failed to create new SimpleSpanProcessor with nil exporter")
}
if err := ssp.Shutdown(t.Context()); err != nil {
t.Errorf("Shutdown with nil exporter should return nil, got %v", err)
}
}

func TestSimpleSpanProcessorOnEnd(t *testing.T) {
Expand Down
Loading