fix(sdk/metric): keep distinct streams when overflow attribute exists - #8903
Open
lllakshit wants to merge 1 commit into
Open
fix(sdk/metric): keep distinct streams when overflow attribute exists#8903lllakshit wants to merge 1 commit into
lllakshit wants to merge 1 commit into
Conversation
Exponential histogram aggregation reused the overflow attribute set for every new measurement after that stream was created, even when the cardinality limit had not been reached. Only route new attribute sets to the overflow stream once the aggregation limit is actually exceeded. Fixes open-telemetry#8776 Signed-off-by: lllakshit <llakshitmathur239@gmail.com>
lllakshit
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
August 31, 2026 06:00
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8776
Exponential histogram aggregation treated any existing
otel.metric.overflow=truestream as proof that cardinality overflow had already occurred. After that stream was created, every later unseen attribute set was folded into it, even whenAggregationLimitwas0(unlimited).This change only reuses the overflow stream when the aggregation limit is actually reached. With no limit,
overflowSetremains a normal distinct stream and later attribute sets get their own data points.Test plan
TestExpoHistogramOverflowAttributeBeforeLimitTestExpoHistogramOverflowstill passes (limit enforcement unchanged)go test ./sdk/metric/internal/aggregate -run 'TestExpoHistogramOverflow' -count=1