Repository navigation
Use precise invocation types across DSPy, Smolagents, OpenAI Agents, and OpenAI - #706
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The annotations align with handler return types and introduce no behavioral regressions.
Pull request overview
Refines invocation type annotations across four instrumentations without changing runtime behavior.
Changes:
- Replaces generic invocation annotations with concrete operation types.
- Uses public util-genai invocation imports in OpenAI response wrappers.
File summaries
| File | Description |
|---|---|
smolagents/patch.py |
Narrows completion helper types. |
openai/response_wrappers.py |
Uses public, concrete response invocation types. |
openai_agents/processor.py |
Narrows stored invocation types. |
dspy/patch.py |
Uses LocalAgentInvocation for local agents. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pull request dashboard statusMerged · refreshed 2026-09-17 06:33 UTC Status above doesn't look right?
|
eternalcuriouslearner
approved these changes
Sep 13, 2026
Merged
via the queue into
open-telemetry:main
with commit Sep 13, 2026
b995901
75 of 76 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces generic
GenAIInvocationandAgentInvocationwith concrete invocation types (LocalAgentInvocation,InferenceInvocation,WorkflowInvocation,ToolInvocation) across DSPy, Smolagents, OpenAI Agents, and OpenAI. Replaces the private import fromopentelemetry.util.genai._invocationin OpenAI response wrappers with public imports.