Repository navigation
Coerce top_k request attribute to integer across Bedrock, Portkey, and Smolagents - #707
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The shared field remains typed as float, while Bedrock and Portkey lack type-sensitive regression coverage.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Aligns gen_ai.request.top_k telemetry with the semantic convention’s integer type.
Changes:
- Uses integer coercion in Bedrock, Portkey, and Smolagents.
- Updates Smolagents type assertions.
- Adds changelog fragments.
File summaries
| File | Description |
|---|---|
...smolagents/tests/test_models.py |
Expects integer top_k. |
...smolagents/patch.py |
Uses integer coercion. |
...smolagents/.changelog/707.fixed |
Documents the fix. |
...portkey/utils.py |
Converts top_k to integer. |
...portkey/.changelog/707.fixed |
Documents the fix. |
...bedrock/extractors.py |
Uses safe integer conversion. |
...bedrock/.changelog/707.fixed |
Documents the fix. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
eternalcuriouslearner
approved these changes
Sep 13, 2026
Pull request dashboard statusMerged · refreshed 2026-09-17 06:33 UTC Status above doesn't look right?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coerces top_k request parameter to int instead of float in Bedrock, Portkey, and Smolagents instrumentations, and updates Smolagents test expectations.
Aligns with gen_ai.request.top_k, which specifies top_k as integer type.