Skip to content

[opentelemetry-instrumentation-genai-openai-agents] Do not record gen_ai.provider.name on tool execution metrics #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmolkova merged 2 commits into from
Sep 13, 2026
Merged

[opentelemetry-instrumentation-genai-openai-agents] Do not record gen_ai.provider.name on tool execution metrics #710

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
446e770
Do not record gen_ai.provider.name on tool execution metric attributes
lmolkova Sep 13, 2026
ecc2a10
Assert absence of gen_ai.provider.name from tool metric attributes
lmolkova Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions instrumentation/opentelemetry-instrumentation-genai-openai-agents/.changelog/710.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not record `gen_ai.provider.name` on tool execution metric attributes.
10 changes: 0 additions & 10 deletions ...on-genai-openai-agents/src/opentelemetry/instrumentation/genai/openai_agents/processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@
FunctionSpanData,
)

from opentelemetry.semconv._incubating.attributes import (
gen_ai_attributes as GenAI,
)
from opentelemetry.semconv._incubating.attributes.error_attributes import (
ErrorTypeValues,
)
Expand Down Expand Up @@ -117,13 +114,6 @@ def on_span_start(self, span: Span[Any]) -> None:
name=span_data.name,
tool_type="function",
)

# ToolInvocation does not include provider in metric attributes
# by default; set it so gen_ai.client.operation.duration carries
# the required gen_ai.provider.name attribute.
invocation.metric_attributes[GenAI.GEN_AI_PROVIDER_NAME] = (
self._provider
)
self._invocations[span] = invocation
return
# Other span_data types (GenerationSpanData, ResponseSpanData,
Expand Down
8 changes: 1 addition & 7 deletions instrumentation/opentelemetry-instrumentation-genai-openai-agents/tests/test_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,7 @@ def test_agent_span_creates_invoke_local_agent() -> None:
handler.invoke_local_agent.return_value.stop.assert_called_once_with()


def test_function_span_creates_tool_invocation_and_sets_provider_metric() -> (
None
):
def test_function_span_creates_tool_invocation() -> None:
handler = _build_handler()
handler.tool.return_value = MagicMock(
spec=ToolInvocation,
Expand All @@ -109,10 +107,6 @@ def test_function_span_creates_tool_invocation_and_sets_provider_metric() -> (
)
tool_invocation = handler.tool.return_value
Comment thread
lmolkova marked this conversation as resolved.

assert (
tool_invocation.metric_attributes["gen_ai.provider.name"] == "openai"
)

# Input and output both get populated on the agents library span_data
# while the tool runs, i.e. after on_span_start; our on_span_end reads
# them.
Expand Down
Loading