Repository navigation
[opentelemetry-instrumentation-genai-agno] Add instrumentation for agno model calls - #773
Conversation
opentelemetry-instrumentation-genai-agno] Add instrumentation for agno model calls
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-17 01:44 UTC Review the latest changes. Status above doesn't look right?
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Model spans start after inference, stream managers are wrapped incorrectly, and required tests are missing.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (6)
Wrap outer synchronous model call to capture latency and failures · New Use synchronous stream manager wrapper for context-manager API · New Decode JSON tool-call arguments before storing them · New Add and register chat conformance scenario · New Test synchronous stream early close and single finalization · New Test async stream interruptions, errors, and early close · New
What changed in this PR
Adds Agno model-call telemetry for synchronous, asynchronous, streaming, multimodal, and error paths.
Changes:
- Adds GenAI
chatinstrumentation and stream wrappers. - Adds provider/message/media extraction utilities.
- Adds model tests and documentation.
| File | Description |
|---|---|
patch.py |
Patches model response processing. |
stream.py |
Adds model stream telemetry wrappers. |
utils.py |
Adds model and multimodal extraction. |
test_model.py |
Tests model instrumentation. |
test_embedder.py |
Makes Gemini tests optional. |
README.rst |
Documents model operations. |
.changelog/773.added |
Records the feature. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
24e7603 to
2c94b98
Compare
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
7b28898 to
3165b6f
Compare
3165b6f to
dcd39d4
Compare
dcd39d4 to
76089fc
Compare



Description
Probably want to wait until #765 lands to avoid duplicate inference calls, but eventually we will want this and that PR will not change the implementation here.
I think once this lands we will have reached parity with the
agnoinstrumentations in open inference and other places..Type of change
How has this been tested?
Unot tests
Checklist