Repository navigation
Conversation
tracing names an unnamed event "event <file>:<line>": a source location, not a class of event. Set EventName only when the name was given explicitly, so plain logs are no longer exported as Events. Fixes open-telemetry#3797
Pull request dashboard statusWaiting on the author · refreshed 2026-10-17 01:45 UTC Investigate required status check failures. Status above doesn't look right?
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3798 +/- ##
=======================================
- Coverage 84.2% 84.2% -0.1%
=======================================
Files 123 123
Lines 30484 30492 +8
=======================================
+ Hits 25686 25692 +6
- Misses 4798 4800 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
The one red job, |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3797
Design discussion issue (if applicable) #3797
Changes
tracing's event macros name an unnamed eventconcat!("event ", file!(), ":", line!()). The bridge forwarded that name as the record'sEventName, so every plain log was exported as an Event whose "type" is a source location that changes with each edit above the call site.The bridge now sets
EventNameonly when the name was given explicitly (name: "..."). A name is treated as synthesized iff it equals"event " + meta.file() + ":" + meta.line(). The check is exact, uses theMetadatathe bridge already holds, and does not allocate.Logger::event_enabledreceives the sameOptionthat gets exported, soNonefor those records.layer.rs:is_synthesized_event_name, used inon_event. The existing "target, eventname are not explicitly provided" test now asserts that noEventNameis set, instead of asserting the synthesized one.lib.rs: the mapping table no longer says everytracingevent is an OTel Event.CHANGELOG.md: listed as breaking, since anyone filtering on or reading the synthesized name sees it disappear.Out of scope, noted in the issue: the fixed
"log event"name thattracing-loggives records bridged from thelogcrate.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes