Skip to content

Stop cancelling non-PR CodeQL and test runs - #432

Merged
trask merged 1 commit into
mainfrom
trask-review-pr-430
Oct 2, 2026
Merged

trask merged 1 commit into
mainfrom
trask-review-pr-430

Conversation

@trask

@trask trask commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Apply the concurrency fix from @TylerHelmuth's #430 to CodeQL, dashboard tests, and queue collector tests. Use github.run_id instead of github.ref for non-PR runs so successive pushes to main no longer cancel earlier runs.

New pushes to the same PR still cancel older runs. CodeQL keeps its language-specific grouping.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-02 15:23 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@trask
trask marked this pull request as ready for review September 30, 2026 23:53
@trask
trask requested a review from a team as a code owner September 30, 2026 23:53
@trask
trask requested a review from mx-psi September 30, 2026 23:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The changes correctly isolate non-PR runs while retaining cancellation for superseded PR runs.

Review effort: Balanced
Findings: None

What changed in this PR

Updates workflow concurrency so non-PR runs no longer cancel earlier runs, while preserving PR cancellation behavior.

Changes:

  • Uses github.run_id for non-PR concurrency groups.
  • Preserves language-specific CodeQL grouping.
File Description
.github/​workflows/​pull-request-dashboard-test.yml Updates test-run concurrency grouping.
.github/​workflows/​github-actions-queue-test.yml Updates queue-test concurrency grouping.
.github/​workflows/​codeql.yml Updates per-language CodeQL concurrency grouping.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@trask
trask merged commit 508cf83 into main Oct 2, 2026
8 checks passed
@trask
trask deleted the trask-review-pr-430 branch October 2, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants