Skip to content

feat: add author badges in PR dashboard - #490

Merged
trask merged 3 commits into
open-telemetry:mainfrom
martincostello:add-author-emoji-badges
Oct 26, 2026
Merged

trask merged 3 commits into
open-telemetry:mainfrom
martincostello:add-author-emoji-badges

Conversation

@martincostello

@martincostello martincostello commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Add author badges to the PR dashboard, including draft PRs, to help with triage:

  • 🆕 first-time contributor, based on GitHub's author association.
  • 🔭 open-telemetry member, based on GitHub's author association.
  • 🛠️ approver or maintainer, based on membership in the configured approver teams, including child maintainer teams.
  • 🤖 bot.

Each author gets at most one badge, with bots taking precedence over approvers or maintainers, then organization members, then first-time contributors. Other authors have no badge.

For Copilot PRs displayed under a human author, badges use that person's approver-team membership rather than Copilot's account type or author association. The existing approver-teams configuration supplies team membership through APPROVER_TEAMS_JSON; no new configuration is required.

Example dashboard:


Note

Open non-draft PRs grouped by who is expected to act next. Draft PRs are listed separately. The grouping is partly performed by an LLM (source) and could contain mistakes.

Author column: 🆕 first-time contributor · 🔭 open-telemetry member · 🛠️ approver or maintainer · 🤖 bot.

Reviewers column: ✅ active approval · ✔️ active approval (non-code-owner) · ⏳ review pending · 💬 unresolved feedback from reviewer · 📌 top-level feedback needs author action · 🔴 changes requested.

CI column: ✅ passing · ⏳ running · ❌ failing · 🔐 workflow action required.

Waiting on maintainers

PR Author Reviewers CI Conflicts Age
#103 Update dependency foo to v2 app/renovate 🤖 a-maintainer ✅ ✅ ✅ 5h

Waiting on reviewers

PR Author Reviewers CI Conflicts Age
#101 Add exporter retry option first-timer 🆕 reviewer-a ⏳ ✅ ✅ 3d
#102 Fix span link propagation org-member 🔭 reviewer-b ✅ ✅ ✅ 1d
#104 Refactor metric readers a-maintainer 🛠️ ⏳ ✅ 20h

Waiting on authors

PR Author Reviewers CI Conflicts Age
#105 Docs: clarify sampler config returning-contributor reviewer-a 💬 ❌ ✅ 6d
#106 Copilot: tidy up tests a-maintainer 🛠️ ✅ ❌ 2d

Draft pull requests

PR Author Draft age
#107 WIP: new log processor first-timer-2 🆕 10d
#108 WIP: benchmark harness a-maintainer 🛠️ 10d

Update the PR dashboard to add an emoji badge to authors to show their "role" relative to the repository. Badges are added for first-time contributors, open-telemetry org members, bots and maintainers.
@martincostello
martincostello marked this pull request as ready for review October 22, 2026 15:24
@martincostello
martincostello requested review from a team and trask as code owners October 22, 2026 15:24
Copilot AI balanced review requested due to automatic review settings October 22, 2026 15:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-26 16:28 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Comment thread pull-request-dashboard/README.md Outdated
Address review feedback and extend to add approvers and triagers.
@trask

trask commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

I like 🆕 and 🔭 and 🤖

I wonder if we need maintainer/approver/triager icons? seems a little busy and not sure what to do with that information (and probably reviewers/maintainer recognize those people anyways).

@martincostello

Copy link
Copy Markdown
Member Author

I added maintainer for a quick "in the team" check at a glance rather than needing to read through all the names in the tables - the other two were added based on other feedback.

@trask

trask commented Oct 26, 2026

Copy link
Copy Markdown
Member

I added maintainer for a quick "in the team" check at a glance

how about "in the team" including approvers (i.e. those who have write access to the repo), and dropping the icon for triagers? just trying to keep it from getting too busy...

@martincostello

Copy link
Copy Markdown
Member Author

OK cool - which icon should we go with?

@Kielek

Kielek commented Oct 26, 2026

Copy link
Copy Markdown
Member

I am fine with/without any icons for maintainers, the question was kind of for consideration : )

@trask

trask commented Oct 26, 2026

Copy link
Copy Markdown
Member

I like 🛠️

Combine maintainers and approvers into the same badge and remove triagers.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused changes preserve badge precedence and effective-author handling, with regression coverage and no unresolved blocking issues.

No open issues 🎉

Review effort: Balanced

@trask
trask merged commit efc5583 into open-telemetry:main Oct 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants